Patchwork rpm: split out run-postinsts

login
register
mail settings
Submitter Zhenhua Luo
Date March 20, 2013, 9:39 a.m.
Message ID <1363772395-25682-1-git-send-email-zhenhua.luo@freescale.com>
Download mbox | patch
Permalink /patch/46559/
State Superseded
Headers show

Comments

Zhenhua Luo - March 20, 2013, 9:39 a.m.
Split out run-postinsts script into separated package, sometimes only the
postinsts script is required to run all postinsts scripts in /etc/rpm-postinsts/
instead of the whole rpm package

Signed-off-by: Zhenhua Luo <zhenhua.luo@freescale.com>
---
 meta/recipes-devtools/rpm/rpm_5.4.9.bb |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Saul Wold - March 20, 2013, 6:52 p.m.
On 03/20/2013 02:39 AM, Zhenhua Luo wrote:
> Split out run-postinsts script into separated package, sometimes only the
> postinsts script is required to run all postinsts scripts in /etc/rpm-postinsts/
> instead of the whole rpm package
>
So are you trying to build a system that uses RPM to install the initial 
rootfs, but you don't want RPM actually installed?


> Signed-off-by: Zhenhua Luo <zhenhua.luo@freescale.com>
> ---
>   meta/recipes-devtools/rpm/rpm_5.4.9.bb |    6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-devtools/rpm/rpm_5.4.9.bb b/meta/recipes-devtools/rpm/rpm_5.4.9.bb
> index 6286771..896e3a4 100644
> --- a/meta/recipes-devtools/rpm/rpm_5.4.9.bb
> +++ b/meta/recipes-devtools/rpm/rpm_5.4.9.bb
> @@ -43,7 +43,7 @@ LICENSE = "LGPLv2.1"
>   LIC_FILES_CHKSUM = "file://COPYING.LIB;md5=2d5025d4aa3495befef8f17206a5b0a1"
>
>   DEPENDS = "libpcre attr acl popt ossp-uuid file bison-native"
> -PR = "r61"
> +PR = "r62"
>
>   # rpm2cpio is a shell script, which is part of the rpm src.rpm.  It is needed
>   # in order to extract the distribution SRPM into a format we can extract...
> @@ -223,9 +223,11 @@ FILES_${PN} =  "${bindir}/rpm \
>   		${libdir}/rpm/bin/wget \
>   		/var/lib/rpm \
>   		/var/cache/rpm \
> -		${sysconfdir}/rcS.d/S${POSTINSTALL_INITPOSITION}run-postinsts \
>   		"
>
> +FILES_${PN}-postinsts = "${sysconfdir}/rcS.d/S${POSTINSTALL_INITPOSITION}run-postinsts \
> +                "
> +

This does not look right to me, you seem to be missing a PACKAGES entry 
for the postinsts package. So this really won't do anything.

Sau!


>   FILES_${PN}-dbg += "${libdir}/rpm/.debug \
>   		${libdir}/rpm/bin/.debug \
>   		"
>
Mark Hatle - March 20, 2013, 6:57 p.m.
On 3/20/13 1:52 PM, Saul Wold wrote:
> On 03/20/2013 02:39 AM, Zhenhua Luo wrote:
>> Split out run-postinsts script into separated package, sometimes only the
>> postinsts script is required to run all postinsts scripts in /etc/rpm-postinsts/
>> instead of the whole rpm package
>>
> So are you trying to build a system that uses RPM to install the initial
> rootfs, but you don't want RPM actually installed?

That seems reasonable to me.  I hadn't realized that it was rolled into the 
target RPM package like this.  In early implementations this script was 
installed directly by the rootfs_rpm.

--Mark

>
>> Signed-off-by: Zhenhua Luo <zhenhua.luo@freescale.com>
>> ---
>>    meta/recipes-devtools/rpm/rpm_5.4.9.bb |    6 ++++--
>>    1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-devtools/rpm/rpm_5.4.9.bb b/meta/recipes-devtools/rpm/rpm_5.4.9.bb
>> index 6286771..896e3a4 100644
>> --- a/meta/recipes-devtools/rpm/rpm_5.4.9.bb
>> +++ b/meta/recipes-devtools/rpm/rpm_5.4.9.bb
>> @@ -43,7 +43,7 @@ LICENSE = "LGPLv2.1"
>>    LIC_FILES_CHKSUM = "file://COPYING.LIB;md5=2d5025d4aa3495befef8f17206a5b0a1"
>>
>>    DEPENDS = "libpcre attr acl popt ossp-uuid file bison-native"
>> -PR = "r61"
>> +PR = "r62"
>>
>>    # rpm2cpio is a shell script, which is part of the rpm src.rpm.  It is needed
>>    # in order to extract the distribution SRPM into a format we can extract...
>> @@ -223,9 +223,11 @@ FILES_${PN} =  "${bindir}/rpm \
>>    		${libdir}/rpm/bin/wget \
>>    		/var/lib/rpm \
>>    		/var/cache/rpm \
>> -		${sysconfdir}/rcS.d/S${POSTINSTALL_INITPOSITION}run-postinsts \
>>    		"
>>
>> +FILES_${PN}-postinsts = "${sysconfdir}/rcS.d/S${POSTINSTALL_INITPOSITION}run-postinsts \
>> +                "
>> +
>
> This does not look right to me, you seem to be missing a PACKAGES entry
> for the postinsts package. So this really won't do anything.
>
> Sau!
>
>
>>    FILES_${PN}-dbg += "${libdir}/rpm/.debug \
>>    		${libdir}/rpm/bin/.debug \
>>    		"
>>
Zhenhua Luo - March 21, 2013, 1:57 a.m.
> -----Original Message-----
> From: Mark Hatle [mailto:mark.hatle@windriver.com]
> Sent: Thursday, March 21, 2013 2:58 AM
> 
> On 3/20/13 1:52 PM, Saul Wold wrote:
> > On 03/20/2013 02:39 AM, Zhenhua Luo wrote:
> >> Split out run-postinsts script into separated package, sometimes only
> >> the postinsts script is required to run all postinsts scripts in
> >> /etc/rpm-postinsts/ instead of the whole rpm package
> >>
> > So are you trying to build a system that uses RPM to install the
> > initial rootfs, but you don't want RPM actually installed?
> 
> That seems reasonable to me.  I hadn't realized that it was rolled into
> the target RPM package like this.  In early implementations this script
> was installed directly by the rootfs_rpm.
[Luo Zhenhua-B19537] Yes, in my use case, I only need the postinits script instead of whole rpm package. 

> >> Signed-off-by: Zhenhua Luo <zhenhua.luo@freescale.com>
> >> ---
> >>    meta/recipes-devtools/rpm/rpm_5.4.9.bb |    6 ++++--
> >>    1 file changed, 4 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/meta/recipes-devtools/rpm/rpm_5.4.9.bb
> >> b/meta/recipes-devtools/rpm/rpm_5.4.9.bb
> >> index 6286771..896e3a4 100644
> >> --- a/meta/recipes-devtools/rpm/rpm_5.4.9.bb
> >> +++ b/meta/recipes-devtools/rpm/rpm_5.4.9.bb
> >> @@ -43,7 +43,7 @@ LICENSE = "LGPLv2.1"
> >>    LIC_FILES_CHKSUM =
> "file://COPYING.LIB;md5=2d5025d4aa3495befef8f17206a5b0a1"
> >>
> >>    DEPENDS = "libpcre attr acl popt ossp-uuid file bison-native"
> >> -PR = "r61"
> >> +PR = "r62"
> >>
> >>    # rpm2cpio is a shell script, which is part of the rpm src.rpm.  It
> is needed
> >>    # in order to extract the distribution SRPM into a format we can
> extract...
> >> @@ -223,9 +223,11 @@ FILES_${PN} =  "${bindir}/rpm \
> >>    		${libdir}/rpm/bin/wget \
> >>    		/var/lib/rpm \
> >>    		/var/cache/rpm \
> >> -		${sysconfdir}/rcS.d/S${POSTINSTALL_INITPOSITION}run-postinsts
> \
> >>    		"
> >>
> >> +FILES_${PN}-postinsts =
> "${sysconfdir}/rcS.d/S${POSTINSTALL_INITPOSITION}run-postinsts \
> >> +                "
> >> +
> >
> > This does not look right to me, you seem to be missing a PACKAGES
> > entry for the postinsts package. So this really won't do anything.
[Luo Zhenhua-B19537] I will submit v2 to add the entry. 


Best Regards,

Zhenhua

Patch

diff --git a/meta/recipes-devtools/rpm/rpm_5.4.9.bb b/meta/recipes-devtools/rpm/rpm_5.4.9.bb
index 6286771..896e3a4 100644
--- a/meta/recipes-devtools/rpm/rpm_5.4.9.bb
+++ b/meta/recipes-devtools/rpm/rpm_5.4.9.bb
@@ -43,7 +43,7 @@  LICENSE = "LGPLv2.1"
 LIC_FILES_CHKSUM = "file://COPYING.LIB;md5=2d5025d4aa3495befef8f17206a5b0a1"
 
 DEPENDS = "libpcre attr acl popt ossp-uuid file bison-native"
-PR = "r61"
+PR = "r62"
 
 # rpm2cpio is a shell script, which is part of the rpm src.rpm.  It is needed
 # in order to extract the distribution SRPM into a format we can extract...
@@ -223,9 +223,11 @@  FILES_${PN} =  "${bindir}/rpm \
 		${libdir}/rpm/bin/wget \
 		/var/lib/rpm \
 		/var/cache/rpm \
-		${sysconfdir}/rcS.d/S${POSTINSTALL_INITPOSITION}run-postinsts \
 		"
 
+FILES_${PN}-postinsts = "${sysconfdir}/rcS.d/S${POSTINSTALL_INITPOSITION}run-postinsts \
+                "
+
 FILES_${PN}-dbg += "${libdir}/rpm/.debug \
 		${libdir}/rpm/bin/.debug \
 		"