Patchwork [2/6] mkefidisk: Always specify a root= kernel parameter

mail settings
Submitter Darren Hart
Date March 19, 2013, 10:15 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/46507/
State Accepted
Commit e5dbec7e7d3bb29676280823b0337ad429c75120
Headers show


Darren Hart - March 19, 2013, 10:15 p.m.
The current script only replaces an existing root= kernel parameter
which can result images created without a root= paremeter, even though
the script expects a target rootfs parameter.

Rather than replacing the root= parameter, delete the root= parameter if
it exists, then append an appropriate root= parameter.

Fixes [YOCTO 4035] forgets to add root= parameter

Signed-off-by: Darren Hart <>
Cc: Koen Kooi <>
 scripts/contrib/ | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)


diff --git a/scripts/contrib/ b/scripts/contrib/
index 701a4d0..c68c224 100755
--- a/scripts/contrib/
+++ b/scripts/contrib/
@@ -250,8 +250,10 @@  sed -i "/menuentry 'install'/,/^}/d" $GRUBCFG
 sed -i "/initrd /d" $GRUBCFG
 # Delete any LABEL= strings
 sed -i "s/ LABEL=[^ ]*/ /" $GRUBCFG
-# Replace the ramdisk root with the install device and include other options
-sed -i "s@ root=[^ ]*@ root=$TARGET_ROOTFS rw $ROOTWAIT quiet@" $GRUBCFG
+# Replace the ramdisk root (if any) with the install device and include other
+# kernel parameters
+sed -i "s@ root=[^ ]*@ @" $GRUBCFG
+sed -i "s@vmlinuz @vmlinuz root=$TARGET_ROOTFS rw $ROOTWAIT quiet @" $GRUBCFG
 # Provide a startup.nsh script for older firmware with non-standard boot
 # directories and paths.