Patchwork [v3,3/3] qt-mobility: added list of modules to be compiled

login
register
mail settings
Submitter eu@felipetonello.com
Date March 19, 2013, 9:54 p.m.
Message ID <1363730053-7719-4-git-send-email-eu@felipetonello.com>
Download mbox | patch
Permalink /patch/46501/
State New
Headers show

Comments

eu@felipetonello.com - March 19, 2013, 9:54 p.m.
From: "Felipe F. Tonello" <ftonello@cercacor.com>

This is useful for users that want to .bbappend this recipe to select specific
modules to be compiled.

Signed-off-by: Felipe F. Tonello <ftonello@cercacor.com>
---
 meta/recipes-qt/qt4/qt-mobility_1.2.0.inc |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Paul Eggleton - March 20, 2013, 6:12 p.m.
Hi Felipe,

On Tuesday 19 March 2013 14:54:13 eu@felipetonello.com wrote:
> From: "Felipe F. Tonello" <ftonello@cercacor.com>
> 
> This is useful for users that want to .bbappend this recipe to select
> specific modules to be compiled.
> 
> Signed-off-by: Felipe F. Tonello <ftonello@cercacor.com>
> ---
>  meta/recipes-qt/qt4/qt-mobility_1.2.0.inc |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc
> b/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc index fca4cb0..b0ab613 100644
> --- a/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc
> +++ b/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc
> @@ -18,7 +18,7 @@ SRC_URI =
> "http://get.qt.nokia.com/qt/add-ons/qt-mobility-opensource-src-${PV}.t
> SRC_URI[md5sum]="ea5db5a8d3dd4709c2926dceda646bd8"
>  SRC_URI[sha256sum]="ee3c88975e04139ac9589f76d4be646d44fcbc4c8c1cf2db621abc1
> 54cf0ba44"
> 
> -PR = "r7"
> +PR = "r8"
> 
>  S = "${WORKDIR}/qt-mobility-opensource-src-${PV}"
> 
> @@ -31,6 +31,8 @@ qtm_plugins	:= "/usr/lib/${qtm_dir}/plugins/QtMobility"
>  qtm_data	:= "/usr/share/${qtm_dir}"
>  qtm_imports	:= "/usr/lib/${qtm_dir}/imports"
> 
> +qtm_modules_list ?= "bearer contacts gallery location publishsubscribe
> messaging multimedia \ +systeminfo serviceframework sensors versit
> organizer feedback connectivity" qtm_bluezflag ?=
> "${@base_contains('DISTRO_FEATURES', 'bluetooth', 'yes', 'no', d)}"

Typically variable names like this should be upper case; I know we've got some 
lower case ones in here already but let's not introduce any more that we'll 
have difficulty changing later.

Cheers,
Paul
eu@felipetonello.com - March 20, 2013, 6:31 p.m.
Hi Paul,

On 03/20/2013 11:12 AM, Paul Eggleton wrote:
> Hi Felipe,
>
> On Tuesday 19 March 2013 14:54:13 eu@felipetonello.com wrote:
>> From: "Felipe F. Tonello" <ftonello@cercacor.com>
>>
>> This is useful for users that want to .bbappend this recipe to select
>> specific modules to be compiled.
>>
>> Signed-off-by: Felipe F. Tonello <ftonello@cercacor.com>
>> ---
>>   meta/recipes-qt/qt4/qt-mobility_1.2.0.inc |    6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc
>> b/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc index fca4cb0..b0ab613 100644
>> --- a/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc
>> +++ b/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc
>> @@ -18,7 +18,7 @@ SRC_URI =
>> "http://get.qt.nokia.com/qt/add-ons/qt-mobility-opensource-src-${PV}.t
>> SRC_URI[md5sum]="ea5db5a8d3dd4709c2926dceda646bd8"
>>   SRC_URI[sha256sum]="ee3c88975e04139ac9589f76d4be646d44fcbc4c8c1cf2db621abc1
>> 54cf0ba44"
>>
>> -PR = "r7"
>> +PR = "r8"
>>
>>   S = "${WORKDIR}/qt-mobility-opensource-src-${PV}"
>>
>> @@ -31,6 +31,8 @@ qtm_plugins	:= "/usr/lib/${qtm_dir}/plugins/QtMobility"
>>   qtm_data	:= "/usr/share/${qtm_dir}"
>>   qtm_imports	:= "/usr/lib/${qtm_dir}/imports"
>>
>> +qtm_modules_list ?= "bearer contacts gallery location publishsubscribe
>> messaging multimedia \ +systeminfo serviceframework sensors versit
>> organizer feedback connectivity" qtm_bluezflag ?=
>> "${@base_contains('DISTRO_FEATURES', 'bluetooth', 'yes', 'no', d)}"
>
> Typically variable names like this should be upper case; I know we've got some
> lower case ones in here already but let's not introduce any more that we'll
> have difficulty changing later.

Alright. I just sent a v4.

Felipe

Patch

diff --git a/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc b/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc
index fca4cb0..b0ab613 100644
--- a/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc
+++ b/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc
@@ -18,7 +18,7 @@  SRC_URI = "http://get.qt.nokia.com/qt/add-ons/qt-mobility-opensource-src-${PV}.t
 SRC_URI[md5sum]="ea5db5a8d3dd4709c2926dceda646bd8"
 SRC_URI[sha256sum]="ee3c88975e04139ac9589f76d4be646d44fcbc4c8c1cf2db621abc154cf0ba44"
 
-PR = "r7"
+PR = "r8"
 
 S = "${WORKDIR}/qt-mobility-opensource-src-${PV}"
 
@@ -31,6 +31,8 @@  qtm_plugins	:= "/usr/lib/${qtm_dir}/plugins/QtMobility"
 qtm_data	:= "/usr/share/${qtm_dir}"
 qtm_imports	:= "/usr/lib/${qtm_dir}/imports"
 
+qtm_modules_list ?= "bearer contacts gallery location publishsubscribe messaging multimedia \
+systeminfo serviceframework sensors versit organizer feedback connectivity"
 qtm_bluezflag ?= "${@base_contains('DISTRO_FEATURES', 'bluetooth', 'yes', 'no', d)}"
 
 do_configure_prepend() {
@@ -44,7 +46,7 @@  do_configure_prepend() {
 	cp staticconfig.pri staticconfig.pri.old
 	echo "include(${STAGING_DATADIR}/${qtm_dir}/mkspecs/qconfig.pri)" >staticconfig.pri
 	cat staticconfig.pri.old >>staticconfig.pri
-	./configure -qmake-exec qmake2 -prefix /usr -examples -demos
+	./configure -qmake-exec qmake2 -prefix /usr -examples -demos -modules "${qtm_modules_list}"
 	echo QT_MOBILITY_BIN = ${qtm_bin} >>./config.pri
 	echo QT_MOBILITY_LIB = ${qtm_lib} >>./config.pri
 	echo QT_MOBILITY_INCLUDE = ${qtm_include} >>./config.pri