| Submitter | eu@felipetonello.com |
|---|---|
| Date | March 19, 2013, 9:54 p.m. |
| Message ID | <1363730053-7719-3-git-send-email-eu@felipetonello.com> |
| Download | mbox | patch |
| Permalink | /patch/46499/ |
| State | New |
| Headers | show |
Comments
On Tue, Mar 19, 2013 at 6:54 PM, <eu@felipetonello.com> wrote: > From: "Felipe F. Tonello" <ftonello@cercacor.com> > > Signed-off-by: Felipe F. Tonello <ftonello@cercacor.com> > --- > meta/recipes-qt/qt4/qt-mobility_1.2.0.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc b/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc > index e5e671e..fca4cb0 100644 > --- a/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc > +++ b/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc > @@ -1,5 +1,5 @@ > HOMEPAGE = "http://qt.nokia.com" > -DEPENDS += "pulseaudio" > +DEPENDS += "${@base_contains('DISTRO_FEATURES', 'pulseaudio', 'pulseaudio', '', d)}" > DEPENDS += "${@base_contains('DISTRO_FEATURES', 'bluetooth', 'bluez4', '', d)}" Is it possible to explicitly enable/disable pulseaudio support?
On 20 March 2013 14:04, Otavio Salvador <otavio@ossystems.com.br> wrote:
> Is it possible to explicitly enable/disable pulseaudio support?
Isn't PA one of those "all or nothing" options? If your system is
using PA then you want support for it everywhere, if it's not then you
don't want it present at all.
Ross
On Wed, Mar 20, 2013 at 11:56 AM, Burton, Ross <ross.burton@intel.com> wrote: > On 20 March 2013 14:04, Otavio Salvador <otavio@ossystems.com.br> wrote: >> Is it possible to explicitly enable/disable pulseaudio support? > > Isn't PA one of those "all or nothing" options? If your system is > using PA then you want support for it everywhere, if it's not then you > don't want it present at all. Yes but if we don't explicitly disable/enable it we risk to do a host contamination (for example building for same host arch)
On 20 March 2013 15:04, Otavio Salvador <otavio@ossystems.com.br> wrote: > Yes but if we don't explicitly disable/enable it we risk to do a host > contamination (for example building for same host arch) Oh, right, your context wasn't clear. Yes, totally agreed, and this is exactly why PACKAGECONFIG is so great. Ross
Patch
diff --git a/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc b/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc index e5e671e..fca4cb0 100644 --- a/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc +++ b/meta/recipes-qt/qt4/qt-mobility_1.2.0.inc @@ -1,5 +1,5 @@ HOMEPAGE = "http://qt.nokia.com" -DEPENDS += "pulseaudio" +DEPENDS += "${@base_contains('DISTRO_FEATURES', 'pulseaudio', 'pulseaudio', '', d)}" DEPENDS += "${@base_contains('DISTRO_FEATURES', 'bluetooth', 'bluez4', '', d)}" LICENSE = "LGPLv2.1"