Patchwork apr-util: disable odbc support to avoid QA error

login
register
mail settings
Submitter Steffen Sledz
Date May 23, 2011, 2:07 p.m.
Message ID <1306159627-10568-1-git-send-email-sledz@dresearch-fe.de>
Download mbox | patch
Permalink /patch/4647/
State Accepted
Headers show

Comments

Steffen Sledz - May 23, 2011, 2:07 p.m.
The odbc checker part of the configure script seems to be buggy and
may add host pathes to compiler and linker options:

--------->snip<--------
 checking for odbc_config... /usr/bin/odbc_config
   adding "-I/usr/include" to CPPFLAGS
   adding "-L/usr/lib" to LDFLAGS
   setting LIBS to "-L/usr/lib -lodbc"
--------->snip<--------

Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
---
 recipes/apr/apr-util_1.3.10.bb |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Steffen Sledz - May 24, 2011, 1:57 p.m.
On 23.05.2011 16:07, Steffen Sledz wrote:
> The odbc checker part of the configure script seems to be buggy and
> may add host pathes to compiler and linker options:
>
> --------->snip<--------
>   checking for odbc_config... /usr/bin/odbc_config
>     adding "-I/usr/include" to CPPFLAGS
>     adding "-L/usr/lib" to LDFLAGS
>     setting LIBS to "-L/usr/lib -lodbc"
> --------->snip<--------
>
> Signed-off-by: Steffen Sledz<sledz@dresearch-fe.de>

If there are no NAKs i'll push this commit tonight to enable the build on linux distros like openSUSE which fail at the moment.

Steffen
Paul Menzel - May 24, 2011, 8:58 p.m.
Am Montag, den 23.05.2011, 16:07 +0200 schrieb Steffen Sledz:
> The odbc checker part of the configure script seems to be buggy and
> may add host pathes to compiler and linker options:

s/patches/paths/

>
> --------->snip<--------
>  checking for odbc_config... /usr/bin/odbc_config
>    adding "-I/usr/include" to CPPFLAGS
>    adding "-L/usr/lib" to LDFLAGS
>    setting LIBS to "-L/usr/lib -lodbc"
> --------->snip<--------

Did you report that problem upstream?

Why is that a QA error? I would have guessed that the compilation would
fail.

> Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
> ---
>  recipes/apr/apr-util_1.3.10.bb |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/recipes/apr/apr-util_1.3.10.bb b/recipes/apr/apr-util_1.3.10.bb
> index ee32ddd..32b568e 100644
> --- a/recipes/apr/apr-util_1.3.10.bb
> +++ b/recipes/apr/apr-util_1.3.10.bb
> @@ -3,7 +3,7 @@ SECTION = "libs"
>  DEPENDS = "apr expat gdbm"
>  LICENSE = "Apache License, Version 2.0"
>  
> -PR = "r0"
> +PR = "r1"
>  
>  SRC_URI = "${APACHE_MIRROR}/apr/${P}.tar.gz \
>             file://configfix.patch \
> @@ -15,6 +15,7 @@ EXTRA_OECONF = "--with-apr=${STAGING_BINDIR_CROSS}/apr-1-config \
>  		--without-sqlite2 \
>  		--without-sqlite3 \
>  		--without-pgsql \
> +		--without-odbc \
>  		--with-expat=${STAGING_DIR_HOST}${layout_prefix}"
>  
>  SRC_URI[md5sum] = "82acd25cf3df8c72eba44eaee8b80c19"

Anyway, since `odbc_config` does not seem to be packaged for
OpenEmbedded, disabling that option seems like a sane thing.

Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>


Thanks,

Paul
Steffen Sledz - May 25, 2011, 6:02 a.m.
Am 24.05.2011 22:58, schrieb Paul Menzel:
> Am Montag, den 23.05.2011, 16:07 +0200 schrieb Steffen Sledz:
>> The odbc checker part of the configure script seems to be buggy and
>> may add host pathes to compiler and linker options:
> 
> s/patches/paths/

s/pathes/paths/  ;-)

>> --------->snip<--------
>>  checking for odbc_config... /usr/bin/odbc_config
>>    adding "-I/usr/include" to CPPFLAGS
>>    adding "-L/usr/lib" to LDFLAGS
>>    setting LIBS to "-L/usr/lib -lodbc"
>> --------->snip<--------
> 
> Why is that a QA error? I would have guessed that the compilation would
> fail.

I'm not at the HEAD of org.openembedded.dev but i got this fatal without my patch:

--------->snip<--------
FATAL: This autoconf log indicates errors, it looked at host includes.
Rerun configure task after fixing this. The path was '/home/sledz/work/HydraIP/OE/tmp.6/work/armv5te-angstrom-linux-gnueabi/apr-util-1.3.10-r0/apr-util-1.3.10'
ERROR: Error in executing python function in: /home/sledz/work/openembedded/recipes/apr/apr-util_1.3.10.bb
ERROR: Exception:<type 'exceptions.SystemExit'> Message:1
ERROR: Printing the environment of the function
ERROR: Function do_qa_configure failed
ERROR: TaskFailed event exception, aborting
ERROR: Build of /home/sledz/work/openembedded/recipes/apr/apr-util_1.3.10.bb do_qa_configure failed
NOTE: package apr-util-1.3.10-r0: task do_configure: Succeeded
ERROR: Task 12 (/home/sledz/work/openembedded/recipes/apr/apr-util_1.3.10.bb, do_qa_configure) failed with 256
ERROR: '/home/sledz/work/openembedded/recipes/apr/apr-util_1.3.10.bb' failed
NOTE: Running task 625 of 635 (ID: 12, /home/sledz/work/openembedded/recipes/apr/apr-util_1.3.10.bb, do_qa_configure)
NOTE: package apr-util-1.3.10-r0: task do_qa_configure: Started
FATAL: This autoconf log indicates errors, it looked at host includes.
Rerun configure task after fixing this. The path was '/home/sledz/work/HydraIP/OE/tmp.6/work/armv5te-angstrom-linux-gnueabi/apr-util-1.3.10-r0/apr-util-1.3.10'
ERROR: '/home/sledz/work/openembedded/recipes/apr/apr-util_1.3.10.bb' failed
--------->snip<--------

> Anyway, since `odbc_config` does not seem to be packaged for
> OpenEmbedded, disabling that option seems like a sane thing.
> 
> Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>

Thanx and pushed.

Steffen

Patch

diff --git a/recipes/apr/apr-util_1.3.10.bb b/recipes/apr/apr-util_1.3.10.bb
index ee32ddd..32b568e 100644
--- a/recipes/apr/apr-util_1.3.10.bb
+++ b/recipes/apr/apr-util_1.3.10.bb
@@ -3,7 +3,7 @@  SECTION = "libs"
 DEPENDS = "apr expat gdbm"
 LICENSE = "Apache License, Version 2.0"
 
-PR = "r0"
+PR = "r1"
 
 SRC_URI = "${APACHE_MIRROR}/apr/${P}.tar.gz \
            file://configfix.patch \
@@ -15,6 +15,7 @@  EXTRA_OECONF = "--with-apr=${STAGING_BINDIR_CROSS}/apr-1-config \
 		--without-sqlite2 \
 		--without-sqlite3 \
 		--without-pgsql \
+		--without-odbc \
 		--with-expat=${STAGING_DIR_HOST}${layout_prefix}"
 
 SRC_URI[md5sum] = "82acd25cf3df8c72eba44eaee8b80c19"