Patchwork [meta-fsl-ppc,danny] layer.conf: avoid unnecessary early expansion with :=

login
register
mail settings
Submitter Christopher Larson
Date March 19, 2013, 1:28 a.m.
Message ID <1363656511-16021-1-git-send-email-kergoth@gmail.com>
Download mbox | patch
Permalink /patch/46423/
State Accepted
Delegated to: Matthew McClintock
Headers show

Comments

Christopher Larson - March 19, 2013, 1:28 a.m.
From: Christopher Larson <chris_larson@mentor.com>

bitbake handles immediate expansions of LAYERDIR for us automatically.

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
 conf/layer.conf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Zhenhua Luo - March 26, 2013, 7:34 a.m.
Applied, thanks.


Best Regards,

Zhenhua


> -----Original Message-----
> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
> bounces@yoctoproject.org] On Behalf Of Christopher Larson
> Sent: Tuesday, March 19, 2013 9:29 AM
> To: meta-freescale@yoctoproject.org
> Cc: Christopher Larson
> Subject: [meta-freescale] [meta-fsl-ppc][danny][PATCH] layer.conf: avoid
> unnecessary early expansion with :=
> 
> From: Christopher Larson <chris_larson@mentor.com>
> 
> bitbake handles immediate expansions of LAYERDIR for us automatically.
> 
> Signed-off-by: Christopher Larson <chris_larson@mentor.com>
> ---
>  conf/layer.conf | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/conf/layer.conf b/conf/layer.conf index 9d2e54b..ad8c5f3
> 100644
> --- a/conf/layer.conf
> +++ b/conf/layer.conf
> @@ -1,11 +1,11 @@
>  # We have a packages directory, add to BBFILES -BBPATH :=
> "${BBPATH}:${LAYERDIR}"
> +BBPATH .= ":${LAYERDIR}"
> 
>  BBFILES += "${LAYERDIR}/recipes-*/*/*.bb*"
>  BBFILES += "${LAYERDIR}/images/*.bb*"
> 
>  BBFILE_COLLECTIONS += "fsl"
> -BBFILE_PATTERN_fsl := "^${LAYERDIR}/"
> +BBFILE_PATTERN_fsl = "^${LAYERDIR}/"
>  BBFILE_PRIORITY_fsl = "5"
> 
>  BB_ENV_EXTRAWHITE := "KSRC USRC"
> --
> 1.8.2
> 
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale

Patch

diff --git a/conf/layer.conf b/conf/layer.conf
index 9d2e54b..ad8c5f3 100644
--- a/conf/layer.conf
+++ b/conf/layer.conf
@@ -1,11 +1,11 @@ 
 # We have a packages directory, add to BBFILES
-BBPATH := "${BBPATH}:${LAYERDIR}"
+BBPATH .= ":${LAYERDIR}"
 
 BBFILES += "${LAYERDIR}/recipes-*/*/*.bb*"
 BBFILES += "${LAYERDIR}/images/*.bb*"
 
 BBFILE_COLLECTIONS += "fsl"
-BBFILE_PATTERN_fsl := "^${LAYERDIR}/"
+BBFILE_PATTERN_fsl = "^${LAYERDIR}/"
 BBFILE_PRIORITY_fsl = "5"
 
 BB_ENV_EXTRAWHITE := "KSRC USRC"