Patchwork [meta-fsl-arm] image_types_fsl.bbclass: fix partition type for SD card boot partition

login
register
mail settings
Submitter Vladan Jovanovic
Date March 18, 2013, 9:44 a.m.
Message ID <1363599874-12348-1-git-send-email-vladan.jovanovic@gmail.com>
Download mbox | patch
Permalink /patch/46367/
State Accepted
Delegated to: Otavio Salvador
Headers show

Comments

Vladan Jovanovic - March 18, 2013, 9:44 a.m.
Create first partition on SD card as fat32. As boot.img is formatted as vfat, this will ensure information in partition table matches actual partition type.

Signed-off-by: Vladan Jovanovic <vladan.jovanovic@gmail.com>
---
 classes/image_types_fsl.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Otavio Salvador - March 18, 2013, 11:53 a.m.
On Mon, Mar 18, 2013 at 6:44 AM, Vladan Jovanovic
<vladan.jovanovic@gmail.com> wrote:
> Create first partition on SD card as fat32. As boot.img is formatted as vfat, this will ensure information in partition table matches actual partition type.
>
> Signed-off-by: Vladan Jovanovic <vladan.jovanovic@gmail.com>

The long commit log needs to be down 80 colums. But more important is
does it fixes a bug you see or it is just cosmetic?

Patch

diff --git a/classes/image_types_fsl.bbclass b/classes/image_types_fsl.bbclass
index 6d1f6dd..b803aef 100644
--- a/classes/image_types_fsl.bbclass
+++ b/classes/image_types_fsl.bbclass
@@ -89,7 +89,7 @@  SDCARD_GENERATION_COMMAND_mx6 = "generate_imx_sdcard"
 generate_imx_sdcard () {
 	# Create partition table
 	parted -s ${SDCARD} mklabel msdos
-	parted -s ${SDCARD} unit KiB mkpart primary ${IMAGE_ROOTFS_ALIGNMENT} $(expr ${IMAGE_ROOTFS_ALIGNMENT} \+ ${BOOT_SPACE_ALIGNED})
+	parted -s ${SDCARD} unit KiB mkpart primary fat32 ${IMAGE_ROOTFS_ALIGNMENT} $(expr ${IMAGE_ROOTFS_ALIGNMENT} \+ ${BOOT_SPACE_ALIGNED})
 	parted -s ${SDCARD} unit KiB mkpart primary $(expr  ${IMAGE_ROOTFS_ALIGNMENT} \+ ${BOOT_SPACE_ALIGNED}) $(expr ${IMAGE_ROOTFS_ALIGNMENT} \+ ${BOOT_SPACE_ALIGNED} \+ $ROOTFS_SIZE)
 	parted ${SDCARD} print