Patchwork [06/12] systemd-compat-units: add missing systemd-systemctl-native dependency

login
register
mail settings
Submitter Ross Burton
Date March 11, 2013, 6:24 p.m.
Message ID <228e005f888afff7bd97f015e321a62071c09307.1363025917.git.ross.burton@intel.com>
Download mbox | patch
Permalink /patch/45975/
State Accepted
Commit b4b83eb092e2c1ed2bca64ab43150228e4f6cc80
Headers show

Comments

Ross Burton - March 11, 2013, 6:24 p.m.
This package has postinsts that run on the build host, but wasn't depending on
systemd-systemctl-native.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/recipes-core/systemd/systemd-compat-units.bb |    2 ++
 1 file changed, 2 insertions(+)
Martin Jansa - March 12, 2013, 7:08 a.m.
On Mon, Mar 11, 2013 at 11:24:49AM -0700, Ross Burton wrote:
> This package has postinsts that run on the build host, but wasn't depending on
> systemd-systemctl-native.
> 
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  meta/recipes-core/systemd/systemd-compat-units.bb |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta/recipes-core/systemd/systemd-compat-units.bb b/meta/recipes-core/systemd/systemd-compat-units.bb
> index a7bfee3..19a1ea1 100644
> --- a/meta/recipes-core/systemd/systemd-compat-units.bb
> +++ b/meta/recipes-core/systemd/systemd-compat-units.bb
> @@ -5,6 +5,8 @@ LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3
>  
>  PR = "r18"
>  
> +DEPENDS = "systemd-systemctl-native"

Do you want RDEPENDS_${PN} here?

> +
>  inherit allarch
>  
>  SRC_URI = "file://*.service"
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Koen Kooi - March 12, 2013, 7:37 a.m.
Op 12 mrt. 2013, om 08:08 heeft Martin Jansa <martin.jansa@gmail.com> het volgende geschreven:

> On Mon, Mar 11, 2013 at 11:24:49AM -0700, Ross Burton wrote:
>> This package has postinsts that run on the build host, but wasn't depending on
>> systemd-systemctl-native.
>> 
>> Signed-off-by: Ross Burton <ross.burton@intel.com>
>> ---
>> meta/recipes-core/systemd/systemd-compat-units.bb |    2 ++
>> 1 file changed, 2 insertions(+)
>> 
>> diff --git a/meta/recipes-core/systemd/systemd-compat-units.bb b/meta/recipes-core/systemd/systemd-compat-units.bb
>> index a7bfee3..19a1ea1 100644
>> --- a/meta/recipes-core/systemd/systemd-compat-units.bb
>> +++ b/meta/recipes-core/systemd/systemd-compat-units.bb
>> @@ -5,6 +5,8 @@ LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3
>> 
>> PR = "r18"
>> 
>> +DEPENDS = "systemd-systemctl-native"
> 
> Do you want RDEPENDS_${PN} here?

I don't think a -native package will do something usefull on the target :)
Martin Jansa - March 12, 2013, 8:50 a.m.
On Tue, Mar 12, 2013 at 08:37:40AM +0100, Koen Kooi wrote:
> 
> Op 12 mrt. 2013, om 08:08 heeft Martin Jansa <martin.jansa@gmail.com> het volgende geschreven:
> 
> > On Mon, Mar 11, 2013 at 11:24:49AM -0700, Ross Burton wrote:
> >> This package has postinsts that run on the build host, but wasn't depending on
> >> systemd-systemctl-native.
> >> 
> >> Signed-off-by: Ross Burton <ross.burton@intel.com>
> >> ---
> >> meta/recipes-core/systemd/systemd-compat-units.bb |    2 ++
> >> 1 file changed, 2 insertions(+)
> >> 
> >> diff --git a/meta/recipes-core/systemd/systemd-compat-units.bb b/meta/recipes-core/systemd/systemd-compat-units.bb
> >> index a7bfee3..19a1ea1 100644
> >> --- a/meta/recipes-core/systemd/systemd-compat-units.bb
> >> +++ b/meta/recipes-core/systemd/systemd-compat-units.bb
> >> @@ -5,6 +5,8 @@ LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3
> >> 
> >> PR = "r18"
> >> 
> >> +DEPENDS = "systemd-systemctl-native"
> > 
> > Do you want RDEPENDS_${PN} here?
> 
> I don't think a -native package will do something usefull on the target :)

Ah right, commit message said it's needed for postinsts and "send"
button haven't failed with -ENOCOFFEE.

Patch

diff --git a/meta/recipes-core/systemd/systemd-compat-units.bb b/meta/recipes-core/systemd/systemd-compat-units.bb
index a7bfee3..19a1ea1 100644
--- a/meta/recipes-core/systemd/systemd-compat-units.bb
+++ b/meta/recipes-core/systemd/systemd-compat-units.bb
@@ -5,6 +5,8 @@  LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3
 
 PR = "r18"
 
+DEPENDS = "systemd-systemctl-native"
+
 inherit allarch
 
 SRC_URI = "file://*.service"