Patchwork [3/3] systemd: Package hwdb data

login
register
mail settings
Submitter Khem Raj
Date March 9, 2013, 11:54 p.m.
Message ID <8f815c617b69812e749a5a197a3903fe8daaf645.1362873102.git.raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/45835/
State New
Headers show

Comments

Khem Raj - March 9, 2013, 11:54 p.m.
Create a new package to hold the hwdb.d
Fixes the packaging warning as well.

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-core/systemd/systemd_198.bb |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Koen Kooi - March 11, 2013, 2 p.m.
Op 10 mrt. 2013, om 00:54 heeft Khem Raj <raj.khem@gmail.com> het volgende geschreven:

> Create a new package to hold the hwdb.d
> Fixes the packaging warning as well.
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta/recipes-core/systemd/systemd_198.bb |    4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-core/systemd/systemd_198.bb b/meta/recipes-core/systemd/systemd_198.bb
> index 381a67b..9fc4704 100644
> --- a/meta/recipes-core/systemd/systemd_198.bb
> +++ b/meta/recipes-core/systemd/systemd_198.bb
> @@ -105,7 +105,7 @@ python populate_packages_prepend (){
> }
> PACKAGES_DYNAMIC += "^lib(udev|gudev|systemd).*"
> 
> -PACKAGES =+ "${PN}-gui ${PN}-vconsole-setup ${PN}-initramfs ${PN}-analyze"
> +PACKAGES =+ "${PN}-gui ${PN}-vconsole-setup ${PN}-initramfs ${PN}-analyze ${PN}-hwdb"
> 
> USERADD_PACKAGES = "${PN}"
> GROUPADD_PARAM_${PN} = "-r lock"
> @@ -168,6 +168,8 @@ FILES_${PN} = " ${base_bindir}/* \
>                 /lib/udev/rules.d/99-systemd.rules \
>                "
> 
> +FILES_${PN}-hwdb = "/lib/udev/hwdb.d"
> +

It's a udev hwdb, so calling it systemd-hwdb would be very misleading. And aren't you missing a RRECOMMENDS?
Ross Burton - March 11, 2013, 6:15 p.m.
On 11 March 2013 07:00, Koen Kooi <koen@dominion.thruhere.net> wrote:
> It's a udev hwdb, so calling it systemd-hwdb would be very misleading. And aren't you missing a RRECOMMENDS?

postinsts to run udevadm --update would be useful too (I've got these
changes in my branch too, but this network is trying to stop me do any
git pushes).

Ross
Khem Raj - March 11, 2013, 10:57 p.m.
On Mar 11, 2013, at 11:15 AM, "Burton, Ross" <ross.burton@intel.com> wrote:

> On 11 March 2013 07:00, Koen Kooi <koen@dominion.thruhere.net> wrote:
>> It's a udev hwdb, so calling it systemd-hwdb would be very misleading. And aren't you missing a RRECOMMENDS?
> 
> postinsts to run udevadm --update would be useful too (I've got these
> changes in my branch too, but this network is trying to stop me do any
> git pushes).

If you have this taken care of then I am willing to drop this patch.

> 
> Ross
Khem Raj - March 11, 2013, 11:03 p.m.
On Mar 11, 2013, at 7:00 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:

> 
> Op 10 mrt. 2013, om 00:54 heeft Khem Raj <raj.khem@gmail.com> het volgende geschreven:
> 
>> Create a new package to hold the hwdb.d
>> Fixes the packaging warning as well.
>> 
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>> meta/recipes-core/systemd/systemd_198.bb |    4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>> 
>> diff --git a/meta/recipes-core/systemd/systemd_198.bb b/meta/recipes-core/systemd/systemd_198.bb
>> index 381a67b..9fc4704 100644
>> --- a/meta/recipes-core/systemd/systemd_198.bb
>> +++ b/meta/recipes-core/systemd/systemd_198.bb
>> @@ -105,7 +105,7 @@ python populate_packages_prepend (){
>> }
>> PACKAGES_DYNAMIC += "^lib(udev|gudev|systemd).*"
>> 
>> -PACKAGES =+ "${PN}-gui ${PN}-vconsole-setup ${PN}-initramfs ${PN}-analyze"
>> +PACKAGES =+ "${PN}-gui ${PN}-vconsole-setup ${PN}-initramfs ${PN}-analyze ${PN}-hwdb"
>> 
>> USERADD_PACKAGES = "${PN}"
>> GROUPADD_PARAM_${PN} = "-r lock"
>> @@ -168,6 +168,8 @@ FILES_${PN} = " ${base_bindir}/* \
>>                /lib/udev/rules.d/99-systemd.rules \
>>               "
>> 
>> +FILES_${PN}-hwdb = "/lib/udev/hwdb.d"
>> +
> 
> It's a udev hwdb, so calling it systemd-hwdb would be very misleading.

OK I had it called udev-hwdb until I thought otherwise and changed it

> And aren't you missing a RRECOMMENDS?

I think Ross already has this taken care of so this patch might be moot.
Ross Burton - March 11, 2013, 11:22 p.m.
On 11 March 2013 16:03, Khem Raj <raj.khem@gmail.com> wrote:
>> And aren't you missing a RRECOMMENDS?
>
> I think Ross already has this taken care of so this patch might be moot.

I have a slightly more worked out version but it's untested, so feel
free to continue your series as I won't be able to test it this week.

Ross

Patch

diff --git a/meta/recipes-core/systemd/systemd_198.bb b/meta/recipes-core/systemd/systemd_198.bb
index 381a67b..9fc4704 100644
--- a/meta/recipes-core/systemd/systemd_198.bb
+++ b/meta/recipes-core/systemd/systemd_198.bb
@@ -105,7 +105,7 @@  python populate_packages_prepend (){
 }
 PACKAGES_DYNAMIC += "^lib(udev|gudev|systemd).*"
 
-PACKAGES =+ "${PN}-gui ${PN}-vconsole-setup ${PN}-initramfs ${PN}-analyze"
+PACKAGES =+ "${PN}-gui ${PN}-vconsole-setup ${PN}-initramfs ${PN}-analyze ${PN}-hwdb"
 
 USERADD_PACKAGES = "${PN}"
 GROUPADD_PARAM_${PN} = "-r lock"
@@ -168,6 +168,8 @@  FILES_${PN} = " ${base_bindir}/* \
                 /lib/udev/rules.d/99-systemd.rules \
                "
 
+FILES_${PN}-hwdb = "/lib/udev/hwdb.d"
+
 FILES_${PN}-dbg += "${systemd_unitdir}/.debug ${systemd_unitdir}/*/.debug ${base_libdir}/security/.debug/"
 FILES_${PN}-dev += "${base_libdir}/security/*.la ${datadir}/dbus-1/interfaces/ ${sysconfdir}/rpm/macros.systemd"