Patchwork base.bbclass: don't backfill features that already exist

login
register
mail settings
Submitter Ross Burton
Date March 9, 2013, 10:33 a.m.
Message ID <1362825205-6649-1-git-send-email-ross.burton@intel.com>
Download mbox | patch
Permalink /patch/45783/
State Accepted
Commit 0aad8decf0eb17b90153225493f28835d24f043a
Headers show

Comments

Ross Burton - March 9, 2013, 10:33 a.m.
It's too easy to cause rebuilds because the DISTRO_FEATURES have changed in
meaningless ways (such as re-ordering or duplicate items).  Help stop this by
checking if the feature to be back-filled is already present.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/classes/base.bbclass |    4 ++--
 meta/lib/oe/utils.py      |    8 +++-----
 2 files changed, 5 insertions(+), 7 deletions(-)

Patch

diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index 4d69caf..4ec1eda 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -292,8 +292,8 @@  python base_eventhandler() {
         e.data.setVar('BB_VERSION', bb.__version__)
         pkgarch_mapping(e.data)
         preferred_ml_updates(e.data)
-        e.data.appendVar('DISTRO_FEATURES', oe.utils.features_backfill("DISTRO_FEATURES", e.data))
-        e.data.appendVar('MACHINE_FEATURES', oe.utils.features_backfill("MACHINE_FEATURES", e.data))
+        oe.utils.features_backfill("DISTRO_FEATURES", e.data)
+        oe.utils.features_backfill("MACHINE_FEATURES", e.data)
 
     if isinstance(e, bb.event.BuildStarted):
         statuslines = []
diff --git a/meta/lib/oe/utils.py b/meta/lib/oe/utils.py
index 8d3efe4..b269f32 100644
--- a/meta/lib/oe/utils.py
+++ b/meta/lib/oe/utils.py
@@ -96,16 +96,14 @@  def features_backfill(var,d):
     # disturbing distributions that have already set DISTRO_FEATURES.
     # Distributions wanting to elide a value in DISTRO_FEATURES_BACKFILL should
     # add the feature to DISTRO_FEATURES_BACKFILL_CONSIDERED
-
+    features = (d.getVar(var, True) or "").split()
     backfill = (d.getVar(var+"_BACKFILL", True) or "").split()
     considered = (d.getVar(var+"_BACKFILL_CONSIDERED", True) or "").split()
 
     addfeatures = []
     for feature in backfill:
-        if feature not in considered:
+        if feature not in features and feature not in considered:
             addfeatures.append(feature)
 
     if addfeatures:
-        return " %s" % (" ".join(addfeatures))
-    else:
-        return ""
+        d.appendVar(var, " " + " ".join(addfeatures))