Patchwork [meta-fsl-ppc,v2,3/6] udev-extraconf: add rules from udev

login
register
mail settings
Submitter Ting Liu
Date March 8, 2013, 9:42 a.m.
Message ID <1362735743-11318-3-git-send-email-b28495@freescale.com>
Download mbox | patch
Permalink /patch/45709/
State Superseded
Delegated to: Otavio Salvador
Headers show

Comments

Ting Liu - March 8, 2013, 9:42 a.m.
From: Ting Liu <b28495@freescale.com>

Points from Otavio Salvador [otavio@ossystems.com.br]:
| These rules should go to udev-extraconf due following reasons:
| * adding it to udev makes it MACHINE_ARCH specific (hurts build time)
| * udev-extraconf does fit well for this case
| * udev-extraconf is much smaller to build (so fast build time)

Signed-off-by: Ting Liu <b28495@freescale.com>
---
 recipes-append/udev/udev_182.bbappend              |    3 +--
 .../udev/files/local.rules                         |    0
 recipes-core/udev/udev-extraconf_1.0.bbappend      |    3 +++
 3 files changed, 4 insertions(+), 2 deletions(-)
 rename {recipes-append => recipes-core}/udev/files/local.rules (100%)
 create mode 100644 recipes-core/udev/udev-extraconf_1.0.bbappend
Otavio Salvador - March 8, 2013, 1:32 p.m.
Hello,

On Fri, Mar 8, 2013 at 6:42 AM,  <b28495@freescale.com> wrote:
> From: Ting Liu <b28495@freescale.com>
>
> Points from Otavio Salvador [otavio@ossystems.com.br]:
> | These rules should go to udev-extraconf due following reasons:
> | * adding it to udev makes it MACHINE_ARCH specific (hurts build time)
> | * udev-extraconf does fit well for this case
> | * udev-extraconf is much smaller to build (so fast build time)
>
> Signed-off-by: Ting Liu <b28495@freescale.com>

Please change the commit log; the commit log ought to explain the
change and why it has been done. I understand you reused my comments
for it but it does not fit there. The file ought to be put inside
udev-extraconf directory so you can drop the override to find the
file.

Patch

diff --git a/recipes-append/udev/udev_182.bbappend b/recipes-append/udev/udev_182.bbappend
index f15533b..8445337 100644
--- a/recipes-append/udev/udev_182.bbappend
+++ b/recipes-append/udev/udev_182.bbappend
@@ -1,3 +1,2 @@ 
-FILESEXTRAPATHS_prepend_fsl := "${THISDIR}/files:"
+PRINC := "${@int(PRINC) + 1}"
 
-PR_fsl .= "+${DISTRO}.1"
diff --git a/recipes-append/udev/files/local.rules b/recipes-core/udev/files/local.rules
similarity index 100%
rename from recipes-append/udev/files/local.rules
rename to recipes-core/udev/files/local.rules
diff --git a/recipes-core/udev/udev-extraconf_1.0.bbappend b/recipes-core/udev/udev-extraconf_1.0.bbappend
new file mode 100644
index 0000000..b3641a4
--- /dev/null
+++ b/recipes-core/udev/udev-extraconf_1.0.bbappend
@@ -0,0 +1,3 @@ 
+FILESEXTRAPATHS_prepend := "${THISDIR}/files:"
+
+PRINC := "${@int(PRINC) + 1}"