| Submitter | Ting Liu |
|---|---|
| Date | March 7, 2013, 9:12 a.m. |
| Message ID | <1362647544-3649-1-git-send-email-b28495@freescale.com> |
| Download | mbox | patch |
| Permalink | /patch/45645/ |
| State | Changes Requested |
| Delegated to: | Otavio Salvador |
| Headers | show |
Comments
On Thu, Mar 7, 2013 at 6:12 AM, <b28495@freescale.com> wrote: > From: Ting Liu <b28495@freescale.com> > > Signed-off-by: Ting Liu <b28495@freescale.com> > --- > recipes-append/netbase/netbase_5.0.bbappend | 10 ---------- > .../files/71-fsl-dpaa-persistent-networking.rules | 0 > recipes-append/udev/udev_182.bbappend | 12 ++++++++++-- > 3 files changed, 10 insertions(+), 12 deletions(-) > delete mode 100644 recipes-append/netbase/netbase_5.0.bbappend > rename recipes-append/{netbase => udev}/files/71-fsl-dpaa-persistent-networking.rules (100%) > > diff --git a/recipes-append/netbase/netbase_5.0.bbappend b/recipes-append/netbase/netbase_5.0.bbappend > deleted file mode 100644 > index dc0fd0a..0000000 > --- a/recipes-append/netbase/netbase_5.0.bbappend > +++ /dev/null > @@ -1,10 +0,0 @@ > -FILESEXTRAPATHS_prepend_fsl := "${THISDIR}/files:" > - > -SRC_URI_append_fsl += "file://71-fsl-dpaa-persistent-networking.rules" > - > -do_install_append_fsl () { > - install -d ${D}${sysconfdir}/udev/rules.d/ > - install -m 0644 ${WORKDIR}/71-fsl-dpaa-persistent-networking.rules ${D}${sysconfdir}/udev/rules.d > -} > - > -PR_fsl .= "+${DISTRO}" I agree with the change but to preserve the upgrade path please keep a bbappend bumping the PRINC. > diff --git a/recipes-append/netbase/files/71-fsl-dpaa-persistent-networking.rules b/recipes-append/udev/files/71-fsl-dpaa-persistent-networking.rules > similarity index 100% > rename from recipes-append/netbase/files/71-fsl-dpaa-persistent-networking.rules > rename to recipes-append/udev/files/71-fsl-dpaa-persistent-networking.rules > diff --git a/recipes-append/udev/udev_182.bbappend b/recipes-append/udev/udev_182.bbappend > index f15533b..691ecf4 100644 > --- a/recipes-append/udev/udev_182.bbappend > +++ b/recipes-append/udev/udev_182.bbappend > @@ -1,3 +1,11 @@ > -FILESEXTRAPATHS_prepend_fsl := "${THISDIR}/files:" > +FILESEXTRAPATHS_prepend := "${THISDIR}/files:" > + > +SRC_URI_append += "file://71-fsl-dpaa-persistent-networking.rules" > + > +do_install_append () { > + install -d ${D}${sysconfdir}/udev/rules.d/ > + install -m 0644 ${WORKDIR}/71-fsl-dpaa-persistent-networking.rules ${D}${sysconfdir}/udev/rules.d > +} > + > +PRINC := "${@int(PRINC) + 1}" > > -PR_fsl .= "+${DISTRO}.1" These rules should go to udev-extraconf due following reasons: * adding it to udev makes it MACHINE_ARCH specific (hurts build time) * udev-extraconf does fit well for this case * udev-extraconf is much smaller to build (so fast build time) Recall to add udev-extraconf in MACHINE_EXTRA_RRECOMMENDS so it ends in the default packagegroup packages and are easy to manage.
> -----Original Message----- > From: otavio.salvador@gmail.com [mailto:otavio.salvador@gmail.com] On > Behalf Of Otavio Salvador > Sent: Thursday, March 07, 2013 10:47 PM > To: Liu Ting-B28495 > Cc: meta-freescale@yoctoproject.org > Subject: Re: [meta-freescale] [PATCH 1/2] move udev ruls from netbase to > udev > > On Thu, Mar 7, 2013 at 6:12 AM, <b28495@freescale.com> wrote: > > From: Ting Liu <b28495@freescale.com> > > > > Signed-off-by: Ting Liu <b28495@freescale.com> > > --- > > recipes-append/netbase/netbase_5.0.bbappend | 10 ---------- > > .../files/71-fsl-dpaa-persistent-networking.rules | 0 > > recipes-append/udev/udev_182.bbappend | 12 ++++++++++-- > > 3 files changed, 10 insertions(+), 12 deletions(-) delete mode > > 100644 recipes-append/netbase/netbase_5.0.bbappend > > rename recipes-append/{netbase => > > udev}/files/71-fsl-dpaa-persistent-networking.rules (100%) > > > > diff --git a/recipes-append/netbase/netbase_5.0.bbappend > > b/recipes-append/netbase/netbase_5.0.bbappend > > deleted file mode 100644 > > index dc0fd0a..0000000 > > --- a/recipes-append/netbase/netbase_5.0.bbappend > > +++ /dev/null > > @@ -1,10 +0,0 @@ > > -FILESEXTRAPATHS_prepend_fsl := "${THISDIR}/files:" > > - > > -SRC_URI_append_fsl += "file://71-fsl-dpaa-persistent-networking.rules" > > - > > -do_install_append_fsl () { > > - install -d ${D}${sysconfdir}/udev/rules.d/ > > - install -m 0644 ${WORKDIR}/71-fsl-dpaa-persistent- > networking.rules ${D}${sysconfdir}/udev/rules.d > > -} > > - > > -PR_fsl .= "+${DISTRO}" > > I agree with the change but to preserve the upgrade path please keep a > bbappend bumping the PRINC. Got it. Thanks. -Ting > > > diff --git > > a/recipes-append/netbase/files/71-fsl-dpaa-persistent-networking.rules > > b/recipes-append/udev/files/71-fsl-dpaa-persistent-networking.rules > > similarity index 100% > > rename from > > recipes-append/netbase/files/71-fsl-dpaa-persistent-networking.rules > > rename to > > recipes-append/udev/files/71-fsl-dpaa-persistent-networking.rules > > diff --git a/recipes-append/udev/udev_182.bbappend > > b/recipes-append/udev/udev_182.bbappend > > index f15533b..691ecf4 100644 > > --- a/recipes-append/udev/udev_182.bbappend > > +++ b/recipes-append/udev/udev_182.bbappend > > @@ -1,3 +1,11 @@ > > -FILESEXTRAPATHS_prepend_fsl := "${THISDIR}/files:" > > +FILESEXTRAPATHS_prepend := "${THISDIR}/files:" > > + > > +SRC_URI_append += "file://71-fsl-dpaa-persistent-networking.rules" > > + > > +do_install_append () { > > + install -d ${D}${sysconfdir}/udev/rules.d/ > > + install -m 0644 > > +${WORKDIR}/71-fsl-dpaa-persistent-networking.rules > > +${D}${sysconfdir}/udev/rules.d } > > + > > +PRINC := "${@int(PRINC) + 1}" > > > > -PR_fsl .= "+${DISTRO}.1" > > These rules should go to udev-extraconf due following reasons: > > * adding it to udev makes it MACHINE_ARCH specific (hurts build time) > * udev-extraconf does fit well for this case > * udev-extraconf is much smaller to build (so fast build time) > > Recall to add udev-extraconf in MACHINE_EXTRA_RRECOMMENDS so it ends in > the default packagegroup packages and are easy to manage. > Thanks a lot for the sharing. It does make sense. I will send v2 patch after build tests. -Ting > -- > Otavio Salvador O.S. Systems > E-mail: otavio@ossystems.com.br http://www.ossystems.com.br > Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
Patch
diff --git a/recipes-append/netbase/netbase_5.0.bbappend b/recipes-append/netbase/netbase_5.0.bbappend deleted file mode 100644 index dc0fd0a..0000000 --- a/recipes-append/netbase/netbase_5.0.bbappend +++ /dev/null @@ -1,10 +0,0 @@ -FILESEXTRAPATHS_prepend_fsl := "${THISDIR}/files:" - -SRC_URI_append_fsl += "file://71-fsl-dpaa-persistent-networking.rules" - -do_install_append_fsl () { - install -d ${D}${sysconfdir}/udev/rules.d/ - install -m 0644 ${WORKDIR}/71-fsl-dpaa-persistent-networking.rules ${D}${sysconfdir}/udev/rules.d -} - -PR_fsl .= "+${DISTRO}" diff --git a/recipes-append/netbase/files/71-fsl-dpaa-persistent-networking.rules b/recipes-append/udev/files/71-fsl-dpaa-persistent-networking.rules similarity index 100% rename from recipes-append/netbase/files/71-fsl-dpaa-persistent-networking.rules rename to recipes-append/udev/files/71-fsl-dpaa-persistent-networking.rules diff --git a/recipes-append/udev/udev_182.bbappend b/recipes-append/udev/udev_182.bbappend index f15533b..691ecf4 100644 --- a/recipes-append/udev/udev_182.bbappend +++ b/recipes-append/udev/udev_182.bbappend @@ -1,3 +1,11 @@ -FILESEXTRAPATHS_prepend_fsl := "${THISDIR}/files:" +FILESEXTRAPATHS_prepend := "${THISDIR}/files:" + +SRC_URI_append += "file://71-fsl-dpaa-persistent-networking.rules" + +do_install_append () { + install -d ${D}${sysconfdir}/udev/rules.d/ + install -m 0644 ${WORKDIR}/71-fsl-dpaa-persistent-networking.rules ${D}${sysconfdir}/udev/rules.d +} + +PRINC := "${@int(PRINC) + 1}" -PR_fsl .= "+${DISTRO}.1"