Patchwork lio-utils: add tcm_start.sh and lio_start.sh to rootfs

login
register
mail settings
Submitter Ting Liu
Date March 7, 2013, 8:48 a.m.
Message ID <1362646109-2777-1-git-send-email-b28495@freescale.com>
Download mbox | patch
Permalink /patch/45643/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

Ting Liu - March 7, 2013, 8:48 a.m.
From: Chunrong Guo <b40290@freescale.com>

           *following scripts had  been added
            /etc/init.d/target
            /etc/target/tcm_start.sh
            /etc/target/lio_start.sh

Signed-off-by: Chunrong Guo <b40290@freescale.com>
---
 recipes-tools/lio-utils/lio-utils_4.0.bb |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)
Otavio Salvador - March 7, 2013, 2:42 p.m.
On Thu, Mar 7, 2013 at 5:48 AM,  <b28495@freescale.com> wrote:
> From: Chunrong Guo <b40290@freescale.com>
>
>            *following scripts had  been added
>             /etc/init.d/target
>             /etc/target/tcm_start.sh
>             /etc/target/lio_start.sh
>
> Signed-off-by: Chunrong Guo <b40290@freescale.com>

If I recall correctly you said you'd send this package for inclusion
to meta-oe so why to keep changing it here? It might be good to
prepare the patch for meta-oe and get rid of it as soon as possible.
Ting Liu - March 8, 2013, 3:35 a.m.
> -----Original Message-----
> From: otavio.salvador@gmail.com [mailto:otavio.salvador@gmail.com] On
> Behalf Of Otavio Salvador
> Sent: Thursday, March 07, 2013 10:43 PM
> To: Liu Ting-B28495
> Cc: meta-freescale@yoctoproject.org
> Subject: Re: [meta-freescale] [PATCH] lio-utils: add tcm_start.sh and
> lio_start.sh to rootfs
> 
> On Thu, Mar 7, 2013 at 5:48 AM,  <b28495@freescale.com> wrote:
> > From: Chunrong Guo <b40290@freescale.com>
> >
> >            *following scripts had  been added
> >             /etc/init.d/target
> >             /etc/target/tcm_start.sh
> >             /etc/target/lio_start.sh
> >
> > Signed-off-by: Chunrong Guo <b40290@freescale.com>
> 
> If I recall correctly you said you'd send this package for inclusion to
> meta-oe so why to keep changing it here? It might be good to prepare the
> patch for meta-oe and get rid of it as soon as possible.

Well, I just want to add this commit and then move the whole recipe to meta-oe. In
this way, the one removed in meta-fsl-ppc and the one added in meta-oe are identical.

Furthermore, I'm not sure that this package will be accepted by meta-oe shortly. 
So, let's sync the ones exist on internel/external git tree first. Does it make sense?

-Ting

> 
> --
> Otavio Salvador                             O.S. Systems
> E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
> Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Otavio Salvador - March 8, 2013, 12:08 p.m.
On Fri, Mar 8, 2013 at 12:35 AM, Liu Ting-B28495 <B28495@freescale.com> wrote:
>> -----Original Message-----
>> From: otavio.salvador@gmail.com [mailto:otavio.salvador@gmail.com] On
>> Behalf Of Otavio Salvador
>> Sent: Thursday, March 07, 2013 10:43 PM
>> To: Liu Ting-B28495
>> Cc: meta-freescale@yoctoproject.org
>> Subject: Re: [meta-freescale] [PATCH] lio-utils: add tcm_start.sh and
>> lio_start.sh to rootfs
>>
>> On Thu, Mar 7, 2013 at 5:48 AM,  <b28495@freescale.com> wrote:
>> > From: Chunrong Guo <b40290@freescale.com>
>> >
>> >            *following scripts had  been added
>> >             /etc/init.d/target
>> >             /etc/target/tcm_start.sh
>> >             /etc/target/lio_start.sh
>> >
>> > Signed-off-by: Chunrong Guo <b40290@freescale.com>
>>
>> If I recall correctly you said you'd send this package for inclusion to
>> meta-oe so why to keep changing it here? It might be good to prepare the
>> patch for meta-oe and get rid of it as soon as possible.
>
> Well, I just want to add this commit and then move the whole recipe to meta-oe. In
> this way, the one removed in meta-fsl-ppc and the one added in meta-oe are identical.
>
> Furthermore, I'm not sure that this package will be accepted by meta-oe shortly.
> So, let's sync the ones exist on internel/external git tree first. Does it make sense?

Fine with me, please send it with the v2 so all the series can be
applied by Matt together.

Patch

diff --git a/recipes-tools/lio-utils/lio-utils_4.0.bb b/recipes-tools/lio-utils/lio-utils_4.0.bb
index 31aa4fa..98101b3 100644
--- a/recipes-tools/lio-utils/lio-utils_4.0.bb
+++ b/recipes-tools/lio-utils/lio-utils_4.0.bb
@@ -4,7 +4,7 @@  HOMEPAGE = "http://linux-iscsi.org/index.php/Lio-utils"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://debian/copyright;md5=c3ea231a32635cbb5debedf3e88aa3df"
 
-PR = "r1"
+PR = "r2"
 
 SRC_URI = "git://risingtidesystems.com/lio-utils.git;protocal=git \
     file://lio-utils-install-more-modules.patch "
@@ -46,13 +46,16 @@  do_install() {
     if test -d ${S}/tools; then
         oe_runmake install
     fi
-
+ 
+    install -d ${D}/etc/target/
     install -d ${D}/etc/init.d/
     install -m 755 ${S}/scripts/rc.target ${D}/etc/init.d/
+    install -m 755 ${S}/conf/tcm_start.default ${D}/etc/target/tcm_start.sh
+    install -m 755 ${S}/conf/lio_start.default ${D}/etc/target/lio_start.sh
 }
 
 RDEPENDS_${PN} += "python-stringold python-subprocess python-shell \ 
     python-datetime python-textutils python-crypt python-netclient python-email"
 
 
-FILES_${PN} += "${sbindir}/* /etc/init.d/*"
+FILES_${PN} += "${sbindir}/* /etc/init.d/* /etc/target/*"