Patchwork [V2] pulseaudio: Specify gdbm in configure

login
register
mail settings
Submitter Rich Dubielzig
Date March 1, 2013, 10:39 p.m.
Message ID <1362177552-10996-1-git-send-email-rich.dubielzig@windriver.com>
Download mbox | patch
Permalink /patch/45395/
State New
Headers show

Comments

Rich Dubielzig - March 1, 2013, 10:39 p.m.
The OE code as-is makes pulseaudio depend on gdbm, but the actual configure
process may automatically select the tdb library if a samba build has already
started.  This is problematic because it's nondeterministic and the samba
build may not be in a completed state causing compile to fail.

Signed-off-by: Rich Dubielzig <rich.dubielzig@windriver.com>
---
 meta/recipes-multimedia/pulseaudio/pulseaudio.inc  |    1 +
 .../pulseaudio/pulseaudio_2.1.bb                   |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)
Martin Jansa - March 1, 2013, 10:45 p.m.
On Fri, Mar 01, 2013 at 02:39:12PM -0800, Rich Dubielzig wrote:
> The OE code as-is makes pulseaudio depend on gdbm, but the actual configure
> process may automatically select the tdb library if a samba build has already
> started.  This is problematic because it's nondeterministic and the samba
> build may not be in a completed state causing compile to fail.
> 
> Signed-off-by: Rich Dubielzig <rich.dubielzig@windriver.com>
> ---
>  meta/recipes-multimedia/pulseaudio/pulseaudio.inc  |    1 +
>  .../pulseaudio/pulseaudio_2.1.bb                   |    2 +-
>  2 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> index 11c6355..fdf4a8a 100644
> --- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> @@ -37,6 +37,7 @@ EXTRA_OECONF = "\
>                  --disable-orc \
>                  --with-access-group=audio \
>  		--without-fftw \
> +		--with-database=gdbm \

Please don't mix tabs and spaces for indentation.

>  "
>  
>  PARALLEL_MAKE = ""
> diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb b/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
> index e39b69e..2f3728f 100644
> --- a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
> +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb

Isn't 3.0 already in oe-core? rebase on latest master.

> @@ -1,6 +1,6 @@
>  require pulseaudio.inc
>  
> -PR = "r3"
> +PR = "r4"
>  
>  DEPENDS += "libjson gdbm speex libxml-parser-perl-native"
>  
> -- 
> 1.7.1
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
index 11c6355..fdf4a8a 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
@@ -37,6 +37,7 @@  EXTRA_OECONF = "\
                 --disable-orc \
                 --with-access-group=audio \
 		--without-fftw \
+		--with-database=gdbm \
 "
 
 PARALLEL_MAKE = ""
diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb b/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
index e39b69e..2f3728f 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_2.1.bb
@@ -1,6 +1,6 @@ 
 require pulseaudio.inc
 
-PR = "r3"
+PR = "r4"
 
 DEPENDS += "libjson gdbm speex libxml-parser-perl-native"