Patchwork [meta-fsl-ppc,master,1/4] Revert "Remove recipes-append folder which are SDK specific"

login
register
mail settings
Submitter Zhenhua Luo
Date Feb. 28, 2013, 8:54 a.m.
Message ID <1362041655-19145-1-git-send-email-zhenhua.luo@freescale.com>
Download mbox | patch
Permalink /patch/45267/
State Superseded
Delegated to: Matthew McClintock
Headers show

Comments

Zhenhua Luo - Feb. 28, 2013, 8:54 a.m.
The subject and actual change don't match. actual change is to remove images folder

This reverts commit ee364575803812dbbb2b103d468c66c54efcc7af.
---
 images/fsl-image-lsb-sdk.bb  |   18 ++++++++++++++++++
 images/fsl-image-minimal.bb  |   16 ++++++++++++++++
 images/fsl-toolchain-bare.bb |    8 ++++++++
 images/fsl-toolchain.bb      |   19 +++++++++++++++++++
 4 files changed, 61 insertions(+)
 create mode 100644 images/fsl-image-lsb-sdk.bb
 create mode 100644 images/fsl-image-minimal.bb
 create mode 100644 images/fsl-toolchain-bare.bb
 create mode 100644 images/fsl-toolchain.bb
Otavio Salvador - Feb. 28, 2013, 12:20 p.m.
On Thu, Feb 28, 2013 at 5:54 AM, Zhenhua Luo <zhenhua.luo@freescale.com> wrote:
> The subject and actual change don't match. actual change is to remove images folder
>
> This reverts commit ee364575803812dbbb2b103d468c66c54efcc7af.

You missed the Signed-off-by line.
McClintock Matthew-B29882 - Feb. 28, 2013, 3:23 p.m.
On Thu, Feb 28, 2013 at 2:54 AM, Zhenhua Luo <zhenhua.luo@freescale.com> wrote:
> The subject and actual change don't match. actual change is to remove images folder
>
> This reverts commit ee364575803812dbbb2b103d468c66c54efcc7af.

The previous patch removed these? I'm confused.

-M

> ---
>  images/fsl-image-lsb-sdk.bb  |   18 ++++++++++++++++++
>  images/fsl-image-minimal.bb  |   16 ++++++++++++++++
>  images/fsl-toolchain-bare.bb |    8 ++++++++
>  images/fsl-toolchain.bb      |   19 +++++++++++++++++++
>  4 files changed, 61 insertions(+)
>  create mode 100644 images/fsl-image-lsb-sdk.bb
>  create mode 100644 images/fsl-image-minimal.bb
>  create mode 100644 images/fsl-toolchain-bare.bb
>  create mode 100644 images/fsl-toolchain.bb
>
> diff --git a/images/fsl-image-lsb-sdk.bb b/images/fsl-image-lsb-sdk.bb
> new file mode 100644
> index 0000000..1ba38d3
> --- /dev/null
> +++ b/images/fsl-image-lsb-sdk.bb
> @@ -0,0 +1,18 @@
> +IMAGE_FEATURES += "tools-sdk dev-pkgs ssh-server-openssh"
> +EXTRA_IMAGE_FEATURES = "tools-debug tools-profile tools-testapps debug-tweaks"
> +
> +IMAGE_INSTALL = "\
> +    ${CORE_IMAGE_BASE_INSTALL} \
> +    packagegroup-core-basic \
> +    packagegroup-core-lsb \
> +    git \
> +    dtc \
> +    flex \
> +    bison \
> +    ccache \
> +    u-boot \
> +    "
> +
> +inherit core-image
> +
> +IMAGE_FSTYPES = "tar.gz"
> diff --git a/images/fsl-image-minimal.bb b/images/fsl-image-minimal.bb
> new file mode 100644
> index 0000000..1732585
> --- /dev/null
> +++ b/images/fsl-image-minimal.bb
> @@ -0,0 +1,16 @@
> +#
> +# Copyright (C) 2007 OpenedHand Ltd.
> +#
> +IMAGE_INSTALL = "packagegroup-core-boot ${ROOTFS_PKGMANAGE_BOOTSTRAP} u-boot"
> +IMAGE_LINGUAS = " "
> +
> +LICENSE = "MIT"
> +
> +inherit core-image
> +
> +IMAGE_ROOTFS_SIZE = "8192"
> +
> +# remove not needed ipkg informations
> +ROOTFS_POSTPROCESS_COMMAND += "remove_packaging_data_files ; "
> +
> +IMAGE_FSTYPES = "tar.gz ext2.gz.u-boot jffs2"
> diff --git a/images/fsl-toolchain-bare.bb b/images/fsl-toolchain-bare.bb
> new file mode 100644
> index 0000000..74a3c4a
> --- /dev/null
> +++ b/images/fsl-toolchain-bare.bb
> @@ -0,0 +1,8 @@
> +PR = "r3"
> +
> +require recipes-core/meta/meta-toolchain.bb
> +
> +TOOLCHAIN_OUTPUTNAME = "${SDK_NAME}-toolchain-bare-${DISTRO_VERSION}"
> +TOOLCHAIN_TARGET_TASK = "packagegroup-core-standalone-sdk-target"
> +TOOLCHAIN_HOST_TASK = "packagegroup-cross-canadian-${TRANSLATED_TARGET_ARCH}"
> +TOOLCHAIN_NEED_CONFIGSITE_CACHE += "zlib"
> diff --git a/images/fsl-toolchain.bb b/images/fsl-toolchain.bb
> new file mode 100644
> index 0000000..696681c
> --- /dev/null
> +++ b/images/fsl-toolchain.bb
> @@ -0,0 +1,19 @@
> +PR = "r2"
> +
> +require fsl-toolchain-bare.bb
> +
> +TOOLCHAIN_OUTPUTNAME = "${SDK_NAME}-toolchain-${DISTRO_VERSION}"
> +TOOLCHAIN_TARGET_TASK += " \
> +       glib-2.0 \
> +       glib-2.0-dev \
> +       dtc \
> +       libgomp \
> +       libgomp-dev \
> +       libgomp-staticdev \
> +       libstdc++-staticdev \
> +       ${TCLIBC}-staticdev \
> +       "
> +
> +TOOLCHAIN_HOST_TASK += " \
> +       nativesdk-dtc \
> +       "
> --
> 1.7.9.5
>
>
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale
Zhenhua Luo - March 1, 2013, 3:37 a.m.
No previous patch removed images folder except current one, the reason of revert is that the patch title and actual change doesn't match. Title indicates remove recipes-append, but the actual modification is removing images. 


Best Regards,

Zhenhua


> -----Original Message-----
> From: McClintock Matthew-B29882
> Sent: Thursday, February 28, 2013 11:24 PM
> To: Luo Zhenhua-B19537
> Cc: meta-freescale@yoctoproject.org
> Subject: Re: [meta-freescale] [meta-fsl-ppc master 1/4] Revert "Remove
> recipes-append folder which are SDK specific"
> 
> On Thu, Feb 28, 2013 at 2:54 AM, Zhenhua Luo <zhenhua.luo@freescale.com>
> wrote:
> > The subject and actual change don't match. actual change is to remove
> > images folder
> >
> > This reverts commit ee364575803812dbbb2b103d468c66c54efcc7af.
> 
> The previous patch removed these? I'm confused.
> 
> -M
> 
> > ---
> >  images/fsl-image-lsb-sdk.bb  |   18 ++++++++++++++++++
> >  images/fsl-image-minimal.bb  |   16 ++++++++++++++++
> >  images/fsl-toolchain-bare.bb |    8 ++++++++
> >  images/fsl-toolchain.bb      |   19 +++++++++++++++++++
> >  4 files changed, 61 insertions(+)
> >  create mode 100644 images/fsl-image-lsb-sdk.bb  create mode 100644
> > images/fsl-image-minimal.bb  create mode 100644
> > images/fsl-toolchain-bare.bb  create mode 100644
> > images/fsl-toolchain.bb
> >
> > diff --git a/images/fsl-image-lsb-sdk.bb b/images/fsl-image-lsb-sdk.bb
> > new file mode 100644 index 0000000..1ba38d3
> > --- /dev/null
> > +++ b/images/fsl-image-lsb-sdk.bb
> > @@ -0,0 +1,18 @@
> > +IMAGE_FEATURES += "tools-sdk dev-pkgs ssh-server-openssh"
> > +EXTRA_IMAGE_FEATURES = "tools-debug tools-profile tools-testapps
> debug-tweaks"
> > +
> > +IMAGE_INSTALL = "\
> > +    ${CORE_IMAGE_BASE_INSTALL} \
> > +    packagegroup-core-basic \
> > +    packagegroup-core-lsb \
> > +    git \
> > +    dtc \
> > +    flex \
> > +    bison \
> > +    ccache \
> > +    u-boot \
> > +    "
> > +
> > +inherit core-image
> > +
> > +IMAGE_FSTYPES = "tar.gz"
> > diff --git a/images/fsl-image-minimal.bb b/images/fsl-image-minimal.bb
> > new file mode 100644 index 0000000..1732585
> > --- /dev/null
> > +++ b/images/fsl-image-minimal.bb
> > @@ -0,0 +1,16 @@
> > +#
> > +# Copyright (C) 2007 OpenedHand Ltd.
> > +#
> > +IMAGE_INSTALL = "packagegroup-core-boot ${ROOTFS_PKGMANAGE_BOOTSTRAP}
> u-boot"
> > +IMAGE_LINGUAS = " "
> > +
> > +LICENSE = "MIT"
> > +
> > +inherit core-image
> > +
> > +IMAGE_ROOTFS_SIZE = "8192"
> > +
> > +# remove not needed ipkg informations ROOTFS_POSTPROCESS_COMMAND +=
> > +"remove_packaging_data_files ; "
> > +
> > +IMAGE_FSTYPES = "tar.gz ext2.gz.u-boot jffs2"
> > diff --git a/images/fsl-toolchain-bare.bb
> > b/images/fsl-toolchain-bare.bb new file mode 100644 index
> > 0000000..74a3c4a
> > --- /dev/null
> > +++ b/images/fsl-toolchain-bare.bb
> > @@ -0,0 +1,8 @@
> > +PR = "r3"
> > +
> > +require recipes-core/meta/meta-toolchain.bb
> > +
> > +TOOLCHAIN_OUTPUTNAME = "${SDK_NAME}-toolchain-bare-${DISTRO_VERSION}"
> > +TOOLCHAIN_TARGET_TASK = "packagegroup-core-standalone-sdk-target"
> > +TOOLCHAIN_HOST_TASK = "packagegroup-cross-canadian-
> ${TRANSLATED_TARGET_ARCH}"
> > +TOOLCHAIN_NEED_CONFIGSITE_CACHE += "zlib"
> > diff --git a/images/fsl-toolchain.bb b/images/fsl-toolchain.bb new
> > file mode 100644 index 0000000..696681c
> > --- /dev/null
> > +++ b/images/fsl-toolchain.bb
> > @@ -0,0 +1,19 @@
> > +PR = "r2"
> > +
> > +require fsl-toolchain-bare.bb
> > +
> > +TOOLCHAIN_OUTPUTNAME = "${SDK_NAME}-toolchain-${DISTRO_VERSION}"
> > +TOOLCHAIN_TARGET_TASK += " \
> > +       glib-2.0 \
> > +       glib-2.0-dev \
> > +       dtc \
> > +       libgomp \
> > +       libgomp-dev \
> > +       libgomp-staticdev \
> > +       libstdc++-staticdev \
> > +       ${TCLIBC}-staticdev \
> > +       "
> > +
> > +TOOLCHAIN_HOST_TASK += " \
> > +       nativesdk-dtc \
> > +       "
> > --
> > 1.7.9.5
> >
> >
> > _______________________________________________
> > meta-freescale mailing list
> > meta-freescale@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-freescale
McClintock Matthew-B29882 - March 1, 2013, 3:53 a.m.
On Thu, Feb 28, 2013 at 9:37 PM, Luo Zhenhua-B19537
<B19537@freescale.com> wrote:
> No previous patch removed images folder except current one, the reason of revert is that the patch title and actual change doesn't match. Title indicates remove recipes-append, but the actual modification is removing images.

I'm still lost..

My thoughts are that images should not live in meta-fsl-ppc. They
should live in the distro layer.

-M

>
>
> Best Regards,
>
> Zhenhua
>
>
>> -----Original Message-----
>> From: McClintock Matthew-B29882
>> Sent: Thursday, February 28, 2013 11:24 PM
>> To: Luo Zhenhua-B19537
>> Cc: meta-freescale@yoctoproject.org
>> Subject: Re: [meta-freescale] [meta-fsl-ppc master 1/4] Revert "Remove
>> recipes-append folder which are SDK specific"
>>
>> On Thu, Feb 28, 2013 at 2:54 AM, Zhenhua Luo <zhenhua.luo@freescale.com>
>> wrote:
>> > The subject and actual change don't match. actual change is to remove
>> > images folder
>> >
>> > This reverts commit ee364575803812dbbb2b103d468c66c54efcc7af.
>>
>> The previous patch removed these? I'm confused.
>>
>> -M
>>
>> > ---
>> >  images/fsl-image-lsb-sdk.bb  |   18 ++++++++++++++++++
>> >  images/fsl-image-minimal.bb  |   16 ++++++++++++++++
>> >  images/fsl-toolchain-bare.bb |    8 ++++++++
>> >  images/fsl-toolchain.bb      |   19 +++++++++++++++++++
>> >  4 files changed, 61 insertions(+)
>> >  create mode 100644 images/fsl-image-lsb-sdk.bb  create mode 100644
>> > images/fsl-image-minimal.bb  create mode 100644
>> > images/fsl-toolchain-bare.bb  create mode 100644
>> > images/fsl-toolchain.bb
>> >
>> > diff --git a/images/fsl-image-lsb-sdk.bb b/images/fsl-image-lsb-sdk.bb
>> > new file mode 100644 index 0000000..1ba38d3
>> > --- /dev/null
>> > +++ b/images/fsl-image-lsb-sdk.bb
>> > @@ -0,0 +1,18 @@
>> > +IMAGE_FEATURES += "tools-sdk dev-pkgs ssh-server-openssh"
>> > +EXTRA_IMAGE_FEATURES = "tools-debug tools-profile tools-testapps
>> debug-tweaks"
>> > +
>> > +IMAGE_INSTALL = "\
>> > +    ${CORE_IMAGE_BASE_INSTALL} \
>> > +    packagegroup-core-basic \
>> > +    packagegroup-core-lsb \
>> > +    git \
>> > +    dtc \
>> > +    flex \
>> > +    bison \
>> > +    ccache \
>> > +    u-boot \
>> > +    "
>> > +
>> > +inherit core-image
>> > +
>> > +IMAGE_FSTYPES = "tar.gz"
>> > diff --git a/images/fsl-image-minimal.bb b/images/fsl-image-minimal.bb
>> > new file mode 100644 index 0000000..1732585
>> > --- /dev/null
>> > +++ b/images/fsl-image-minimal.bb
>> > @@ -0,0 +1,16 @@
>> > +#
>> > +# Copyright (C) 2007 OpenedHand Ltd.
>> > +#
>> > +IMAGE_INSTALL = "packagegroup-core-boot ${ROOTFS_PKGMANAGE_BOOTSTRAP}
>> u-boot"
>> > +IMAGE_LINGUAS = " "
>> > +
>> > +LICENSE = "MIT"
>> > +
>> > +inherit core-image
>> > +
>> > +IMAGE_ROOTFS_SIZE = "8192"
>> > +
>> > +# remove not needed ipkg informations ROOTFS_POSTPROCESS_COMMAND +=
>> > +"remove_packaging_data_files ; "
>> > +
>> > +IMAGE_FSTYPES = "tar.gz ext2.gz.u-boot jffs2"
>> > diff --git a/images/fsl-toolchain-bare.bb
>> > b/images/fsl-toolchain-bare.bb new file mode 100644 index
>> > 0000000..74a3c4a
>> > --- /dev/null
>> > +++ b/images/fsl-toolchain-bare.bb
>> > @@ -0,0 +1,8 @@
>> > +PR = "r3"
>> > +
>> > +require recipes-core/meta/meta-toolchain.bb
>> > +
>> > +TOOLCHAIN_OUTPUTNAME = "${SDK_NAME}-toolchain-bare-${DISTRO_VERSION}"
>> > +TOOLCHAIN_TARGET_TASK = "packagegroup-core-standalone-sdk-target"
>> > +TOOLCHAIN_HOST_TASK = "packagegroup-cross-canadian-
>> ${TRANSLATED_TARGET_ARCH}"
>> > +TOOLCHAIN_NEED_CONFIGSITE_CACHE += "zlib"
>> > diff --git a/images/fsl-toolchain.bb b/images/fsl-toolchain.bb new
>> > file mode 100644 index 0000000..696681c
>> > --- /dev/null
>> > +++ b/images/fsl-toolchain.bb
>> > @@ -0,0 +1,19 @@
>> > +PR = "r2"
>> > +
>> > +require fsl-toolchain-bare.bb
>> > +
>> > +TOOLCHAIN_OUTPUTNAME = "${SDK_NAME}-toolchain-${DISTRO_VERSION}"
>> > +TOOLCHAIN_TARGET_TASK += " \
>> > +       glib-2.0 \
>> > +       glib-2.0-dev \
>> > +       dtc \
>> > +       libgomp \
>> > +       libgomp-dev \
>> > +       libgomp-staticdev \
>> > +       libstdc++-staticdev \
>> > +       ${TCLIBC}-staticdev \
>> > +       "
>> > +
>> > +TOOLCHAIN_HOST_TASK += " \
>> > +       nativesdk-dtc \
>> > +       "
>> > --
>> > 1.7.9.5
>> >
>> >
>> > _______________________________________________
>> > meta-freescale mailing list
>> > meta-freescale@yoctoproject.org
>> > https://lists.yoctoproject.org/listinfo/meta-freescale
>
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale
Zhenhua Luo - March 1, 2013, 3:57 a.m.
You are right, there is another patch(http://patches.openembedded.org/patch/45269/) to remove the images folder. 

The intention of the patch is to remove the confusion commit(mismatched title and change). 


Best Regards,

Zhenhua


> -----Original Message-----
> From: McClintock Matthew-B29882
> Sent: Friday, March 01, 2013 11:54 AM
> To: Luo Zhenhua-B19537
> Cc: McClintock Matthew-B29882; meta-freescale@yoctoproject.org
> Subject: Re: [meta-freescale] [meta-fsl-ppc master 1/4] Revert "Remove
> recipes-append folder which are SDK specific"
> 
> On Thu, Feb 28, 2013 at 9:37 PM, Luo Zhenhua-B19537 <B19537@freescale.com>
> wrote:
> > No previous patch removed images folder except current one, the reason
> of revert is that the patch title and actual change doesn't match. Title
> indicates remove recipes-append, but the actual modification is removing
> images.
> 
> I'm still lost..
> 
> My thoughts are that images should not live in meta-fsl-ppc. They should
> live in the distro layer.
> 
> -M
> 
> >
> >
> > Best Regards,
> >
> > Zhenhua
> >
> >
> >> -----Original Message-----
> >> From: McClintock Matthew-B29882
> >> Sent: Thursday, February 28, 2013 11:24 PM
> >> To: Luo Zhenhua-B19537
> >> Cc: meta-freescale@yoctoproject.org
> >> Subject: Re: [meta-freescale] [meta-fsl-ppc master 1/4] Revert
> >> "Remove recipes-append folder which are SDK specific"
> >>
> >> On Thu, Feb 28, 2013 at 2:54 AM, Zhenhua Luo
> >> <zhenhua.luo@freescale.com>
> >> wrote:
> >> > The subject and actual change don't match. actual change is to
> >> > remove images folder
> >> >
> >> > This reverts commit ee364575803812dbbb2b103d468c66c54efcc7af.
> >>
> >> The previous patch removed these? I'm confused.
> >>
> >> -M
> >>
> >> > ---
> >> >  images/fsl-image-lsb-sdk.bb  |   18 ++++++++++++++++++
> >> >  images/fsl-image-minimal.bb  |   16 ++++++++++++++++
> >> >  images/fsl-toolchain-bare.bb |    8 ++++++++
> >> >  images/fsl-toolchain.bb      |   19 +++++++++++++++++++
> >> >  4 files changed, 61 insertions(+)
> >> >  create mode 100644 images/fsl-image-lsb-sdk.bb  create mode 100644
> >> > images/fsl-image-minimal.bb  create mode 100644
> >> > images/fsl-toolchain-bare.bb  create mode 100644
> >> > images/fsl-toolchain.bb
> >> >
> >> > diff --git a/images/fsl-image-lsb-sdk.bb
> >> > b/images/fsl-image-lsb-sdk.bb new file mode 100644 index
> >> > 0000000..1ba38d3
> >> > --- /dev/null
> >> > +++ b/images/fsl-image-lsb-sdk.bb
> >> > @@ -0,0 +1,18 @@
> >> > +IMAGE_FEATURES += "tools-sdk dev-pkgs ssh-server-openssh"
> >> > +EXTRA_IMAGE_FEATURES = "tools-debug tools-profile tools-testapps
> >> debug-tweaks"
> >> > +
> >> > +IMAGE_INSTALL = "\
> >> > +    ${CORE_IMAGE_BASE_INSTALL} \
> >> > +    packagegroup-core-basic \
> >> > +    packagegroup-core-lsb \
> >> > +    git \
> >> > +    dtc \
> >> > +    flex \
> >> > +    bison \
> >> > +    ccache \
> >> > +    u-boot \
> >> > +    "
> >> > +
> >> > +inherit core-image
> >> > +
> >> > +IMAGE_FSTYPES = "tar.gz"
> >> > diff --git a/images/fsl-image-minimal.bb
> >> > b/images/fsl-image-minimal.bb new file mode 100644 index
> >> > 0000000..1732585
> >> > --- /dev/null
> >> > +++ b/images/fsl-image-minimal.bb
> >> > @@ -0,0 +1,16 @@
> >> > +#
> >> > +# Copyright (C) 2007 OpenedHand Ltd.
> >> > +#
> >> > +IMAGE_INSTALL = "packagegroup-core-boot
> >> > +${ROOTFS_PKGMANAGE_BOOTSTRAP}
> >> u-boot"
> >> > +IMAGE_LINGUAS = " "
> >> > +
> >> > +LICENSE = "MIT"
> >> > +
> >> > +inherit core-image
> >> > +
> >> > +IMAGE_ROOTFS_SIZE = "8192"
> >> > +
> >> > +# remove not needed ipkg informations ROOTFS_POSTPROCESS_COMMAND
> >> > ++= "remove_packaging_data_files ; "
> >> > +
> >> > +IMAGE_FSTYPES = "tar.gz ext2.gz.u-boot jffs2"
> >> > diff --git a/images/fsl-toolchain-bare.bb
> >> > b/images/fsl-toolchain-bare.bb new file mode 100644 index
> >> > 0000000..74a3c4a
> >> > --- /dev/null
> >> > +++ b/images/fsl-toolchain-bare.bb
> >> > @@ -0,0 +1,8 @@
> >> > +PR = "r3"
> >> > +
> >> > +require recipes-core/meta/meta-toolchain.bb
> >> > +
> >> > +TOOLCHAIN_OUTPUTNAME = "${SDK_NAME}-toolchain-bare-
> ${DISTRO_VERSION}"
> >> > +TOOLCHAIN_TARGET_TASK = "packagegroup-core-standalone-sdk-target"
> >> > +TOOLCHAIN_HOST_TASK = "packagegroup-cross-canadian-
> >> ${TRANSLATED_TARGET_ARCH}"
> >> > +TOOLCHAIN_NEED_CONFIGSITE_CACHE += "zlib"
> >> > diff --git a/images/fsl-toolchain.bb b/images/fsl-toolchain.bb new
> >> > file mode 100644 index 0000000..696681c
> >> > --- /dev/null
> >> > +++ b/images/fsl-toolchain.bb
> >> > @@ -0,0 +1,19 @@
> >> > +PR = "r2"
> >> > +
> >> > +require fsl-toolchain-bare.bb
> >> > +
> >> > +TOOLCHAIN_OUTPUTNAME = "${SDK_NAME}-toolchain-${DISTRO_VERSION}"
> >> > +TOOLCHAIN_TARGET_TASK += " \
> >> > +       glib-2.0 \
> >> > +       glib-2.0-dev \
> >> > +       dtc \
> >> > +       libgomp \
> >> > +       libgomp-dev \
> >> > +       libgomp-staticdev \
> >> > +       libstdc++-staticdev \
> >> > +       ${TCLIBC}-staticdev \
> >> > +       "
> >> > +
> >> > +TOOLCHAIN_HOST_TASK += " \
> >> > +       nativesdk-dtc \
> >> > +       "
> >> > --
> >> > 1.7.9.5
> >> >
> >> >
> >> > _______________________________________________
> >> > meta-freescale mailing list
> >> > meta-freescale@yoctoproject.org
> >> > https://lists.yoctoproject.org/listinfo/meta-freescale
> >
> > _______________________________________________
> > meta-freescale mailing list
> > meta-freescale@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-freescale
McClintock Matthew-B29882 - March 1, 2013, 4:12 a.m.
On Thu, Feb 28, 2013 at 9:57 PM, Luo Zhenhua-B19537
<B19537@freescale.com> wrote:
> You are right, there is another patch(http://patches.openembedded.org/patch/45269/) to remove the images folder.
>
> The intention of the patch is to remove the confusion commit(mismatched title and change).

Ah, OK. The commit should include that last line. Actually if you want
to submit it - it should just be a revert.

$ git revert $SHA

And the commit message will be quite clear what's going on, and you
can add some more to it if needed.

-M

>
>
> Best Regards,
>
> Zhenhua
>
>
>> -----Original Message-----
>> From: McClintock Matthew-B29882
>> Sent: Friday, March 01, 2013 11:54 AM
>> To: Luo Zhenhua-B19537
>> Cc: McClintock Matthew-B29882; meta-freescale@yoctoproject.org
>> Subject: Re: [meta-freescale] [meta-fsl-ppc master 1/4] Revert "Remove
>> recipes-append folder which are SDK specific"
>>
>> On Thu, Feb 28, 2013 at 9:37 PM, Luo Zhenhua-B19537 <B19537@freescale.com>
>> wrote:
>> > No previous patch removed images folder except current one, the reason
>> of revert is that the patch title and actual change doesn't match. Title
>> indicates remove recipes-append, but the actual modification is removing
>> images.
>>
>> I'm still lost..
>>
>> My thoughts are that images should not live in meta-fsl-ppc. They should
>> live in the distro layer.
>>
>> -M
>>
>> >
>> >
>> > Best Regards,
>> >
>> > Zhenhua
>> >
>> >
>> >> -----Original Message-----
>> >> From: McClintock Matthew-B29882
>> >> Sent: Thursday, February 28, 2013 11:24 PM
>> >> To: Luo Zhenhua-B19537
>> >> Cc: meta-freescale@yoctoproject.org
>> >> Subject: Re: [meta-freescale] [meta-fsl-ppc master 1/4] Revert
>> >> "Remove recipes-append folder which are SDK specific"
>> >>
>> >> On Thu, Feb 28, 2013 at 2:54 AM, Zhenhua Luo
>> >> <zhenhua.luo@freescale.com>
>> >> wrote:
>> >> > The subject and actual change don't match. actual change is to
>> >> > remove images folder
>> >> >
>> >> > This reverts commit ee364575803812dbbb2b103d468c66c54efcc7af.
>> >>
>> >> The previous patch removed these? I'm confused.
>> >>
>> >> -M
>> >>
>> >> > ---
>> >> >  images/fsl-image-lsb-sdk.bb  |   18 ++++++++++++++++++
>> >> >  images/fsl-image-minimal.bb  |   16 ++++++++++++++++
>> >> >  images/fsl-toolchain-bare.bb |    8 ++++++++
>> >> >  images/fsl-toolchain.bb      |   19 +++++++++++++++++++
>> >> >  4 files changed, 61 insertions(+)
>> >> >  create mode 100644 images/fsl-image-lsb-sdk.bb  create mode 100644
>> >> > images/fsl-image-minimal.bb  create mode 100644
>> >> > images/fsl-toolchain-bare.bb  create mode 100644
>> >> > images/fsl-toolchain.bb
>> >> >
>> >> > diff --git a/images/fsl-image-lsb-sdk.bb
>> >> > b/images/fsl-image-lsb-sdk.bb new file mode 100644 index
>> >> > 0000000..1ba38d3
>> >> > --- /dev/null
>> >> > +++ b/images/fsl-image-lsb-sdk.bb
>> >> > @@ -0,0 +1,18 @@
>> >> > +IMAGE_FEATURES += "tools-sdk dev-pkgs ssh-server-openssh"
>> >> > +EXTRA_IMAGE_FEATURES = "tools-debug tools-profile tools-testapps
>> >> debug-tweaks"
>> >> > +
>> >> > +IMAGE_INSTALL = "\
>> >> > +    ${CORE_IMAGE_BASE_INSTALL} \
>> >> > +    packagegroup-core-basic \
>> >> > +    packagegroup-core-lsb \
>> >> > +    git \
>> >> > +    dtc \
>> >> > +    flex \
>> >> > +    bison \
>> >> > +    ccache \
>> >> > +    u-boot \
>> >> > +    "
>> >> > +
>> >> > +inherit core-image
>> >> > +
>> >> > +IMAGE_FSTYPES = "tar.gz"
>> >> > diff --git a/images/fsl-image-minimal.bb
>> >> > b/images/fsl-image-minimal.bb new file mode 100644 index
>> >> > 0000000..1732585
>> >> > --- /dev/null
>> >> > +++ b/images/fsl-image-minimal.bb
>> >> > @@ -0,0 +1,16 @@
>> >> > +#
>> >> > +# Copyright (C) 2007 OpenedHand Ltd.
>> >> > +#
>> >> > +IMAGE_INSTALL = "packagegroup-core-boot
>> >> > +${ROOTFS_PKGMANAGE_BOOTSTRAP}
>> >> u-boot"
>> >> > +IMAGE_LINGUAS = " "
>> >> > +
>> >> > +LICENSE = "MIT"
>> >> > +
>> >> > +inherit core-image
>> >> > +
>> >> > +IMAGE_ROOTFS_SIZE = "8192"
>> >> > +
>> >> > +# remove not needed ipkg informations ROOTFS_POSTPROCESS_COMMAND
>> >> > ++= "remove_packaging_data_files ; "
>> >> > +
>> >> > +IMAGE_FSTYPES = "tar.gz ext2.gz.u-boot jffs2"
>> >> > diff --git a/images/fsl-toolchain-bare.bb
>> >> > b/images/fsl-toolchain-bare.bb new file mode 100644 index
>> >> > 0000000..74a3c4a
>> >> > --- /dev/null
>> >> > +++ b/images/fsl-toolchain-bare.bb
>> >> > @@ -0,0 +1,8 @@
>> >> > +PR = "r3"
>> >> > +
>> >> > +require recipes-core/meta/meta-toolchain.bb
>> >> > +
>> >> > +TOOLCHAIN_OUTPUTNAME = "${SDK_NAME}-toolchain-bare-
>> ${DISTRO_VERSION}"
>> >> > +TOOLCHAIN_TARGET_TASK = "packagegroup-core-standalone-sdk-target"
>> >> > +TOOLCHAIN_HOST_TASK = "packagegroup-cross-canadian-
>> >> ${TRANSLATED_TARGET_ARCH}"
>> >> > +TOOLCHAIN_NEED_CONFIGSITE_CACHE += "zlib"
>> >> > diff --git a/images/fsl-toolchain.bb b/images/fsl-toolchain.bb new
>> >> > file mode 100644 index 0000000..696681c
>> >> > --- /dev/null
>> >> > +++ b/images/fsl-toolchain.bb
>> >> > @@ -0,0 +1,19 @@
>> >> > +PR = "r2"
>> >> > +
>> >> > +require fsl-toolchain-bare.bb
>> >> > +
>> >> > +TOOLCHAIN_OUTPUTNAME = "${SDK_NAME}-toolchain-${DISTRO_VERSION}"
>> >> > +TOOLCHAIN_TARGET_TASK += " \
>> >> > +       glib-2.0 \
>> >> > +       glib-2.0-dev \
>> >> > +       dtc \
>> >> > +       libgomp \
>> >> > +       libgomp-dev \
>> >> > +       libgomp-staticdev \
>> >> > +       libstdc++-staticdev \
>> >> > +       ${TCLIBC}-staticdev \
>> >> > +       "
>> >> > +
>> >> > +TOOLCHAIN_HOST_TASK += " \
>> >> > +       nativesdk-dtc \
>> >> > +       "
>> >> > --
>> >> > 1.7.9.5
>> >> >
>> >> >
>> >> > _______________________________________________
>> >> > meta-freescale mailing list
>> >> > meta-freescale@yoctoproject.org
>> >> > https://lists.yoctoproject.org/listinfo/meta-freescale
>> >
>> > _______________________________________________
>> > meta-freescale mailing list
>> > meta-freescale@yoctoproject.org
>> > https://lists.yoctoproject.org/listinfo/meta-freescale
>
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale

Patch

diff --git a/images/fsl-image-lsb-sdk.bb b/images/fsl-image-lsb-sdk.bb
new file mode 100644
index 0000000..1ba38d3
--- /dev/null
+++ b/images/fsl-image-lsb-sdk.bb
@@ -0,0 +1,18 @@ 
+IMAGE_FEATURES += "tools-sdk dev-pkgs ssh-server-openssh"
+EXTRA_IMAGE_FEATURES = "tools-debug tools-profile tools-testapps debug-tweaks"
+
+IMAGE_INSTALL = "\
+    ${CORE_IMAGE_BASE_INSTALL} \
+    packagegroup-core-basic \
+    packagegroup-core-lsb \
+    git \
+    dtc \
+    flex \
+    bison \
+    ccache \
+    u-boot \
+    "
+
+inherit core-image
+
+IMAGE_FSTYPES = "tar.gz"
diff --git a/images/fsl-image-minimal.bb b/images/fsl-image-minimal.bb
new file mode 100644
index 0000000..1732585
--- /dev/null
+++ b/images/fsl-image-minimal.bb
@@ -0,0 +1,16 @@ 
+#
+# Copyright (C) 2007 OpenedHand Ltd.
+#
+IMAGE_INSTALL = "packagegroup-core-boot ${ROOTFS_PKGMANAGE_BOOTSTRAP} u-boot"
+IMAGE_LINGUAS = " "
+
+LICENSE = "MIT"
+
+inherit core-image
+
+IMAGE_ROOTFS_SIZE = "8192"
+
+# remove not needed ipkg informations
+ROOTFS_POSTPROCESS_COMMAND += "remove_packaging_data_files ; "
+
+IMAGE_FSTYPES = "tar.gz ext2.gz.u-boot jffs2"
diff --git a/images/fsl-toolchain-bare.bb b/images/fsl-toolchain-bare.bb
new file mode 100644
index 0000000..74a3c4a
--- /dev/null
+++ b/images/fsl-toolchain-bare.bb
@@ -0,0 +1,8 @@ 
+PR = "r3"
+
+require recipes-core/meta/meta-toolchain.bb
+
+TOOLCHAIN_OUTPUTNAME = "${SDK_NAME}-toolchain-bare-${DISTRO_VERSION}"
+TOOLCHAIN_TARGET_TASK = "packagegroup-core-standalone-sdk-target"
+TOOLCHAIN_HOST_TASK = "packagegroup-cross-canadian-${TRANSLATED_TARGET_ARCH}"
+TOOLCHAIN_NEED_CONFIGSITE_CACHE += "zlib"
diff --git a/images/fsl-toolchain.bb b/images/fsl-toolchain.bb
new file mode 100644
index 0000000..696681c
--- /dev/null
+++ b/images/fsl-toolchain.bb
@@ -0,0 +1,19 @@ 
+PR = "r2"
+
+require fsl-toolchain-bare.bb
+
+TOOLCHAIN_OUTPUTNAME = "${SDK_NAME}-toolchain-${DISTRO_VERSION}"
+TOOLCHAIN_TARGET_TASK += " \
+	glib-2.0 \
+	glib-2.0-dev \
+	dtc \
+	libgomp \
+	libgomp-dev \
+	libgomp-staticdev \
+	libstdc++-staticdev \
+	${TCLIBC}-staticdev \
+	"
+
+TOOLCHAIN_HOST_TASK += " \
+	nativesdk-dtc \
+	"