Patchwork systemd: set the location of the kill binary

login
register
mail settings
Submitter Ross Burton
Date Feb. 26, 2013, 5:35 p.m.
Message ID <1361900109-21869-1-git-send-email-ross.burton@intel.com>
Download mbox | patch
Permalink /patch/45139/
State New
Headers show

Comments

Ross Burton - Feb. 26, 2013, 5:35 p.m.
Otherwise systemd uses AC_PROG_PATH and finds it in the sysroot, which won't
work on the target.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/recipes-core/systemd/systemd_197.bb |    2 ++
 1 file changed, 2 insertions(+)
Otavio Salvador - Feb. 26, 2013, 5:41 p.m.
On Tue, Feb 26, 2013 at 2:35 PM, Ross Burton <ross.burton@intel.com> wrote:
> Otherwise systemd uses AC_PROG_PATH and finds it in the sysroot, which won't
> work on the target.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  meta/recipes-core/systemd/systemd_197.bb |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-core/systemd/systemd_197.bb b/meta/recipes-core/systemd/systemd_197.bb
> index c765c18..44cd919 100644
> --- a/meta/recipes-core/systemd/systemd_197.bb
> +++ b/meta/recipes-core/systemd/systemd_197.bb
> @@ -48,6 +48,8 @@ PACKAGECONFIG[gcrypt] = "--enable-gcrypt,--disable-gcrypt,libgcrypt"
>  # Compress the journal
>  PACKAGECONFIG[xz] = "--enable-xz,--disable-xz,xz"
>
> +export ac_cv_path_KILL="/bin/kill"

This can be given in EXTRA_OECONF IIRC. Did you try it?

>  # The gtk+ tools should get built as a separate recipe e.g. systemd-tools
>  EXTRA_OECONF = " --with-rootprefix=${base_prefix} \
>                   --with-rootlibdir=${base_libdir} \
> --
> 1.7.10.4
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Ross Burton - Feb. 26, 2013, 5:42 p.m.
On 26 February 2013 17:41, Otavio Salvador <otavio@ossystems.com.br> wrote:
>> +export ac_cv_path_KILL="/bin/kill"
>
> This can be given in EXTRA_OECONF IIRC. Did you try it?

That would also work, yes.  Is that the preferred style?

Ross
Otavio Salvador - Feb. 26, 2013, 5:48 p.m.
On Tue, Feb 26, 2013 at 2:42 PM, Burton, Ross <ross.burton@intel.com> wrote:
> On 26 February 2013 17:41, Otavio Salvador <otavio@ossystems.com.br> wrote:
>>> +export ac_cv_path_KILL="/bin/kill"
>>
>> This can be given in EXTRA_OECONF IIRC. Did you try it?
>
> That would also work, yes.  Is that the preferred style?

At least for me it makes more sense as it is being passed to change
configure behavior so makes sense to be there.
Khem Raj - Feb. 26, 2013, 6:06 p.m.
On (26/02/13 17:35), Ross Burton wrote:
> Otherwise systemd uses AC_PROG_PATH and finds it in the sysroot, which won't
> work on the target.
> 
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  meta/recipes-core/systemd/systemd_197.bb |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta/recipes-core/systemd/systemd_197.bb b/meta/recipes-core/systemd/systemd_197.bb
> index c765c18..44cd919 100644
> --- a/meta/recipes-core/systemd/systemd_197.bb
> +++ b/meta/recipes-core/systemd/systemd_197.bb
> @@ -48,6 +48,8 @@ PACKAGECONFIG[gcrypt] = "--enable-gcrypt,--disable-gcrypt,libgcrypt"
>  # Compress the journal
>  PACKAGECONFIG[xz] = "--enable-xz,--disable-xz,xz"
>  
> +export ac_cv_path_KILL="/bin/kill"

may be ac_cv_path_KILL="/usr/bin/env kill"

Patch

diff --git a/meta/recipes-core/systemd/systemd_197.bb b/meta/recipes-core/systemd/systemd_197.bb
index c765c18..44cd919 100644
--- a/meta/recipes-core/systemd/systemd_197.bb
+++ b/meta/recipes-core/systemd/systemd_197.bb
@@ -48,6 +48,8 @@  PACKAGECONFIG[gcrypt] = "--enable-gcrypt,--disable-gcrypt,libgcrypt"
 # Compress the journal
 PACKAGECONFIG[xz] = "--enable-xz,--disable-xz,xz"
 
+export ac_cv_path_KILL="/bin/kill"
+
 # The gtk+ tools should get built as a separate recipe e.g. systemd-tools
 EXTRA_OECONF = " --with-rootprefix=${base_prefix} \
                  --with-rootlibdir=${base_libdir} \