Patchwork [meta-fsl-arm] linux-fslc: mxs: defconfig: Select CAN options as built-in

login
register
mail settings
Submitter Fabio Estevam
Date Feb. 25, 2013, 2:24 p.m.
Message ID <1361802252-26206-1-git-send-email-fabio.estevam@freescale.com>
Download mbox | patch
Permalink /patch/45037/
State Rejected
Delegated to: Otavio Salvador
Headers show

Comments

Fabio Estevam - Feb. 25, 2013, 2:24 p.m.
Select CAN options as built-in instead of modules.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 recipes-kernel/linux/linux-fslc/mxs/defconfig |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
Otavio Salvador - Feb. 25, 2013, 3:06 p.m.
On Mon, Feb 25, 2013 at 11:24 AM, Fabio Estevam
<fabio.estevam@freescale.com> wrote:
> Select CAN options as built-in instead of modules.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Why? I understand that for development using TFTP/NFS it is easier but
for deployment it increases boot time as it can be done later after
init is already running.
Fabio Estevam - Feb. 25, 2013, 3:14 p.m.
On Mon, Feb 25, 2013 at 12:06 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> On Mon, Feb 25, 2013 at 11:24 AM, Fabio Estevam
> <fabio.estevam@freescale.com> wrote:
>> Select CAN options as built-in instead of modules.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Why? I understand that for development using TFTP/NFS it is easier but
> for deployment it increases boot time as it can be done later after
> init is already running.

It is just for convenience. I think it is useful/easier to load
drivers as built-in rather than modules.
Otavio Salvador - Feb. 25, 2013, 3:25 p.m.
On Mon, Feb 25, 2013 at 12:14 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Mon, Feb 25, 2013 at 12:06 PM, Otavio Salvador
> <otavio@ossystems.com.br> wrote:
>> On Mon, Feb 25, 2013 at 11:24 AM, Fabio Estevam
>> <fabio.estevam@freescale.com> wrote:
>>> Select CAN options as built-in instead of modules.
>>>
>>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> Why? I understand that for development using TFTP/NFS it is easier but
>> for deployment it increases boot time as it can be done later after
>> init is already running.
>
> It is just for convenience. I think it is useful/easier to load
> drivers as built-in rather than modules.

For development I agree however for Yocto default I am not sure we
should default for it.

Patch

diff --git a/recipes-kernel/linux/linux-fslc/mxs/defconfig b/recipes-kernel/linux/linux-fslc/mxs/defconfig
index 57592e2..1f17cbf 100644
--- a/recipes-kernel/linux/linux-fslc/mxs/defconfig
+++ b/recipes-kernel/linux/linux-fslc/mxs/defconfig
@@ -43,11 +43,11 @@  CONFIG_SYN_COOKIES=y
 # CONFIG_INET_LRO is not set
 # CONFIG_INET_DIAG is not set
 # CONFIG_IPV6 is not set
-CONFIG_CAN=m
-CONFIG_CAN_RAW=m
-CONFIG_CAN_BCM=m
-CONFIG_CAN_DEV=m
-CONFIG_CAN_FLEXCAN=m
+CONFIG_CAN=y
+CONFIG_CAN_RAW=y
+CONFIG_CAN_BCM=y
+CONFIG_CAN_DEV=y
+CONFIG_CAN_FLEXCAN=y
 # CONFIG_WIRELESS is not set
 CONFIG_DEVTMPFS=y
 CONFIG_DEVTMPFS_MOUNT=y