Patchwork [meta-opie] kdepimpi: Fix multiline comments

login
register
mail settings
Submitter Khem Raj
Date Feb. 21, 2013, 7:42 a.m.
Message ID <1361432524-26238-1-git-send-email-raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/44973/
State Superseded, archived
Headers show

Comments

Khem Raj - Feb. 21, 2013, 7:42 a.m.
Makes parsing go through

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 recipes-qtopia/kdepimpi/kdepimpi-base.inc |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Paul Eggleton - Feb. 21, 2013, 9:55 a.m.
On Wednesday 20 February 2013 23:42:04 Khem Raj wrote:
> Makes parsing go through
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  recipes-qtopia/kdepimpi/kdepimpi-base.inc |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/recipes-qtopia/kdepimpi/kdepimpi-base.inc
> b/recipes-qtopia/kdepimpi/kdepimpi-base.inc index 27cc237..5d6bb0d 100644
> --- a/recipes-qtopia/kdepimpi/kdepimpi-base.inc
> +++ b/recipes-qtopia/kdepimpi/kdepimpi-base.inc
> @@ -33,7 +33,7 @@ LIBS+=-lz \
>  # That changes will be needed for KMicroMail/PI to get it build with OE
> libs #
>  #             LIBS-=-lkmicromailwrapper LIBS+=-lmailwrapper
> LIBS+=-lopiecore2 \ -
> +#
>  QMAKE_PROFILES= "all.pro"
> 
>  SUBDIRS="qtcompat libical/src/libical libical/src/libicalss microkde
> libkcal libkdepim \ @@ -47,7 +47,7 @@ SUBDIRS="qtcompat libical/src/libical
> libical/src/libicalss microkde libkcal lib #       
> pwmanager/libcrypt/cipher  \
>  #        pwmanager/libcrypt/zlib \
>  #        pwmanager/pwmanager \
> -
> +#
>  inherit palmtop
> 
>  do_configure_prepend() {

Thanks, but you already sent a patch for this and I already merged it:

http://cgit.openembedded.org/meta-opie/commit/?id=93df88a1cc88c4db2616b9e31aa13477f2c7f63e

Cheers,
Paul
Khem Raj - Feb. 26, 2013, 11:28 p.m.
hmmm in angstrom we have been using git://github.com/bluelightning/meta-opie.git
for fetching meta-opie and thats the problem here. I guess above link
is not true mirror
therefore we should use git.oe.org ?

On Thu, Feb 21, 2013 at 1:55 AM, Paul Eggleton
<paul.eggleton@linux.intel.com> wrote:
> On Wednesday 20 February 2013 23:42:04 Khem Raj wrote:
>> Makes parsing go through
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>>  recipes-qtopia/kdepimpi/kdepimpi-base.inc |    4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/recipes-qtopia/kdepimpi/kdepimpi-base.inc
>> b/recipes-qtopia/kdepimpi/kdepimpi-base.inc index 27cc237..5d6bb0d 100644
>> --- a/recipes-qtopia/kdepimpi/kdepimpi-base.inc
>> +++ b/recipes-qtopia/kdepimpi/kdepimpi-base.inc
>> @@ -33,7 +33,7 @@ LIBS+=-lz \
>>  # That changes will be needed for KMicroMail/PI to get it build with OE
>> libs #
>>  #             LIBS-=-lkmicromailwrapper LIBS+=-lmailwrapper
>> LIBS+=-lopiecore2 \ -
>> +#
>>  QMAKE_PROFILES= "all.pro"
>>
>>  SUBDIRS="qtcompat libical/src/libical libical/src/libicalss microkde
>> libkcal libkdepim \ @@ -47,7 +47,7 @@ SUBDIRS="qtcompat libical/src/libical
>> libical/src/libicalss microkde libkcal lib #
>> pwmanager/libcrypt/cipher  \
>>  #        pwmanager/libcrypt/zlib \
>>  #        pwmanager/pwmanager \
>> -
>> +#
>>  inherit palmtop
>>
>>  do_configure_prepend() {
>
> Thanks, but you already sent a patch for this and I already merged it:
>
> http://cgit.openembedded.org/meta-opie/commit/?id=93df88a1cc88c4db2616b9e31aa13477f2c7f63e
>
> Cheers,
> Paul
>
> --
>
> Paul Eggleton
> Intel Open Source Technology Centre
Paul Eggleton - Feb. 27, 2013, 12:03 a.m.
On Tuesday 26 February 2013 15:28:04 Khem Raj wrote:
> hmmm in angstrom we have been using
> git://github.com/bluelightning/meta-opie.git for fetching meta-opie and
> thats the problem here. I guess above link is not true mirror
> therefore we should use git.oe.org ?

Ah, oops... I neglected to push to that repo as well, now I have done so. 
Mirroring is manual for meta-opie / meta-handheld - maybe it shouldn't be.

Cheers,
Paul
Khem Raj - Feb. 27, 2013, 12:04 a.m.
On Tue, Feb 26, 2013 at 4:03 PM, Paul Eggleton
<paul.eggleton@linux.intel.com> wrote:
>
> Ah, oops... I neglected to push to that repo as well, now I have done so.
> Mirroring is manual for meta-opie / meta-handheld - maybe it shouldn't be.

we have auto updates to meta-oe and other git trees. May be you can
work with Phil to add meta-opie to OE
github mirror as well.

Patch

diff --git a/recipes-qtopia/kdepimpi/kdepimpi-base.inc b/recipes-qtopia/kdepimpi/kdepimpi-base.inc
index 27cc237..5d6bb0d 100644
--- a/recipes-qtopia/kdepimpi/kdepimpi-base.inc
+++ b/recipes-qtopia/kdepimpi/kdepimpi-base.inc
@@ -33,7 +33,7 @@  LIBS+=-lz \
 # That changes will be needed for KMicroMail/PI to get it build with OE libs
 #
 #             LIBS-=-lkmicromailwrapper LIBS+=-lmailwrapper LIBS+=-lopiecore2 \
-
+#
 QMAKE_PROFILES= "all.pro"
 
 SUBDIRS="qtcompat libical/src/libical libical/src/libicalss microkde libkcal libkdepim \
@@ -47,7 +47,7 @@  SUBDIRS="qtcompat libical/src/libical libical/src/libicalss microkde libkcal lib
 #        pwmanager/libcrypt/cipher  \
 #        pwmanager/libcrypt/zlib \
 #        pwmanager/pwmanager \
-
+#
 inherit palmtop
 
 do_configure_prepend() {