Patchwork [1/1] base-passwd.preinst:fix creating passwd and group error

login
register
mail settings
Submitter Hongxu Jia
Date Feb. 21, 2013, 6:22 a.m.
Message ID <5d8b955ad3645fb9690823db5f16d5b093cfd343.1361427542.git.hongxu.jia@windriver.com>
Download mbox | patch
Permalink /patch/44961/
State Accepted
Commit aea1d6c29e0c3f7c854045057d8bb389a1609b2b
Headers show

Comments

Hongxu Jia - Feb. 21, 2013, 6:22 a.m.
Create files `passwd' and `group' in `$D${sysconfdir}', if `$D${sysconfdir}'
does not exist, there is an error:
...
cannot create $D${sysconfdir}/passwd: Directory nonexistent
cannot create $D${sysconfdir}/group: Directory nonexistent
...

Attampt to create dir before file creation.

[YOCTO #3917]

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 meta/recipes-core/base-passwd/base-passwd_3.5.26.bb |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Javier Viguera - Feb. 28, 2013, 3:25 p.m.
Hi all,

I was bite by this one [YOCTO #3917] in *danny* branch not allowing me 
to create a rootfs based in DEB packages. Sometimes happens, sometimes 
not, depending on whether 'base-files' is installed in the rootfs before 
or after 'base-passwd'.

Cherry-picking this commit from master fixes the problem.

So could it be also considered for backporting to 'danny' in oe-core and 
poky?

Thanks in advance.
Ross Burton - March 1, 2013, 11:15 a.m.
On 28 February 2013 15:25, Javier Viguera <javier.viguera@digi.com> wrote:
> I was bite by this one [YOCTO #3917] in *danny* branch not allowing me to
> create a rootfs based in DEB packages. Sometimes happens, sometimes not,
> depending on whether 'base-files' is installed in the rootfs before or after
> 'base-passwd'.
>
> Cherry-picking this commit from master fixes the problem.
>
> So could it be also considered for backporting to 'danny' in oe-core and
> poky?

Merged to danny-next, so will be in 1.3.1.

Ross

Patch

diff --git a/meta/recipes-core/base-passwd/base-passwd_3.5.26.bb b/meta/recipes-core/base-passwd/base-passwd_3.5.26.bb
index 2b1dc1c..dd310af 100644
--- a/meta/recipes-core/base-passwd/base-passwd_3.5.26.bb
+++ b/meta/recipes-core/base-passwd/base-passwd_3.5.26.bb
@@ -1,7 +1,7 @@ 
 SUMMARY = "Base system master password/group files."
 DESCRIPTION = "The master copies of the user database files (/etc/passwd and /etc/group).  The update-passwd tool is also provided to keep the system databases synchronized with these master files."
 SECTION = "base"
-PR = "r0"
+PR = "r1"
 LICENSE = "GPLv2+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=eb723b61539feef013de476e68b5c50a"
 
@@ -64,6 +64,7 @@  python populate_packages_prepend() {
     f.close()
 
     preinst = """#!/bin/sh
+mkdir -p $D${sysconfdir}
 if [ ! -e $D${sysconfdir}/passwd ]; then
 \tcat << EOF > $D${sysconfdir}/passwd
 """ + passwd + """EOF