Patchwork conf: Remove unused ROOT_FLASH_SIZE variable from the config

login
register
mail settings
Submitter Holger Hans Peter Freyther
Date Feb. 16, 2013, 10:41 p.m.
Message ID <1361054460-21397-1-git-send-email-holger@moiji-mobile.com>
Download mbox | patch
Permalink /patch/44727/
State Accepted
Commit 68ceb02e98c977dd3eadea2c38b5eb796d6b6db4
Headers show

Comments

Holger Hans Peter Freyther - Feb. 16, 2013, 10:41 p.m.
This variable is set but never used in OE-core and meta-oe. It
was historically used for the Opie collection but seems to be
unused now.
---
 meta/conf/bitbake.conf             |    3 ---
 meta/conf/machine/include/qemu.inc |    2 --
 2 files changed, 5 deletions(-)
Marcin Juszkiewicz - Feb. 16, 2013, 11:13 p.m.
W dniu 16.02.2013 23:41, Holger Hans Peter Freyther pisze:
> This variable is set but never used in OE-core and meta-oe. It
> was historically used for the Opie collection but seems to be
> unused now.

As I am one of those who remember when it was added:

Acked-By: Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>
Khem Raj - Feb. 21, 2013, 10:33 p.m.
On (17/02/13 00:13), Marcin Juszkiewicz wrote:
> W dniu 16.02.2013 23:41, Holger Hans Peter Freyther pisze:
> > This variable is set but never used in OE-core and meta-oe. It
> > was historically used for the Opie collection but seems to be
> > unused now.
> 
> As I am one of those who remember when it was added:
> 
> Acked-By: Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>

There are many BSPs that are still defining it and angstrom depended on
it which now defines it lazily since its not in bitbake.conf anymore
but I wonder if machine confs which define it should also remove it

Patch

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 5f4a412..b1c8dac 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -721,9 +721,6 @@  OES_BITBAKE_CONF = "1"
 
 DISTRO_FEATURES ?= ""
 
-# This is used to limit what packages goes into images built, so set big by default
-ROOT_FLASH_SIZE ?= "256"
-
 DISTRO_EXTRA_RDEPENDS ?= ""
 DISTRO_EXTRA_RRECOMMENDS ?= ""
 MACHINE_EXTRA_RDEPENDS ?= ""
diff --git a/meta/conf/machine/include/qemu.inc b/meta/conf/machine/include/qemu.inc
index f68bf32..52215b3 100644
--- a/meta/conf/machine/include/qemu.inc
+++ b/meta/conf/machine/include/qemu.inc
@@ -16,8 +16,6 @@  MACHINEOVERRIDES .= ":qemuall"
 
 IMAGE_FSTYPES += "tar.bz2 ext3"
 
-ROOT_FLASH_SIZE = "280"
-
 # Don't include kernels in standard images
 RDEPENDS_kernel-base = ""