| Submitter | Otavio Salvador |
|---|---|
| Date | Feb. 16, 2013, 9:20 p.m. |
| Message ID | <1361049644-27904-3-git-send-email-otavio@ossystems.com.br> |
| Download | mbox | patch |
| Permalink | /patch/44721/ |
| State | New |
| Headers | show |
Comments
On Sat, 2013-02-16 at 19:20 -0200, Otavio Salvador wrote: > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> > --- > meta/recipes-graphics/libsdl/libsdl_1.2.15.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb b/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb > index e25c597..3dbe97a 100644 > --- a/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb > +++ b/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb > @@ -16,7 +16,7 @@ DEPENDS = "${@base_contains('DISTRO_FEATURES', 'directfb', 'directfb', '', d)} \ > ${@base_contains('DISTRO_FEATURES', 'opengl', 'virtual/libgl', '', d)} \ > ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 libxext libxrandr libxrender', '', d)} \ > tslib" > -DEPENDS_class-nativesdk = "${@base_contains('DISTRO_FEATURES', 'x11', 'nativesdk-libx11 nativesdk-libxrandr nativesdk-libxrender nativesdk-libxext', '', d)}" > +DEPENDS_class-nativesdk = "${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 nativesdk-libxrandr nativesdk-libxrender nativesdk-libxext', '', d)}" Don't you mean virtual/nativesdk-libx11 ? Cheers, Richard
On Sun, Feb 17, 2013 at 4:52 AM, Richard Purdie <richard.purdie@linuxfoundation.org> wrote: > On Sat, 2013-02-16 at 19:20 -0200, Otavio Salvador wrote: >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> >> --- >> meta/recipes-graphics/libsdl/libsdl_1.2.15.bb | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb b/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb >> index e25c597..3dbe97a 100644 >> --- a/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb >> +++ b/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb >> @@ -16,7 +16,7 @@ DEPENDS = "${@base_contains('DISTRO_FEATURES', 'directfb', 'directfb', '', d)} \ >> ${@base_contains('DISTRO_FEATURES', 'opengl', 'virtual/libgl', '', d)} \ >> ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 libxext libxrandr libxrender', '', d)} \ >> tslib" >> -DEPENDS_class-nativesdk = "${@base_contains('DISTRO_FEATURES', 'x11', 'nativesdk-libx11 nativesdk-libxrandr nativesdk-libxrender nativesdk-libxext', '', d)}" >> +DEPENDS_class-nativesdk = "${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 nativesdk-libxrandr nativesdk-libxrender nativesdk-libxext', '', d)}" > > Don't you mean virtual/nativesdk-libx11 ? Other places are using virtual/libx11 so I sticked to it. For me it has worked but I did not change if it'd choose the right package when building with 'x11' (as my project now builds without it).
On Sun, 2013-02-17 at 10:42 -0300, Otavio Salvador wrote: > On Sun, Feb 17, 2013 at 4:52 AM, Richard Purdie > <richard.purdie@linuxfoundation.org> wrote: > > On Sat, 2013-02-16 at 19:20 -0200, Otavio Salvador wrote: > >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> > >> --- > >> meta/recipes-graphics/libsdl/libsdl_1.2.15.bb | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb b/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb > >> index e25c597..3dbe97a 100644 > >> --- a/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb > >> +++ b/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb > >> @@ -16,7 +16,7 @@ DEPENDS = "${@base_contains('DISTRO_FEATURES', 'directfb', 'directfb', '', d)} \ > >> ${@base_contains('DISTRO_FEATURES', 'opengl', 'virtual/libgl', '', d)} \ > >> ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 libxext libxrandr libxrender', '', d)} \ > >> tslib" > >> -DEPENDS_class-nativesdk = "${@base_contains('DISTRO_FEATURES', 'x11', 'nativesdk-libx11 nativesdk-libxrandr nativesdk-libxrender nativesdk-libxext', '', d)}" > >> +DEPENDS_class-nativesdk = "${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 nativesdk-libxrandr nativesdk-libxrender nativesdk-libxext', '', d)}" > > > > Don't you mean virtual/nativesdk-libx11 ? > > Other places are using virtual/libx11 so I sticked to it. Other places in nativesdk overrides? > For me it > has worked but I did not change if it'd choose the right package when > building with 'x11' (as my project now builds without it). That doesn't make it correct. Cheers, Richard
On Sun, Feb 17, 2013 at 10:46 AM, Richard Purdie <richard.purdie@linuxfoundation.org> wrote: > On Sun, 2013-02-17 at 10:42 -0300, Otavio Salvador wrote: >> On Sun, Feb 17, 2013 at 4:52 AM, Richard Purdie >> <richard.purdie@linuxfoundation.org> wrote: >> > On Sat, 2013-02-16 at 19:20 -0200, Otavio Salvador wrote: >> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> >> >> --- >> >> meta/recipes-graphics/libsdl/libsdl_1.2.15.bb | 2 +- >> >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> >> >> diff --git a/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb b/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb >> >> index e25c597..3dbe97a 100644 >> >> --- a/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb >> >> +++ b/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb >> >> @@ -16,7 +16,7 @@ DEPENDS = "${@base_contains('DISTRO_FEATURES', 'directfb', 'directfb', '', d)} \ >> >> ${@base_contains('DISTRO_FEATURES', 'opengl', 'virtual/libgl', '', d)} \ >> >> ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 libxext libxrandr libxrender', '', d)} \ >> >> tslib" >> >> -DEPENDS_class-nativesdk = "${@base_contains('DISTRO_FEATURES', 'x11', 'nativesdk-libx11 nativesdk-libxrandr nativesdk-libxrender nativesdk-libxext', '', d)}" >> >> +DEPENDS_class-nativesdk = "${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 nativesdk-libxrandr nativesdk-libxrender nativesdk-libxext', '', d)}" >> > >> > Don't you mean virtual/nativesdk-libx11 ? >> >> Other places are using virtual/libx11 so I sticked to it. > > Other places in nativesdk overrides? Yes; I can check it again. >> For me it >> has worked but I did not change if it'd choose the right package when >> building with 'x11' (as my project now builds without it). > > That doesn't make it correct. I will check and post v2.
Patch
diff --git a/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb b/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb index e25c597..3dbe97a 100644 --- a/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb +++ b/meta/recipes-graphics/libsdl/libsdl_1.2.15.bb @@ -16,7 +16,7 @@ DEPENDS = "${@base_contains('DISTRO_FEATURES', 'directfb', 'directfb', '', d)} \ ${@base_contains('DISTRO_FEATURES', 'opengl', 'virtual/libgl', '', d)} \ ${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 libxext libxrandr libxrender', '', d)} \ tslib" -DEPENDS_class-nativesdk = "${@base_contains('DISTRO_FEATURES', 'x11', 'nativesdk-libx11 nativesdk-libxrandr nativesdk-libxrender nativesdk-libxext', '', d)}" +DEPENDS_class-nativesdk = "${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 nativesdk-libxrandr nativesdk-libxrender nativesdk-libxext', '', d)}" PR = "r1"
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> --- meta/recipes-graphics/libsdl/libsdl_1.2.15.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)