| Submitter | Amy Fong |
|---|---|
| Date | Feb. 13, 2013, 7:08 p.m. |
| Message ID | <20130213190804.GA11672@windriver.com> |
| Download | mbox | patch |
| Permalink | /patch/44609/ |
| State | Not Applicable |
| Headers | show |
Comments
On Wed, Feb 13, 2013 at 02:08:04PM -0500, Amy Fong wrote: > policyutilutils: needs some dependencies unconditionally > > policycoreutils will fail to compile if selinux isn't in the DISTROFEATURES. > We move these packages out of @target_selinux. > > Signed-off-by: Amy Fong <amy.fong@windriver.com> Where is this meta-selinux layer? I don't see it on http://www.openembedded.org/wiki/LayerIndex or policycoreutils.inc file in meta-oe repo or any layer I've checkouted here. Was this meant for openembedded-devel@lists.openembedded.org? And BTW: use better syntax for PRINC to allow multiple .bbappends.. hmm well you're having PRINC in .inc.. interesting. > -- > > policycoreutils.inc | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/recipes-security/selinux/policycoreutils.inc b/recipes-security/selinux/policycoreutils.inc > index cc54b36..9869a83 100644 > --- a/recipes-security/selinux/policycoreutils.inc > +++ b/recipes-security/selinux/policycoreutils.inc > @@ -1,4 +1,4 @@ > -PRINC = "2" > +PRINC = "3" > > SUMMARY = "SELinux policy core utilities" > DESCRIPTION = "policycoreutils contains the policy core utilities that are required \ > @@ -16,9 +16,10 @@ PAM_SRC_URI = "file://pam.d/newrole \ > " > > DEPENDS += "libsepol libselinux libsemanage" > +DEPENDS += "libcap-ng libcgroup libpam" > > inherit selinux > -DEPENDS += "${@target_selinux(d, 'libcap-ng libcgroup libpam audit')}" > +DEPENDS += "${@target_selinux(d, 'audit')}" > > RDEPENDS_${BPN} += "\ > libselinux-python \ > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
On Thursday 07 March 2013 17:05:42 Martin Jansa wrote: > On Wed, Feb 13, 2013 at 02:08:04PM -0500, Amy Fong wrote: > > policyutilutils: needs some dependencies unconditionally > > > > policycoreutils will fail to compile if selinux isn't in the > > DISTROFEATURES. We move these packages out of @target_selinux. > > > > Signed-off-by: Amy Fong <amy.fong@windriver.com> > > Where is this meta-selinux layer? > > I don't see it on > http://www.openembedded.org/wiki/LayerIndex I think this was an oversight. I've just added it in any case. > Was this meant for openembedded-devel@lists.openembedded.org? According to the MAINTAINERS file in the layer, patches should be sent to yocto@yoctoproject.org. Amy, could you please re-send your patch there? > And BTW: use better syntax for PRINC to allow multiple .bbappends.. hmm > well you're having PRINC in .inc.. interesting. Yes that's probably not best practice. Cheers, Paul
Patch
diff --git a/recipes-security/selinux/policycoreutils.inc b/recipes-security/selinux/policycoreutils.inc index cc54b36..9869a83 100644 --- a/recipes-security/selinux/policycoreutils.inc +++ b/recipes-security/selinux/policycoreutils.inc @@ -1,4 +1,4 @@ -PRINC = "2" +PRINC = "3" SUMMARY = "SELinux policy core utilities" DESCRIPTION = "policycoreutils contains the policy core utilities that are required \ @@ -16,9 +16,10 @@ PAM_SRC_URI = "file://pam.d/newrole \ " DEPENDS += "libsepol libselinux libsemanage" +DEPENDS += "libcap-ng libcgroup libpam" inherit selinux -DEPENDS += "${@target_selinux(d, 'libcap-ng libcgroup libpam audit')}" +DEPENDS += "${@target_selinux(d, 'audit')}" RDEPENDS_${BPN} += "\ libselinux-python \
policyutilutils: needs some dependencies unconditionally policycoreutils will fail to compile if selinux isn't in the DISTROFEATURES. We move these packages out of @target_selinux. Signed-off-by: Amy Fong <amy.fong@windriver.com> -- policycoreutils.inc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)