Patchwork libpfm4: exclude from world

login
register
mail settings
Submitter Martin Jansa
Date Feb. 7, 2013, 2:33 p.m.
Message ID <1360247634-10957-1-git-send-email-Martin.Jansa@gmail.com>
Download mbox | patch
Permalink /patch/44235/
State Superseded, archived
Headers show

Comments

Martin Jansa - Feb. 7, 2013, 2:33 p.m.
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta/recipes-kernel/libpfm/libpfm4_4.3.0.bb | 3 +++
 1 file changed, 3 insertions(+)
Saul Wold - Feb. 7, 2013, 10:43 p.m.
On 02/07/2013 06:33 AM, Martin Jansa wrote:
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>   meta/recipes-kernel/libpfm/libpfm4_4.3.0.bb | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/meta/recipes-kernel/libpfm/libpfm4_4.3.0.bb b/meta/recipes-kernel/libpfm/libpfm4_4.3.0.bb
> index 460029f..438dbc3 100644
> --- a/meta/recipes-kernel/libpfm/libpfm4_4.3.0.bb
> +++ b/meta/recipes-kernel/libpfm/libpfm4_4.3.0.bb
> @@ -24,3 +24,6 @@ S = "${WORKDIR}/libpfm-${PV}"
>   do_install () {
>   	oe_runmake install
>   }
> +
> +# oprofile depends on it only for ppc* and it fails to build on arm
> +EXCLUDE_FROM_WORLD = "1"
>

Should it be EXCLUDE_FROM_WORLD or

COMPATIBLE_MACHINE= "(*ppc*|mpc*)"

Since for a ppc world build it would be valid.

Sau!
McClintock Matthew-B29882 - Feb. 12, 2013, 5:14 p.m.
On Thu, Feb 7, 2013 at 4:43 PM, Saul Wold <sgw@linux.intel.com> wrote:
> On 02/07/2013 06:33 AM, Martin Jansa wrote:
>>
>> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
>> ---
>>   meta/recipes-kernel/libpfm/libpfm4_4.3.0.bb | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/meta/recipes-kernel/libpfm/libpfm4_4.3.0.bb
>> b/meta/recipes-kernel/libpfm/libpfm4_4.3.0.bb
>> index 460029f..438dbc3 100644
>> --- a/meta/recipes-kernel/libpfm/libpfm4_4.3.0.bb
>> +++ b/meta/recipes-kernel/libpfm/libpfm4_4.3.0.bb
>> @@ -24,3 +24,6 @@ S = "${WORKDIR}/libpfm-${PV}"
>>   do_install () {
>>         oe_runmake install
>>   }
>> +
>> +# oprofile depends on it only for ppc* and it fails to build on arm
>> +EXCLUDE_FROM_WORLD = "1"
>>
>
> Should it be EXCLUDE_FROM_WORLD or
>
> COMPATIBLE_MACHINE= "(*ppc*|mpc*)"
>
> Since for a ppc world build it would be valid.

We really need COMPATIBLE_ARCH here...

Actually I've found since I tried to upstream my last patches that
libpfm is only a req for ppc64. I'm going to submit some follow up
patches once I hear back from the oprofile person I've been chatting
with

-M
Phil Blundell - Feb. 12, 2013, 5:19 p.m.
On Tue, 2013-02-12 at 17:14 +0000, McClintock Matthew-B29882 wrote:
> We really need COMPATIBLE_ARCH here...

Why can't you use COMPATIBLE_HOST?

p.
McClintock Matthew-B29882 - Feb. 12, 2013, 5:25 p.m.
On Tue, Feb 12, 2013 at 11:19 AM, Phil Blundell <pb@pbcl.net> wrote:
> On Tue, 2013-02-12 at 17:14 +0000, McClintock Matthew-B29882 wrote:
>> We really need COMPATIBLE_ARCH here...
>
> Why can't you use COMPATIBLE_HOST?

Yes, that's what it's called ;)

-M

Patch

diff --git a/meta/recipes-kernel/libpfm/libpfm4_4.3.0.bb b/meta/recipes-kernel/libpfm/libpfm4_4.3.0.bb
index 460029f..438dbc3 100644
--- a/meta/recipes-kernel/libpfm/libpfm4_4.3.0.bb
+++ b/meta/recipes-kernel/libpfm/libpfm4_4.3.0.bb
@@ -24,3 +24,6 @@  S = "${WORKDIR}/libpfm-${PV}"
 do_install () {
 	oe_runmake install
 }
+
+# oprofile depends on it only for ppc* and it fails to build on arm
+EXCLUDE_FROM_WORLD = "1"