Patchwork insane.bbclass: Add missing R* variables to pkgvarcheck

login
register
mail settings
Submitter Martin Jansa
Date Feb. 6, 2013, 1:25 p.m.
Message ID <1360157122-5181-1-git-send-email-Martin.Jansa@gmail.com>
Download mbox | patch
Permalink /patch/44199/
State Accepted
Commit 56bc2bb95ac51cd1c0a962d65b0eae8568139a06
Headers show

Comments

Martin Jansa - Feb. 6, 2013, 1:25 p.m.
* check also RSUGGESTS, RCONFLICTS, RPROVIDES, RREPLACES

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta/classes/insane.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Phil Blundell - May 2, 2013, 10:16 a.m.
On Wed, 2013-02-06 at 14:25 +0100, Martin Jansa wrote:
> * check also RSUGGESTS, RCONFLICTS, RPROVIDES, RREPLACES

These are already checked by recipe_sanity.bbclass.  There's probably no
need to check them again here.

p.
Paul Eggleton - May 2, 2013, 10:36 a.m.
On Thursday 02 May 2013 11:16:30 Phil Blundell wrote:
> On Wed, 2013-02-06 at 14:25 +0100, Martin Jansa wrote:
> > * check also RSUGGESTS, RCONFLICTS, RPROVIDES, RREPLACES
> 
> These are already checked by recipe_sanity.bbclass.  There's probably no
> need to check them again here.

recipe_sanity.bbclass doesn't get used by default - I guess you are enabling 
it explicitly? I wonder if we should either (a) move all the recipe checks to 
recipe_sanity.bbclass and enable it by default, or (b) move any currently 
there and not covered by insane.bbclass to insane.bbclass and delete 
recipe_sanity.bbclass.

Cheers,
Paul
Phil Blundell - May 2, 2013, 10:59 a.m.
On Thu, 2013-05-02 at 11:36 +0100, Paul Eggleton wrote:
> On Thursday 02 May 2013 11:16:30 Phil Blundell wrote:
> > On Wed, 2013-02-06 at 14:25 +0100, Martin Jansa wrote:
> > > * check also RSUGGESTS, RCONFLICTS, RPROVIDES, RREPLACES
> > 
> > These are already checked by recipe_sanity.bbclass.  There's probably no
> > need to check them again here.
> 
> recipe_sanity.bbclass doesn't get used by default - I guess you are enabling 
> it explicitly?

Yeah, or rather, it's used by default in meta-micro.

> I wonder if we should either (a) move all the recipe checks to 
> recipe_sanity.bbclass and enable it by default, or (b) move any currently 
> there and not covered by insane.bbclass to insane.bbclass and delete 
> recipe_sanity.bbclass.

Either of those sounds reasonable enough to me.  I think the original
concept was that recipe_sanity was for errors that you could identify
statically at recipe parse time, and insane.bbclass was for checks
against the output artifacts (that you could only do after compiling and
packaging) but that line does seem to have gotten a bit blurred over
time.

p.

Patch

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index 58fc70c..d285e56 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -908,7 +908,7 @@  python () {
 
     issues = []
     if (d.getVar('PACKAGES', True) or "").split():
-        for var in 'RDEPENDS', 'RRECOMMENDS', 'FILES', 'pkg_preinst', 'pkg_postinst', 'pkg_prerm', 'pkg_postrm':
+        for var in 'RDEPENDS', 'RRECOMMENDS', 'RSUGGESTS', 'RCONFLICTS', 'RPROVIDES', 'RREPLACES', 'FILES', 'pkg_preinst', 'pkg_postinst', 'pkg_prerm', 'pkg_postrm':
             if d.getVar(var):
                 issues.append(var)
     for i in issues: