Patchwork [5/8] busybox: add ifup's ifstate dir to package

login
register
mail settings
Submitter Bernhard Reutner-Fischer
Date Feb. 5, 2013, 3:55 p.m.
Message ID <c4bfd1da6209da458cb0944a719801346f300dd9.1360079373.git.rep.dot.nop@gmail.com>
Download mbox | patch
Permalink /patch/44107/
State New
Headers show

Comments

Bernhard Reutner-Fischer - Feb. 5, 2013, 3:55 p.m.
ifupdown stores its ifstate into CONFIG_IFIPDOWN_IFSTATE_PATH.
Fixes:
ifup: can't open '/var/run/ifstate': No such file or directory

Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
---
 meta/recipes-core/busybox/busybox.inc |    4 ++++
 1 file changed, 4 insertions(+)
Saul Wold - Feb. 12, 2013, 5:46 a.m.
On 02/05/2013 07:55 AM, Bernhard Reutner-Fischer wrote:
> ifupdown stores its ifstate into CONFIG_IFIPDOWN_IFSTATE_PATH.
> Fixes:
> ifup: can't open '/var/run/ifstate': No such file or directory
>
> Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
> ---
>   meta/recipes-core/busybox/busybox.inc |    4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/meta/recipes-core/busybox/busybox.inc b/meta/recipes-core/busybox/busybox.inc
> index 972e7d0..972df6d 100644
> --- a/meta/recipes-core/busybox/busybox.inc
> +++ b/meta/recipes-core/busybox/busybox.inc
> @@ -199,6 +199,10 @@ do_install () {
>                          install -m 644 ${WORKDIR}/mdev.conf ${D}${sysconfdir}/mdev.conf
>                  fi
>   	fi
> +	IFUPDOWN_IFSTATE_PATH=`awk '/^CONFIG_IFUPDOWN_IFSTATE_PATH/{split($0,x,/=/);p=x[2];gsub("\"","",p);print p;}' ${WORKDIR}/defconfig`
> +	if test -n "$IFUPDOWN_IFSTATE_PATH"; then
Should this also be ${D} in the test, other wise you might be testing 
the host!


Sau!

> +		install -m 0755 -d ${D}/"$IFUPDOWN_IFSTATE_PATH"
> +	fi
>   	install -m 0644 ${S}/busybox.links ${D}${sysconfdir}
>   }
>
>
Bernhard Reutner-Fischer - Feb. 12, 2013, 9:14 a.m.
On Mon, Feb 11, 2013 at 09:46:31PM -0800, Saul Wold wrote:
>On 02/05/2013 07:55 AM, Bernhard Reutner-Fischer wrote:
>>ifupdown stores its ifstate into CONFIG_IFIPDOWN_IFSTATE_PATH.
>>Fixes:
>>ifup: can't open '/var/run/ifstate': No such file or directory
>>
>>Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
>>---
>>  meta/recipes-core/busybox/busybox.inc |    4 ++++
>>  1 file changed, 4 insertions(+)
>>
>>diff --git a/meta/recipes-core/busybox/busybox.inc b/meta/recipes-core/busybox/busybox.inc
>>index 972e7d0..972df6d 100644
>>--- a/meta/recipes-core/busybox/busybox.inc
>>+++ b/meta/recipes-core/busybox/busybox.inc
>>@@ -199,6 +199,10 @@ do_install () {
>>                         install -m 644 ${WORKDIR}/mdev.conf ${D}${sysconfdir}/mdev.conf
>>                 fi
>>  	fi
>>+	IFUPDOWN_IFSTATE_PATH=`awk '/^CONFIG_IFUPDOWN_IFSTATE_PATH/{split($0,x,/=/);p=x[2];gsub("\"","",p);print p;}' ${WORKDIR}/defconfig`
>>+	if test -n "$IFUPDOWN_IFSTATE_PATH"; then
>Should this also be ${D} in the test, other wise you might be testing
>the host!

WORKDIR is correct, see meta/conf/bitbake.conf setting WORKDIR.
thanks,
>
>
>Sau!
>
>>+		install -m 0755 -d ${D}/"$IFUPDOWN_IFSTATE_PATH"
>>+	fi
>>  	install -m 0644 ${S}/busybox.links ${D}${sysconfdir}
>>  }
>>
>>

Patch

diff --git a/meta/recipes-core/busybox/busybox.inc b/meta/recipes-core/busybox/busybox.inc
index 972e7d0..972df6d 100644
--- a/meta/recipes-core/busybox/busybox.inc
+++ b/meta/recipes-core/busybox/busybox.inc
@@ -199,6 +199,10 @@  do_install () {
                        install -m 644 ${WORKDIR}/mdev.conf ${D}${sysconfdir}/mdev.conf
                fi
 	fi
+	IFUPDOWN_IFSTATE_PATH=`awk '/^CONFIG_IFUPDOWN_IFSTATE_PATH/{split($0,x,/=/);p=x[2];gsub("\"","",p);print p;}' ${WORKDIR}/defconfig`
+	if test -n "$IFUPDOWN_IFSTATE_PATH"; then
+		install -m 0755 -d ${D}/"$IFUPDOWN_IFSTATE_PATH"
+	fi
 	install -m 0644 ${S}/busybox.links ${D}${sysconfdir}
 }