Patchwork [meta-oe,meta-systemd] wpa-supplicant: Add bbappend to package systemd service in a -systemd package

login
register
mail settings
Submitter Andrei Gherzan
Date Feb. 5, 2013, 11:02 a.m.
Message ID <1360062139-10894-1-git-send-email-andrei.gherzan@windriver.com>
Download mbox | patch
Permalink /patch/44091/
State New, archived
Headers show

Comments

Andrei Gherzan - Feb. 5, 2013, 11:02 a.m.
Signed-off-by: Andrei Gherzan <andrei.gherzan@windriver.com>
---
 .../wpa-supplicant/wpa-supplicant_2.0.bbappend     |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
 create mode 100644 meta-systemd/oe-core/recipes-connectivity/wpa-supplicant/wpa-supplicant_2.0.bbappend
Martin Jansa - Feb. 5, 2013, 11:22 a.m.
On Tue, Feb 05, 2013 at 01:02:19PM +0200, Andrei Gherzan wrote:
> Signed-off-by: Andrei Gherzan <andrei.gherzan@windriver.com>
> ---
>  .../wpa-supplicant/wpa-supplicant_2.0.bbappend     |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
>  create mode 100644 meta-systemd/oe-core/recipes-connectivity/wpa-supplicant/wpa-supplicant_2.0.bbappend
> 
> diff --git a/meta-systemd/oe-core/recipes-connectivity/wpa-supplicant/wpa-supplicant_2.0.bbappend b/meta-systemd/oe-core/recipes-connectivity/wpa-supplicant/wpa-supplicant_2.0.bbappend
> new file mode 100644
> index 0000000..d286689
> --- /dev/null
> +++ b/meta-systemd/oe-core/recipes-connectivity/wpa-supplicant/wpa-supplicant_2.0.bbappend
> @@ -0,0 +1,7 @@
> +PRINC := "${@int(PRINC) + 1}"
> +
> +inherit systemd
> +
> +SYSTEMD_PACKAGES = "${PN}-systemd"
> +SYSTEMD_SERVICE = "wpa_supplicant.service"
> +SYSTEMD_AUTO_ENABLE = "disable"

oe-core wpa-supplicant now installs wpa_supplicant.service to PN, is
this SYSTEMD_PACKAGES correct now?

http://lists.linuxtogo.org/pipermail/openembedded-devel/2013-January/043675.html
Andreas Müller - Feb. 5, 2013, 11:49 a.m.
On Tue, Feb 5, 2013 at 12:22 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Tue, Feb 05, 2013 at 01:02:19PM +0200, Andrei Gherzan wrote:
>> Signed-off-by: Andrei Gherzan <andrei.gherzan@windriver.com>
>> ---
>>  .../wpa-supplicant/wpa-supplicant_2.0.bbappend     |    7 +++++++
>>  1 files changed, 7 insertions(+), 0 deletions(-)
>>  create mode 100644 meta-systemd/oe-core/recipes-connectivity/wpa-supplicant/wpa-supplicant_2.0.bbappend
>
> oe-core wpa-supplicant now installs wpa_supplicant.service to PN, is
> this SYSTEMD_PACKAGES correct now?
>
> http://lists.linuxtogo.org/pipermail/openembedded-devel/2013-January/043675.html
>
> --
oe-core has set facts. The decision systemd or not is made by
DISTRO_FEATURE. I think we have to follow that (=let meta-systemd die)
to avoid two concurrent systemd enable mechanisms.

Andreas
Andrei Gherzan - Feb. 5, 2013, 12:04 p.m.
On Tue, Feb 05, 2013 at 12:49:43PM +0100, Andreas Müller wrote:
> On Tue, Feb 5, 2013 at 12:22 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> > On Tue, Feb 05, 2013 at 01:02:19PM +0200, Andrei Gherzan wrote:
> >> Signed-off-by: Andrei Gherzan <andrei.gherzan@windriver.com>
> >> ---
> >>  .../wpa-supplicant/wpa-supplicant_2.0.bbappend     |    7 +++++++
> >>  1 files changed, 7 insertions(+), 0 deletions(-)
> >>  create mode 100644 meta-systemd/oe-core/recipes-connectivity/wpa-supplicant/wpa-supplicant_2.0.bbappend
> >
> > oe-core wpa-supplicant now installs wpa_supplicant.service to PN, is
> > this SYSTEMD_PACKAGES correct now?
> >

Hmm... don't really understand your question. I know the service is installed in
PN and by using SYSTEMD_PACKAGES="${PN}-systemd" I actually move that
service in ${PN}-systemd.

> > http://lists.linuxtogo.org/pipermail/openembedded-devel/2013-January/043675.html
> >
> > --
> oe-core has set facts. The decision systemd or not is made by
> DISTRO_FEATURE. I think we have to follow that (=let meta-systemd die)
> to avoid two concurrent systemd enable mechanisms.

I understand this and makes sense. But still, systemd services should be in a
systemd package. Will resend this to oe-core.

--
Andrei Gherzan | Wind River Systems
m: +40 734 450 615 | p: +40 236 320 307
Andreas Müller - Feb. 5, 2013, 12:29 p.m.
On Tue, Feb 5, 2013 at 1:04 PM, Andrei Gherzan
<andrei.gherzan@windriver.com> wrote:
> On Tue, Feb 05, 2013 at 12:49:43PM +0100, Andreas Müller wrote:
>> On Tue, Feb 5, 2013 at 12:22 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
>> > On Tue, Feb 05, 2013 at 01:02:19PM +0200, Andrei Gherzan wrote:
>> >> Signed-off-by: Andrei Gherzan <andrei.gherzan@windriver.com>
>> >> ---
>> >>  .../wpa-supplicant/wpa-supplicant_2.0.bbappend     |    7 +++++++
>> >>  1 files changed, 7 insertions(+), 0 deletions(-)
>> >>  create mode 100644 meta-systemd/oe-core/recipes-connectivity/wpa-supplicant/wpa-supplicant_2.0.bbappend
>> >
>> > oe-core wpa-supplicant now installs wpa_supplicant.service to PN, is
>> > this SYSTEMD_PACKAGES correct now?
>> >
>
> Hmm... don't really understand your question. I know the service is installed in
> PN and by using SYSTEMD_PACKAGES="${PN}-systemd" I actually move that
> service in ${PN}-systemd.
>
>> > http://lists.linuxtogo.org/pipermail/openembedded-devel/2013-January/043675.html
>> >
>> > --
>> oe-core has set facts. The decision systemd or not is made by
>> DISTRO_FEATURE. I think we have to follow that (=let meta-systemd die)
>> to avoid two concurrent systemd enable mechanisms.
>
> I understand this and makes sense. But still, systemd services should be in a
> systemd package. Will resend this to oe-core.
>
Good luck :))

Andreas

Patch

diff --git a/meta-systemd/oe-core/recipes-connectivity/wpa-supplicant/wpa-supplicant_2.0.bbappend b/meta-systemd/oe-core/recipes-connectivity/wpa-supplicant/wpa-supplicant_2.0.bbappend
new file mode 100644
index 0000000..d286689
--- /dev/null
+++ b/meta-systemd/oe-core/recipes-connectivity/wpa-supplicant/wpa-supplicant_2.0.bbappend
@@ -0,0 +1,7 @@ 
+PRINC := "${@int(PRINC) + 1}"
+
+inherit systemd
+
+SYSTEMD_PACKAGES = "${PN}-systemd"
+SYSTEMD_SERVICE = "wpa_supplicant.service"
+SYSTEMD_AUTO_ENABLE = "disable"