Patchwork [04/17] insane.bbclass: Fix incorrect getVar call

login
register
mail settings
Submitter Richard Purdie
Date Jan. 30, 2013, 2 p.m.
Message ID <4752c8b6168ac019fec3a1a7264765a81c30df07.1359554291.git.richard.purdie@linuxfoundation.org>
Download mbox | patch
Permalink /patch/43697/
State Accepted
Commit 643bac1e97239508d5dd3fe3092410bc72ce4c81
Headers show

Comments

Richard Purdie - Jan. 30, 2013, 2 p.m.
On a trace I was a bit puzzled why getVar was making 180 calls to len(d).
This is an expensive operation that should be very rarely called and
certainly not by getVar. In perl's do_package it was resulting in
~1.5 million function calls from those 180 cases.

Ultimately this typo was why. Lets fix it and save the CPU cyles.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/classes/insane.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index c5c84b8..015abd5 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -404,7 +404,7 @@  def package_qa_check_arch(path,name,d, elf, messages):
 
     target_os   = d.getVar('TARGET_OS', True)
     target_arch = d.getVar('TARGET_ARCH', True)
-    provides = d.getVar('PROVIDES', d, True)
+    provides = d.getVar('PROVIDES', True)
     bpn = d.getVar('BPN', True)
 
     # FIXME: Cross package confuse this check, so just skip them