Patchwork [17/17] directfb: Explictly disable mesa

login
register
mail settings
Submitter Richard Purdie
Date Jan. 30, 2013, 2:01 p.m.
Message ID <c9683f65462fdbe2c0f3034f1740fd6bad721bf4.1359554291.git.richard.purdie@linuxfoundation.org>
Download mbox | patch
Permalink /patch/43689/
State New
Headers show

Comments

Richard Purdie - Jan. 30, 2013, 2:01 p.m.
Without this, directfb might build with mesa enabled if present.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-graphics/directfb/directfb.inc |    1 +
 1 file changed, 1 insertion(+)
Richard Purdie - Jan. 30, 2013, 2:52 p.m.
On Wed, 2013-01-30 at 09:43 -0500, Ian Geiser wrote:
> > -----Original Message-----
> > From: openembedded-core-bounces@lists.openembedded.org
> > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> > Richard Purdie
> > Sent: Wednesday, January 30, 2013 9:01 AM
> > To: openembedded-core@lists.openembedded.org
> > Subject: [OE-core] [PATCH 17/17] directfb: Explictly disable mesa
> > 
> > Without this, directfb might build with mesa enabled if present.
> > 
> Is it possible to make this tunable?  We use directfb with the mesa
> dri drivers for opengl.  Maybe enable it only if the distro features
> contains opengl?

I'll take patches to make it controlled by PACKAGECONFIG, probably with
the default of mesa disabled for now.

For the immediate build failures it was causing I pushed a patch to make
the configure options match DEPENDS.

Cheers,

Richard
Ross Burton - Jan. 30, 2013, 2:52 p.m.
On 30 January 2013 14:43, Ian Geiser <igeiser@devonit.com> wrote:
>> Without this, directfb might build with mesa enabled if present.
>>
> Is it possible to make this tunable?  We use directfb with the mesa dri drivers for opengl.  Maybe enable it only if the distro features contains opengl?

I was just saying to Richard that if someone wants it, we can enable it.

Basing on the "opengl" distro feature makes some sense, as long as
people are aware of the interaction between directfb and opengl,
especially on platforms where Mesa may not be the GL implementation.

An alternative would be to make it a non-default PACKAGECONFIG option,
so you can enable it because you know that you have Mesa as your GL
provider.

Ross
igeiser@devonit.com - Jan. 30, 2013, 2:57 p.m.
> -----Original Message-----
> From: Burton, Ross [mailto:ross.burton@intel.com]
> Sent: Wednesday, January 30, 2013 9:53 AM
> To: Ian Geiser
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 17/17] directfb: Explictly disable mesa
> 
> On 30 January 2013 14:43, Ian Geiser <igeiser@devonit.com> wrote:
> >> Without this, directfb might build with mesa enabled if present.
> >>
> > Is it possible to make this tunable?  We use directfb with the mesa
> dri drivers for opengl.  Maybe enable it only if the distro features
> contains opengl?
> 
> I was just saying to Richard that if someone wants it, we can enable
> it.
> 
> Basing on the "opengl" distro feature makes some sense, as long as
> people are aware of the interaction between directfb and opengl,
> especially on platforms where Mesa may not be the GL implementation.
> 
> An alternative would be to make it a non-default PACKAGECONFIG option,
> so you can enable it because you know that you have Mesa as your GL
> provider.

Now that you suggest it I like the PACKAGECONFIG option because its trivial to work with from the distro without impacting other things.  It also streamlines the dependencies and configure options.  Thanks!

Patch

diff --git a/meta/recipes-graphics/directfb/directfb.inc b/meta/recipes-graphics/directfb/directfb.inc
index c9b8ff8..aecc834 100644
--- a/meta/recipes-graphics/directfb/directfb.inc
+++ b/meta/recipes-graphics/directfb/directfb.inc
@@ -31,6 +31,7 @@  EXTRA_OECONF = "\
   --enable-sdl=no \
   --enable-vnc=no \
   --disable-x11 \
+  --disable-mesa \
 "
 
 #PACKAGES_DYNAMIC += "^directfb-inputdrivers-.*"