Patchwork mtools : upgrade to 4.0.18

login
register
mail settings
Submitter Andrei Dinu
Date Jan. 28, 2013, 12:27 p.m.
Message ID <1359376066-20756-1-git-send-email-andrei.adrianx.dinu@intel.com>
Download mbox | patch
Permalink /patch/43533/
State Accepted
Commit 469bf3c58ebf153ad1829af7cf29e41e479af1d1
Headers show

Comments

Andrei Dinu - Jan. 28, 2013, 12:27 p.m.
Signed-off-by: Andrei Dinu <andrei.adrianx.dinu@intel.com>
---
 .../mtools/{mtools_4.0.17.bb => mtools_4.0.18.bb}  |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
 rename meta/recipes-devtools/mtools/{mtools_4.0.17.bb => mtools_4.0.18.bb} (86%)
Darren Hart - Jan. 28, 2013, 6:45 p.m.
Have you performed testing with the generation of live images using this
version?

Thanks,

Darren

On 01/28/2013 04:27 AM, Andrei Dinu wrote:
> Signed-off-by: Andrei Dinu <andrei.adrianx.dinu@intel.com>
> ---
>  .../mtools/{mtools_4.0.17.bb => mtools_4.0.18.bb}  |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>  rename meta/recipes-devtools/mtools/{mtools_4.0.17.bb => mtools_4.0.18.bb} (86%)
> 
> diff --git a/meta/recipes-devtools/mtools/mtools_4.0.17.bb b/meta/recipes-devtools/mtools/mtools_4.0.18.bb
> similarity index 86%
> rename from meta/recipes-devtools/mtools/mtools_4.0.17.bb
> rename to meta/recipes-devtools/mtools/mtools_4.0.18.bb
> index 5ce6c09..0f99685 100644
> --- a/meta/recipes-devtools/mtools/mtools_4.0.17.bb
> +++ b/meta/recipes-devtools/mtools/mtools_4.0.18.bb
> @@ -5,7 +5,7 @@ SECTION = "optional"
>  LICENSE = "GPLv3"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
>  
> -PR = "r1"
> +PR = "r0"
>  
>  RDEPENDS_${PN} = "glibc-gconv-ibm850"
>  RRECOMMENDS_${PN} = "\
> @@ -24,13 +24,13 @@ RRECOMMENDS_${PN} = "\
>  	glibc-gconv-ibm866 \
>  	glibc-gconv-ibm869 \
>  	"
> +SRC_URI[md5sum] = "a23646617546bf6ad56f061d8b283c85"
> +SRC_URI[sha256sum] = "59e9cf80885399c4f229e5d87e49c0c2bfeec044e1386d59fcd0b0aead6b2f85"
>  
>  SRC_URI = "${GNU_MIRROR}/mtools/mtools-${PV}.tar.bz2 \
>             file://mtools-makeinfo.patch \
>             file://no-x11.gplv3.patch"
>  
> -SRC_URI[md5sum] = "15571c615d8f75f5f6d294272f80c7fa"
> -SRC_URI[sha256sum] = "0ecc358e30a72d215b1d4c625b27e67121cd6f6075370dfb791ef2a8b980ecb6"
>  
>  inherit autotools
>  
>
Andrei Dinu - Jan. 29, 2013, 9:49 a.m.
Hello,

No, i performed only minimal testing, to see if the package is included 
and also that it works when summoned in the console. If you can tell me 
how i can test it further, i would be grateful.

Thanks,

Andrei Dinu

On 01/28/2013 08:45 PM, Darren Hart wrote:
> Have you performed testing with the generation of live images using this
> version?
>
> Thanks,
>
> Darren
>
> On 01/28/2013 04:27 AM, Andrei Dinu wrote:
>> Signed-off-by: Andrei Dinu <andrei.adrianx.dinu@intel.com>
>> ---
>>   .../mtools/{mtools_4.0.17.bb => mtools_4.0.18.bb}  |    6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>   rename meta/recipes-devtools/mtools/{mtools_4.0.17.bb => mtools_4.0.18.bb} (86%)
>>
>> diff --git a/meta/recipes-devtools/mtools/mtools_4.0.17.bb b/meta/recipes-devtools/mtools/mtools_4.0.18.bb
>> similarity index 86%
>> rename from meta/recipes-devtools/mtools/mtools_4.0.17.bb
>> rename to meta/recipes-devtools/mtools/mtools_4.0.18.bb
>> index 5ce6c09..0f99685 100644
>> --- a/meta/recipes-devtools/mtools/mtools_4.0.17.bb
>> +++ b/meta/recipes-devtools/mtools/mtools_4.0.18.bb
>> @@ -5,7 +5,7 @@ SECTION = "optional"
>>   LICENSE = "GPLv3"
>>   LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
>>   
>> -PR = "r1"
>> +PR = "r0"
>>   
>>   RDEPENDS_${PN} = "glibc-gconv-ibm850"
>>   RRECOMMENDS_${PN} = "\
>> @@ -24,13 +24,13 @@ RRECOMMENDS_${PN} = "\
>>   	glibc-gconv-ibm866 \
>>   	glibc-gconv-ibm869 \
>>   	"
>> +SRC_URI[md5sum] = "a23646617546bf6ad56f061d8b283c85"
>> +SRC_URI[sha256sum] = "59e9cf80885399c4f229e5d87e49c0c2bfeec044e1386d59fcd0b0aead6b2f85"
>>   
>>   SRC_URI = "${GNU_MIRROR}/mtools/mtools-${PV}.tar.bz2 \
>>              file://mtools-makeinfo.patch \
>>              file://no-x11.gplv3.patch"
>>   
>> -SRC_URI[md5sum] = "15571c615d8f75f5f6d294272f80c7fa"
>> -SRC_URI[sha256sum] = "0ecc358e30a72d215b1d4c625b27e67121cd6f6075370dfb791ef2a8b980ecb6"
>>   
>>   inherit autotools
>>   
>>
Darren Hart - Jan. 29, 2013, 4:46 p.m.
On 01/29/2013 01:49 AM, Andrei Dinu wrote:
> Hello,

Hi Andrei,

> No, i performed only minimal testing, to see if the package is included 
> and also that it works when summoned in the console. If you can tell me 
> how i can test it further, i would be grateful.

The mtools are used to populate the live images. Pick a BSP that
supports this format (atom-pc for example) and build the minimal image.
Then boot the resulting core-image-minimal.hddimg. You can do this with
qemu if you don't have an atom machine handy.

That would add enough confidence to bump the version for me.

--
Darren

> 
> Thanks,
> 
> Andrei Dinu
> 
> On 01/28/2013 08:45 PM, Darren Hart wrote:
>> Have you performed testing with the generation of live images using this
>> version?
>>
>> Thanks,
>>
>> Darren
>>
>> On 01/28/2013 04:27 AM, Andrei Dinu wrote:
>>> Signed-off-by: Andrei Dinu <andrei.adrianx.dinu@intel.com>
>>> ---
>>>   .../mtools/{mtools_4.0.17.bb => mtools_4.0.18.bb}  |    6 +++---
>>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>>   rename meta/recipes-devtools/mtools/{mtools_4.0.17.bb => mtools_4.0.18.bb} (86%)
>>>
>>> diff --git a/meta/recipes-devtools/mtools/mtools_4.0.17.bb b/meta/recipes-devtools/mtools/mtools_4.0.18.bb
>>> similarity index 86%
>>> rename from meta/recipes-devtools/mtools/mtools_4.0.17.bb
>>> rename to meta/recipes-devtools/mtools/mtools_4.0.18.bb
>>> index 5ce6c09..0f99685 100644
>>> --- a/meta/recipes-devtools/mtools/mtools_4.0.17.bb
>>> +++ b/meta/recipes-devtools/mtools/mtools_4.0.18.bb
>>> @@ -5,7 +5,7 @@ SECTION = "optional"
>>>   LICENSE = "GPLv3"
>>>   LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
>>>   
>>> -PR = "r1"
>>> +PR = "r0"
>>>   
>>>   RDEPENDS_${PN} = "glibc-gconv-ibm850"
>>>   RRECOMMENDS_${PN} = "\
>>> @@ -24,13 +24,13 @@ RRECOMMENDS_${PN} = "\
>>>   	glibc-gconv-ibm866 \
>>>   	glibc-gconv-ibm869 \
>>>   	"
>>> +SRC_URI[md5sum] = "a23646617546bf6ad56f061d8b283c85"
>>> +SRC_URI[sha256sum] = "59e9cf80885399c4f229e5d87e49c0c2bfeec044e1386d59fcd0b0aead6b2f85"
>>>   
>>>   SRC_URI = "${GNU_MIRROR}/mtools/mtools-${PV}.tar.bz2 \
>>>              file://mtools-makeinfo.patch \
>>>              file://no-x11.gplv3.patch"
>>>   
>>> -SRC_URI[md5sum] = "15571c615d8f75f5f6d294272f80c7fa"
>>> -SRC_URI[sha256sum] = "0ecc358e30a72d215b1d4c625b27e67121cd6f6075370dfb791ef2a8b980ecb6"
>>>   
>>>   inherit autotools
>>>   
>>>
>
Andrei Dinu - Jan. 30, 2013, 9:05 a.m.
Hi Darren,

I created an atom-pc hddimg and loaded it into qemu. The image booted 
with no errors. So everything seems to work fine. Thanks for the help!

Andrei

On 01/29/2013 06:46 PM, Darren Hart wrote:
> On 01/29/2013 01:49 AM, Andrei Dinu wrote:
>> Hello,
> Hi Andrei,
>
>> No, i performed only minimal testing, to see if the package is included
>> and also that it works when summoned in the console. If you can tell me
>> how i can test it further, i would be grateful.
> The mtools are used to populate the live images. Pick a BSP that
> supports this format (atom-pc for example) and build the minimal image.
> Then boot the resulting core-image-minimal.hddimg. You can do this with
> qemu if you don't have an atom machine handy.
>
> That would add enough confidence to bump the version for me.
>
> --
> Darren
>
>> Thanks,
>>
>> Andrei Dinu
>>
>> On 01/28/2013 08:45 PM, Darren Hart wrote:
>>> Have you performed testing with the generation of live images using this
>>> version?
>>>
>>> Thanks,
>>>
>>> Darren
>>>
>>> On 01/28/2013 04:27 AM, Andrei Dinu wrote:
>>>> Signed-off-by: Andrei Dinu <andrei.adrianx.dinu@intel.com>
>>>> ---
>>>>    .../mtools/{mtools_4.0.17.bb => mtools_4.0.18.bb}  |    6 +++---
>>>>    1 file changed, 3 insertions(+), 3 deletions(-)
>>>>    rename meta/recipes-devtools/mtools/{mtools_4.0.17.bb => mtools_4.0.18.bb} (86%)
>>>>
>>>> diff --git a/meta/recipes-devtools/mtools/mtools_4.0.17.bb b/meta/recipes-devtools/mtools/mtools_4.0.18.bb
>>>> similarity index 86%
>>>> rename from meta/recipes-devtools/mtools/mtools_4.0.17.bb
>>>> rename to meta/recipes-devtools/mtools/mtools_4.0.18.bb
>>>> index 5ce6c09..0f99685 100644
>>>> --- a/meta/recipes-devtools/mtools/mtools_4.0.17.bb
>>>> +++ b/meta/recipes-devtools/mtools/mtools_4.0.18.bb
>>>> @@ -5,7 +5,7 @@ SECTION = "optional"
>>>>    LICENSE = "GPLv3"
>>>>    LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
>>>>    
>>>> -PR = "r1"
>>>> +PR = "r0"
>>>>    
>>>>    RDEPENDS_${PN} = "glibc-gconv-ibm850"
>>>>    RRECOMMENDS_${PN} = "\
>>>> @@ -24,13 +24,13 @@ RRECOMMENDS_${PN} = "\
>>>>    	glibc-gconv-ibm866 \
>>>>    	glibc-gconv-ibm869 \
>>>>    	"
>>>> +SRC_URI[md5sum] = "a23646617546bf6ad56f061d8b283c85"
>>>> +SRC_URI[sha256sum] = "59e9cf80885399c4f229e5d87e49c0c2bfeec044e1386d59fcd0b0aead6b2f85"
>>>>    
>>>>    SRC_URI = "${GNU_MIRROR}/mtools/mtools-${PV}.tar.bz2 \
>>>>               file://mtools-makeinfo.patch \
>>>>               file://no-x11.gplv3.patch"
>>>>    
>>>> -SRC_URI[md5sum] = "15571c615d8f75f5f6d294272f80c7fa"
>>>> -SRC_URI[sha256sum] = "0ecc358e30a72d215b1d4c625b27e67121cd6f6075370dfb791ef2a8b980ecb6"
>>>>    
>>>>    inherit autotools
>>>>    
>>>>
Darren Hart - Jan. 30, 2013, 4:09 p.m.
Andrei,

There is almost ALWAYS something worth putting in the comment message.
In this case, please include your latest testing comment in your commit
message and resend with my Acked by.

On 01/28/2013 04:27 AM, Andrei Dinu wrote:
> Signed-off-by: Andrei Dinu <andrei.adrianx.dinu@intel.com>


Acked-by: Darren Hart <dvhart@linux.intel.com>


Thanks,

Darren

> ---
>  .../mtools/{mtools_4.0.17.bb => mtools_4.0.18.bb}  |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>  rename meta/recipes-devtools/mtools/{mtools_4.0.17.bb => mtools_4.0.18.bb} (86%)
> 
> diff --git a/meta/recipes-devtools/mtools/mtools_4.0.17.bb b/meta/recipes-devtools/mtools/mtools_4.0.18.bb
> similarity index 86%
> rename from meta/recipes-devtools/mtools/mtools_4.0.17.bb
> rename to meta/recipes-devtools/mtools/mtools_4.0.18.bb
> index 5ce6c09..0f99685 100644
> --- a/meta/recipes-devtools/mtools/mtools_4.0.17.bb
> +++ b/meta/recipes-devtools/mtools/mtools_4.0.18.bb
> @@ -5,7 +5,7 @@ SECTION = "optional"
>  LICENSE = "GPLv3"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
>  
> -PR = "r1"
> +PR = "r0"
>  
>  RDEPENDS_${PN} = "glibc-gconv-ibm850"
>  RRECOMMENDS_${PN} = "\
> @@ -24,13 +24,13 @@ RRECOMMENDS_${PN} = "\
>  	glibc-gconv-ibm866 \
>  	glibc-gconv-ibm869 \
>  	"
> +SRC_URI[md5sum] = "a23646617546bf6ad56f061d8b283c85"
> +SRC_URI[sha256sum] = "59e9cf80885399c4f229e5d87e49c0c2bfeec044e1386d59fcd0b0aead6b2f85"
>  
>  SRC_URI = "${GNU_MIRROR}/mtools/mtools-${PV}.tar.bz2 \
>             file://mtools-makeinfo.patch \
>             file://no-x11.gplv3.patch"
>  
> -SRC_URI[md5sum] = "15571c615d8f75f5f6d294272f80c7fa"
> -SRC_URI[sha256sum] = "0ecc358e30a72d215b1d4c625b27e67121cd6f6075370dfb791ef2a8b980ecb6"
>  
>  inherit autotools
>  
>
Andrei Dinu - Jan. 31, 2013, 11:49 a.m.
The patch was already merged into master...

Next time i will mention all the testing in the commit message.

Thanks for the heads-up!

Andrei

On 01/30/2013 06:09 PM, Darren Hart wrote:
> Andrei,
>
> There is almost ALWAYS something worth putting in the comment message.
> In this case, please include your latest testing comment in your commit
> message and resend with my Acked by.
>
> On 01/28/2013 04:27 AM, Andrei Dinu wrote:
>> Signed-off-by: Andrei Dinu <andrei.adrianx.dinu@intel.com>
>
> Acked-by: Darren Hart <dvhart@linux.intel.com>
>
>
> Thanks,
>
> Darren
>
>> ---
>>   .../mtools/{mtools_4.0.17.bb => mtools_4.0.18.bb}  |    6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>   rename meta/recipes-devtools/mtools/{mtools_4.0.17.bb => mtools_4.0.18.bb} (86%)
>>
>> diff --git a/meta/recipes-devtools/mtools/mtools_4.0.17.bb b/meta/recipes-devtools/mtools/mtools_4.0.18.bb
>> similarity index 86%
>> rename from meta/recipes-devtools/mtools/mtools_4.0.17.bb
>> rename to meta/recipes-devtools/mtools/mtools_4.0.18.bb
>> index 5ce6c09..0f99685 100644
>> --- a/meta/recipes-devtools/mtools/mtools_4.0.17.bb
>> +++ b/meta/recipes-devtools/mtools/mtools_4.0.18.bb
>> @@ -5,7 +5,7 @@ SECTION = "optional"
>>   LICENSE = "GPLv3"
>>   LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
>>   
>> -PR = "r1"
>> +PR = "r0"
>>   
>>   RDEPENDS_${PN} = "glibc-gconv-ibm850"
>>   RRECOMMENDS_${PN} = "\
>> @@ -24,13 +24,13 @@ RRECOMMENDS_${PN} = "\
>>   	glibc-gconv-ibm866 \
>>   	glibc-gconv-ibm869 \
>>   	"
>> +SRC_URI[md5sum] = "a23646617546bf6ad56f061d8b283c85"
>> +SRC_URI[sha256sum] = "59e9cf80885399c4f229e5d87e49c0c2bfeec044e1386d59fcd0b0aead6b2f85"
>>   
>>   SRC_URI = "${GNU_MIRROR}/mtools/mtools-${PV}.tar.bz2 \
>>              file://mtools-makeinfo.patch \
>>              file://no-x11.gplv3.patch"
>>   
>> -SRC_URI[md5sum] = "15571c615d8f75f5f6d294272f80c7fa"
>> -SRC_URI[sha256sum] = "0ecc358e30a72d215b1d4c625b27e67121cd6f6075370dfb791ef2a8b980ecb6"
>>   
>>   inherit autotools
>>   
>>

Patch

diff --git a/meta/recipes-devtools/mtools/mtools_4.0.17.bb b/meta/recipes-devtools/mtools/mtools_4.0.18.bb
similarity index 86%
rename from meta/recipes-devtools/mtools/mtools_4.0.17.bb
rename to meta/recipes-devtools/mtools/mtools_4.0.18.bb
index 5ce6c09..0f99685 100644
--- a/meta/recipes-devtools/mtools/mtools_4.0.17.bb
+++ b/meta/recipes-devtools/mtools/mtools_4.0.18.bb
@@ -5,7 +5,7 @@  SECTION = "optional"
 LICENSE = "GPLv3"
 LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
 
-PR = "r1"
+PR = "r0"
 
 RDEPENDS_${PN} = "glibc-gconv-ibm850"
 RRECOMMENDS_${PN} = "\
@@ -24,13 +24,13 @@  RRECOMMENDS_${PN} = "\
 	glibc-gconv-ibm866 \
 	glibc-gconv-ibm869 \
 	"
+SRC_URI[md5sum] = "a23646617546bf6ad56f061d8b283c85"
+SRC_URI[sha256sum] = "59e9cf80885399c4f229e5d87e49c0c2bfeec044e1386d59fcd0b0aead6b2f85"
 
 SRC_URI = "${GNU_MIRROR}/mtools/mtools-${PV}.tar.bz2 \
            file://mtools-makeinfo.patch \
            file://no-x11.gplv3.patch"
 
-SRC_URI[md5sum] = "15571c615d8f75f5f6d294272f80c7fa"
-SRC_URI[sha256sum] = "0ecc358e30a72d215b1d4c625b27e67121cd6f6075370dfb791ef2a8b980ecb6"
 
 inherit autotools