Patchwork [meta-oe/meta-systemd,1/5] thunar: add RRECOMMENDS and RDEPENDS to ensure full functionality

login
register
mail settings
Submitter Andreas Müller
Date Jan. 25, 2013, 11:48 a.m.
Message ID <1359114536-3823-2-git-send-email-schnitzeltony@googlemail.com>
Download mbox | patch
Permalink /patch/43353/
State Superseded, archived
Headers show

Comments

Andreas Müller - Jan. 25, 2013, 11:48 a.m.
Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
---
 meta-xfce/recipes-xfce/thunar/thunar_1.6.2.bb |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
Martin Jansa - Jan. 25, 2013, 12:02 p.m.
On Fri, Jan 25, 2013 at 12:48:52PM +0100, Andreas Müller wrote:
> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
> ---
>  meta-xfce/recipes-xfce/thunar/thunar_1.6.2.bb |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/meta-xfce/recipes-xfce/thunar/thunar_1.6.2.bb b/meta-xfce/recipes-xfce/thunar/thunar_1.6.2.bb
> index 55b54d4..aec2db1 100644
> --- a/meta-xfce/recipes-xfce/thunar/thunar_1.6.2.bb
> +++ b/meta-xfce/recipes-xfce/thunar/thunar_1.6.2.bb
> @@ -3,6 +3,7 @@ SECTION = "x11"
>  LICENSE = "GPLv2"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
>  DEPENDS = "exo glib-2.0 gtk+ gdk-pixbuf libxfce4util libxfce4ui libsm dbus-glib startup-notification libnotify xfce4-panel"
> +PR = "r1"
>  
>  inherit xfce
>  
> @@ -22,3 +23,7 @@ FILES_${PN} += "${libdir}/thunarx-2/* \
>  FILES_${PN}-dbg += "${libdir}/thunarx-2/.debug/ \
>                      ${libdir}/xfce4/panel/plugins/.debug/ \
>                      ${libdir}/Thunar/.debug/"
> +
> +# RRECOMMENDS does not drag in charmaps (tested with opkg)
> +RDEPENDS_${PN} = "eglibc-charmaps"

what about uclibc builds?

> +RRECOMMENDS_${PN} = "gvfs gvfsd-trash udisks"
> -- 
> 1.7.6.5
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Andreas Müller - Jan. 25, 2013, 1:09 p.m.
On Fri, Jan 25, 2013 at 1:02 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Fri, Jan 25, 2013 at 12:48:52PM +0100, Andreas Müller wrote:
>> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
>> ---
>>  meta-xfce/recipes-xfce/thunar/thunar_1.6.2.bb |    5 +++++
>>  1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/meta-xfce/recipes-xfce/thunar/thunar_1.6.2.bb b/meta-xfce/recipes-xfce/thunar/thunar_1.6.2.bb
>> index 55b54d4..aec2db1 100644
>> --- a/meta-xfce/recipes-xfce/thunar/thunar_1.6.2.bb
>> +++ b/meta-xfce/recipes-xfce/thunar/thunar_1.6.2.bb
>> @@ -3,6 +3,7 @@ SECTION = "x11"
>>  LICENSE = "GPLv2"
>>  LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
>>  DEPENDS = "exo glib-2.0 gtk+ gdk-pixbuf libxfce4util libxfce4ui libsm dbus-glib startup-notification libnotify xfce4-panel"
>> +PR = "r1"
>>
>>  inherit xfce
>>
>> @@ -22,3 +23,7 @@ FILES_${PN} += "${libdir}/thunarx-2/* \
>>  FILES_${PN}-dbg += "${libdir}/thunarx-2/.debug/ \
>>                      ${libdir}/xfce4/panel/plugins/.debug/ \
>>                      ${libdir}/Thunar/.debug/"
>> +
>> +# RRECOMMENDS does not drag in charmaps (tested with opkg)
>> +RDEPENDS_${PN} = "eglibc-charmaps"
>
> what about uclibc builds?
Good point - I forgot to remove it does not fix my password problem in
win environments anyway. Will send V2 later this evening.

Andreas

Patch

diff --git a/meta-xfce/recipes-xfce/thunar/thunar_1.6.2.bb b/meta-xfce/recipes-xfce/thunar/thunar_1.6.2.bb
index 55b54d4..aec2db1 100644
--- a/meta-xfce/recipes-xfce/thunar/thunar_1.6.2.bb
+++ b/meta-xfce/recipes-xfce/thunar/thunar_1.6.2.bb
@@ -3,6 +3,7 @@  SECTION = "x11"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
 DEPENDS = "exo glib-2.0 gtk+ gdk-pixbuf libxfce4util libxfce4ui libsm dbus-glib startup-notification libnotify xfce4-panel"
+PR = "r1"
 
 inherit xfce
 
@@ -22,3 +23,7 @@  FILES_${PN} += "${libdir}/thunarx-2/* \
 FILES_${PN}-dbg += "${libdir}/thunarx-2/.debug/ \
                     ${libdir}/xfce4/panel/plugins/.debug/ \
                     ${libdir}/Thunar/.debug/"
+
+# RRECOMMENDS does not drag in charmaps (tested with opkg)
+RDEPENDS_${PN} = "eglibc-charmaps"
+RRECOMMENDS_${PN} = "gvfs gvfsd-trash udisks"