Patchwork systemd: remove usbutils dependancy

login
register
mail settings
Submitter ml@communistcode.co.uk
Date Jan. 24, 2013, 10:44 a.m.
Message ID <1359024278-24627-1-git-send-email-ml@communistcode.co.uk>
Download mbox | patch
Permalink /patch/43289/
State New
Headers show

Comments

ml@communistcode.co.uk - Jan. 24, 2013, 10:44 a.m.
From: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>

No where in the systemd readme does it specify that usbutils
is a dependancy of systemd. I can only guess that it was added
due to an issue elsewhere in the chain or it was brought in
when udev was merged and the dependancies never checked.

I have build tested this with no issues.

Signed-off-by: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
---
 meta/recipes-core/systemd/systemd_196.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Ross Burton - Jan. 24, 2013, 12:02 p.m.
On 24 January 2013 10:44,  <ml@communistcode.co.uk> wrote:
> No where in the systemd readme does it specify that usbutils
> is a dependancy of systemd. I can only guess that it was added
> due to an issue elsewhere in the chain or it was brought in
> when udev was merged and the dependancies never checked.
>
> I have build tested this with no issues.

Build-tested from a clean sysroot?

Ross
Martin Jansa - Jan. 24, 2013, 12:26 p.m.
On Thu, Jan 24, 2013 at 10:44:38AM +0000, ml@communistcode.co.uk wrote:
> From: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
> 
> No where in the systemd readme does it specify that usbutils
> is a dependancy of systemd. I can only guess that it was added
> due to an issue elsewhere in the chain or it was brought in
> when udev was merged and the dependancies never checked.

It was needed for older systemd revisions:
http://git.openembedded.org/meta-openembedded/commit/?id=ec2459251c68bb090c8b6f0d6cbf5ea0c2486337

http://cgit.freedesktop.org/systemd/systemd/tree/configure.ac?id=cd96b3b86abb4a88cac2722bdfb6e5d4413f6831

And removed between 195 and 196:
http://cgit.freedesktop.org/systemd/systemd/commit/configure.ac?id=796b06c21b62d13c9021e2fbd9c58a5c6edb2764

Please update commit message.
 
> I have build tested this with no issues.
> 
> Signed-off-by: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
> ---
>  meta/recipes-core/systemd/systemd_196.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-core/systemd/systemd_196.bb b/meta/recipes-core/systemd/systemd_196.bb
> index a78a8a6..9eca25b 100644
> --- a/meta/recipes-core/systemd/systemd_196.bb
> +++ b/meta/recipes-core/systemd/systemd_196.bb
> @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://LICENSE.GPL2;md5=751419260aa954499f7abaabaa882bbe \
>  
>  PROVIDES = "udev"
>  
> -DEPENDS = "xz kmod docbook-sgml-dtd-4.1-native intltool-native gperf-native acl readline dbus libcap libcgroup tcp-wrappers usbutils glib-2.0 libgcrypt"
> +DEPENDS = "xz kmod docbook-sgml-dtd-4.1-native intltool-native gperf-native acl readline dbus libcap libcgroup tcp-wrappers glib-2.0 libgcrypt"
>  DEPENDS += "${@base_contains('DISTRO_FEATURES', 'pam', 'libpam', '', d)}"
>  
>  SECTION = "base/shell"
> -- 
> 1.8.1.1
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-core/systemd/systemd_196.bb b/meta/recipes-core/systemd/systemd_196.bb
index a78a8a6..9eca25b 100644
--- a/meta/recipes-core/systemd/systemd_196.bb
+++ b/meta/recipes-core/systemd/systemd_196.bb
@@ -8,7 +8,7 @@  LIC_FILES_CHKSUM = "file://LICENSE.GPL2;md5=751419260aa954499f7abaabaa882bbe \
 
 PROVIDES = "udev"
 
-DEPENDS = "xz kmod docbook-sgml-dtd-4.1-native intltool-native gperf-native acl readline dbus libcap libcgroup tcp-wrappers usbutils glib-2.0 libgcrypt"
+DEPENDS = "xz kmod docbook-sgml-dtd-4.1-native intltool-native gperf-native acl readline dbus libcap libcgroup tcp-wrappers glib-2.0 libgcrypt"
 DEPENDS += "${@base_contains('DISTRO_FEATURES', 'pam', 'libpam', '', d)}"
 
 SECTION = "base/shell"