Patchwork [12/12] dbus: inherit volatiles to support read-only rootfs

login
mail settings
Submitter Qi.Chen@windriver.com
Date Jan. 24, 2013, 8:16 a.m.
Message ID <dc49f51db3966ad18b51e6c8c10ee792db58bbc0.1359014474.git.Qi.Chen@windriver.com>
Download mbox | patch
Permalink /patch/43271/
State New
Headers show

Comments

Qi.Chen@windriver.com - Jan. 24, 2013, 8:16 a.m.
From: Chen Qi <Qi.Chen@windriver.com>

Inherit volatiles.bbclass to support read-only rootfs.

[YOCTO #3406]

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 meta/recipes-core/dbus/dbus.inc |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
Ross Burton - Jan. 24, 2013, 10:45 a.m.
On 24 January 2013 08:16,  <Qi.Chen@windriver.com> wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
>
> Inherit volatiles.bbclass to support read-only rootfs.

Please explain why DBus needs volatiles.bbclass to support a readonly
rootfs.  Presumably it's because the machine UUID is written to
/var/lib, are there any other reasons?

Ross
Qi.Chen@windriver.com - Jan. 25, 2013, 3:05 a.m.
On 01/24/2013 06:45 PM, Burton, Ross wrote:
> On 24 January 2013 08:16,  <Qi.Chen@windriver.com> wrote:
>> From: Chen Qi <Qi.Chen@windriver.com>
>>
>> Inherit volatiles.bbclass to support read-only rootfs.
> Please explain why DBus needs volatiles.bbclass to support a readonly
> rootfs.  Presumably it's because the machine UUID is written to
> /var/lib, are there any other reasons?
>
> Ross
>
>
I added this patch because I encountered an error when starting the sato 
image.
That is, the machine UUID needs to be written to /var/lib.

I'm not familiar with dbus. Is it not necessary?

Thanks,
Chen Qi
Ross Burton - Jan. 25, 2013, 1:02 p.m.
On 25 January 2013 03:05, ChenQi <Qi.Chen@windriver.com> wrote:
> I added this patch because I encountered an error when starting the sato
> image.
> That is, the machine UUID needs to be written to /var/lib.
>
> I'm not familiar with dbus. Is it not necessary?

The file is necessary and needs to be persistent for at least the
lifetime of a boot, so generating it on dbus startup and writing to a
tmpfs is fine.

My point was that the commit doesn't say *why* it does what it does.

Ross

Patch

diff --git a/meta/recipes-core/dbus/dbus.inc b/meta/recipes-core/dbus/dbus.inc
index 88218b7..f614285 100644
--- a/meta/recipes-core/dbus/dbus.inc
+++ b/meta/recipes-core/dbus/dbus.inc
@@ -12,17 +12,20 @@  DEPENDS_class-nativesdk = "nativesdk-expat virtual/nativesdk-libintl virtual/lib
 RDEPENDS_dbus = "${@base_contains('DISTRO_FEATURES', 'ptest', 'dbus-ptest', '', d)}"
 RDEPENDS_class-native = ""
 
-INC_PR = "r5"
+INC_PR = "r6"
 
 SRC_URI = "http://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz \
            file://tmpdir.patch; \
            file://dbus-1.init"
 
-inherit useradd autotools pkgconfig gettext update-rc.d
+inherit useradd autotools pkgconfig gettext update-rc.d volatiles
 
 INITSCRIPT_NAME = "dbus-1"
 INITSCRIPT_PARAMS = "start 02 5 3 2 . stop 20 0 1 6 ."
 
+VOLATILE_DIR = "/var/volatile/lib/dbus"
+VOLATILE_LINK = "/var/lib/dbus"
+
 USERADD_PACKAGES = "${PN}"
 GROUPADD_PARAM_${PN} = "-r netdev"
 USERADD_PARAM_${PN} = "--system --home ${localstatedir}/lib/dbus \