Patchwork [meta-oe,meta-networking,meta-xfce,4/4] autofs: fix QA warnings

login
register
mail settings
Submitter Martin Jansa
Date Jan. 22, 2013, 12:20 p.m.
Message ID <1358857259-11444-4-git-send-email-Martin.Jansa@gmail.com>
Download mbox | patch
Permalink /patch/43181/
State Accepted, archived
Commit 3409e2ff98cdd48e70ebf027e40b8b936cdab919
Headers show

Comments

Martin Jansa - Jan. 22, 2013, 12:20 p.m.
autofs-5.0.7: autofs: Files/directories were installed but not shipped
  /run

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta-networking/recipes-daemons/autofs/autofs_5.0.7.bb | 4 ++++
 1 file changed, 4 insertions(+)
Joe MacDonald - Jan. 22, 2013, 1:04 p.m.
[[oe] [PATCH][meta-oe][meta-networking][meta-xfce 4/4] autofs: fix QA warnings] On 13.01.22 (Tue 13:20) Martin Jansa wrote:

> autofs-5.0.7: autofs: Files/directories were installed but not shipped
>   /run
> 
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Joe MacDonald <joe.macdonald@windriver.com>
> ---
>  meta-networking/recipes-daemons/autofs/autofs_5.0.7.bb | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/meta-networking/recipes-daemons/autofs/autofs_5.0.7.bb b/meta-networking/recipes-daemons/autofs/autofs_5.0.7.bb
> index bf679b4..2bf03f1 100644
> --- a/meta-networking/recipes-daemons/autofs/autofs_5.0.7.bb
> +++ b/meta-networking/recipes-daemons/autofs/autofs_5.0.7.bb
> @@ -60,4 +60,8 @@ do_configure_prepend () {
>          fi
>  }
>  
> +do_install_append () {
> +	test -d ${D}/run && rmdir ${D}/run
> +}
> +
>  INSANE_SKIP_${PN} = "dev-so"
Koen Kooi - Jan. 22, 2013, 3:04 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 22-01-13 13:20, Martin Jansa schreef:
> autofs-5.0.7: autofs: Files/directories were installed but not shipped 
> /run
> 
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> --- 
> meta-networking/recipes-daemons/autofs/autofs_5.0.7.bb | 4 ++++ 1 file
> changed, 4 insertions(+)
> 
> diff --git a/meta-networking/recipes-daemons/autofs/autofs_5.0.7.bb
> b/meta-networking/recipes-daemons/autofs/autofs_5.0.7.bb index
> bf679b4..2bf03f1 100644 ---
> a/meta-networking/recipes-daemons/autofs/autofs_5.0.7.bb +++
> b/meta-networking/recipes-daemons/autofs/autofs_5.0.7.bb @@ -60,4 +60,8
> @@ do_configure_prepend () { fi }
> 
> +do_install_append () { +	test -d ${D}/run && rmdir ${D}/run +} + 
> INSANE_SKIP_${PN} = "dev-so"

Missing PR bump

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFQ/qqEMkyGM64RGpERAuF8AJ9kNFy6oQXbe1cySl2hM0SuRUk7iACePGXu
A/vSJ0gXV94w4hKLsTVgBLc=
=G2ge
-----END PGP SIGNATURE-----
Martin Jansa - Jan. 22, 2013, 3:44 p.m.
On Tue, Jan 22, 2013 at 04:04:36PM +0100, Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Op 22-01-13 13:20, Martin Jansa schreef:
> > autofs-5.0.7: autofs: Files/directories were installed but not shipped 
> > /run
> > 
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> --- 
> > meta-networking/recipes-daemons/autofs/autofs_5.0.7.bb | 4 ++++ 1 file
> > changed, 4 insertions(+)
> > 
> > diff --git a/meta-networking/recipes-daemons/autofs/autofs_5.0.7.bb
> > b/meta-networking/recipes-daemons/autofs/autofs_5.0.7.bb index
> > bf679b4..2bf03f1 100644 ---
> > a/meta-networking/recipes-daemons/autofs/autofs_5.0.7.bb +++
> > b/meta-networking/recipes-daemons/autofs/autofs_5.0.7.bb @@ -60,4 +60,8
> > @@ do_configure_prepend () { fi }
> > 
> > +do_install_append () { +	test -d ${D}/run && rmdir ${D}/run +} + 
> > INSANE_SKIP_${PN} = "dev-so"
> 
> Missing PR bump

I know, but oe-core changes are now applied without PR bumps too and
upgrade paths are broken without PR service at least since Christmas..

So is it still worth it?

Cheers,
Koen Kooi - Jan. 22, 2013, 4:01 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 22-01-13 16:44, Martin Jansa schreef:
> On Tue, Jan 22, 2013 at 04:04:36PM +0100, Koen Kooi wrote:
>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
>> 
>> Op 22-01-13 13:20, Martin Jansa schreef:
>>> autofs-5.0.7: autofs: Files/directories were installed but not
>>> shipped /run
>>> 
>>> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> --- 
>>> meta-networking/recipes-daemons/autofs/autofs_5.0.7.bb | 4 ++++ 1
>>> file changed, 4 insertions(+)
>>> 
>>> diff --git a/meta-networking/recipes-daemons/autofs/autofs_5.0.7.bb 
>>> b/meta-networking/recipes-daemons/autofs/autofs_5.0.7.bb index 
>>> bf679b4..2bf03f1 100644 --- 
>>> a/meta-networking/recipes-daemons/autofs/autofs_5.0.7.bb +++ 
>>> b/meta-networking/recipes-daemons/autofs/autofs_5.0.7.bb @@ -60,4
>>> +60,8 @@ do_configure_prepend () { fi }
>>> 
>>> +do_install_append () { +	test -d ${D}/run && rmdir ${D}/run +} + 
>>> INSANE_SKIP_${PN} = "dev-so"
>> 
>> Missing PR bump
> 
> I know, but oe-core changes are now applied without PR bumps too and 
> upgrade paths are broken without PR service at least since Christmas..
> 
> So is it still worth it?

Only if they get cherry-picked into danny or denzil, but I guess we can add
PR bump commits for those manually.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFQ/rfpMkyGM64RGpERArM8AJ916LgEAnHbjIjV4V362hD/agOYUQCggW1E
eS/pzybz5fL46MSf7BR7LFE=
=WYYt
-----END PGP SIGNATURE-----

Patch

diff --git a/meta-networking/recipes-daemons/autofs/autofs_5.0.7.bb b/meta-networking/recipes-daemons/autofs/autofs_5.0.7.bb
index bf679b4..2bf03f1 100644
--- a/meta-networking/recipes-daemons/autofs/autofs_5.0.7.bb
+++ b/meta-networking/recipes-daemons/autofs/autofs_5.0.7.bb
@@ -60,4 +60,8 @@  do_configure_prepend () {
         fi
 }
 
+do_install_append () {
+	test -d ${D}/run && rmdir ${D}/run
+}
+
 INSANE_SKIP_${PN} = "dev-so"