| Submitter | Constantin Musca |
|---|---|
| Date | Jan. 18, 2013, 11:48 a.m. |
| Message ID | <3e9e32d745fa7a228acfcc04aac62e084e0540cd.1358509450.git.constantinx.musca@intel.com> |
| Download | mbox | patch |
| Permalink | /patch/42869/ |
| State | New |
| Headers | show |
Comments
On Fri, Jan 18, 2013 at 01:48:29PM +0200, Constantin Musca wrote: > - DirectFB is not supported by gtk versions >= 2.18 > - remove the backwards compatibility statements (packagegroup-core-directfb > is an independent packagegroup) And what will happen with task-core-gtk-directfb-base/ packagegroup-core-gtk-directfb packages already installed on targets? It's also possible that someone still with task-core-gtk-directfb-base will decide that now it's right time to do upgrade.. Cheers, > - remove all gtk dependencies > > [YOCTO #3642] > > Signed-off-by: Constantin Musca <constantinx.musca@intel.com> > --- > ...oup-core-gtk-directfb.bb => packagegroup-core-directfb.bb} | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) > rename meta/recipes-graphics/packagegroups/{packagegroup-core-gtk-directfb.bb => packagegroup-core-directfb.bb} (49%) > > diff --git a/meta/recipes-graphics/packagegroups/packagegroup-core-gtk-directfb.bb b/meta/recipes-graphics/packagegroups/packagegroup-core-directfb.bb > similarity index 49% > rename from meta/recipes-graphics/packagegroups/packagegroup-core-gtk-directfb.bb > rename to meta/recipes-graphics/packagegroups/packagegroup-core-directfb.bb > index 55b0b9d..aca3a67 100644 > --- a/meta/recipes-graphics/packagegroups/packagegroup-core-gtk-directfb.bb > +++ b/meta/recipes-graphics/packagegroups/packagegroup-core-directfb.bb > @@ -1,14 +1,9 @@ > -SUMMARY = "GTK+ over DirectFB without X11" > -PR = "r1" > +SUMMARY = "DirectFB without X11" > +PR = "r0" > LICENSE = "MIT" > > inherit packagegroup > > -# For backwards compatibility after rename > -RPROVIDES_${PN} = "task-core-gtk-directfb-base" > -RREPLACES_${PN} = "task-core-gtk-directfb-base" > -RCONFLICTS_${PN} = "task-core-gtk-directfb-base" > - > TOUCH = ' ${@base_contains("MACHINE_FEATURES", "touchscreen", "tslib tslib-calibrate tslib-tests", "",d)}' > > RDEPENDS_${PN} = " \ > @@ -17,7 +12,5 @@ RDEPENDS_${PN} = " \ > pango \ > pango-modules \ > fontconfig \ > - gtk+ \ > - gtk-demo \ > ${TOUCH} \ > " > -- > 1.7.11.7 > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
On 18 January 2013 12:23, Martin Jansa <martin.jansa@gmail.com> wrote: > It's also possible that someone still with task-core-gtk-directfb-base > will decide that now it's right time to do upgrade.. And if they get a seamless upgrade to packagegroup-core-directfb which doesn't have GTK+, they'll be quite surprised. The contents of the group changed, and not in a trivial manner. Ross
On 01/18/2013 02:23 PM, Martin Jansa wrote: > On Fri, Jan 18, 2013 at 01:48:29PM +0200, Constantin Musca wrote: >> - DirectFB is not supported by gtk versions >= 2.18 >> - remove the backwards compatibility statements (packagegroup-core-directfb >> is an independent packagegroup) > And what will happen with task-core-gtk-directfb-base/ > packagegroup-core-gtk-directfb packages already installed on targets? > > It's also possible that someone still with task-core-gtk-directfb-base > will decide that now it's right time to do upgrade.. > > Cheers, We decided to remove the backwards compatibility statements because the patch adds basically a new packagegroup (different from task-core-gtk-directfb-base/packagegroup-core-gtk-directfb). Cheers, Constantin >> - remove all gtk dependencies >> >> [YOCTO #3642] >> >> Signed-off-by: Constantin Musca <constantinx.musca@intel.com> >> --- >> ...oup-core-gtk-directfb.bb => packagegroup-core-directfb.bb} | 11 ++--------- >> 1 file changed, 2 insertions(+), 9 deletions(-) >> rename meta/recipes-graphics/packagegroups/{packagegroup-core-gtk-directfb.bb => packagegroup-core-directfb.bb} (49%) >> >> diff --git a/meta/recipes-graphics/packagegroups/packagegroup-core-gtk-directfb.bb b/meta/recipes-graphics/packagegroups/packagegroup-core-directfb.bb >> similarity index 49% >> rename from meta/recipes-graphics/packagegroups/packagegroup-core-gtk-directfb.bb >> rename to meta/recipes-graphics/packagegroups/packagegroup-core-directfb.bb >> index 55b0b9d..aca3a67 100644 >> --- a/meta/recipes-graphics/packagegroups/packagegroup-core-gtk-directfb.bb >> +++ b/meta/recipes-graphics/packagegroups/packagegroup-core-directfb.bb >> @@ -1,14 +1,9 @@ >> -SUMMARY = "GTK+ over DirectFB without X11" >> -PR = "r1" >> +SUMMARY = "DirectFB without X11" >> +PR = "r0" >> LICENSE = "MIT" >> >> inherit packagegroup >> >> -# For backwards compatibility after rename >> -RPROVIDES_${PN} = "task-core-gtk-directfb-base" >> -RREPLACES_${PN} = "task-core-gtk-directfb-base" >> -RCONFLICTS_${PN} = "task-core-gtk-directfb-base" >> - >> TOUCH = ' ${@base_contains("MACHINE_FEATURES", "touchscreen", "tslib tslib-calibrate tslib-tests", "",d)}' >> >> RDEPENDS_${PN} = " \ >> @@ -17,7 +12,5 @@ RDEPENDS_${PN} = " \ >> pango \ >> pango-modules \ >> fontconfig \ >> - gtk+ \ >> - gtk-demo \ >> ${TOUCH} \ >> " >> -- >> 1.7.11.7 >> >> >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Patch
diff --git a/meta/recipes-graphics/packagegroups/packagegroup-core-gtk-directfb.bb b/meta/recipes-graphics/packagegroups/packagegroup-core-directfb.bb similarity index 49% rename from meta/recipes-graphics/packagegroups/packagegroup-core-gtk-directfb.bb rename to meta/recipes-graphics/packagegroups/packagegroup-core-directfb.bb index 55b0b9d..aca3a67 100644 --- a/meta/recipes-graphics/packagegroups/packagegroup-core-gtk-directfb.bb +++ b/meta/recipes-graphics/packagegroups/packagegroup-core-directfb.bb @@ -1,14 +1,9 @@ -SUMMARY = "GTK+ over DirectFB without X11" -PR = "r1" +SUMMARY = "DirectFB without X11" +PR = "r0" LICENSE = "MIT" inherit packagegroup -# For backwards compatibility after rename -RPROVIDES_${PN} = "task-core-gtk-directfb-base" -RREPLACES_${PN} = "task-core-gtk-directfb-base" -RCONFLICTS_${PN} = "task-core-gtk-directfb-base" - TOUCH = ' ${@base_contains("MACHINE_FEATURES", "touchscreen", "tslib tslib-calibrate tslib-tests", "",d)}' RDEPENDS_${PN} = " \ @@ -17,7 +12,5 @@ RDEPENDS_${PN} = " \ pango \ pango-modules \ fontconfig \ - gtk+ \ - gtk-demo \ ${TOUCH} \ "
- DirectFB is not supported by gtk versions >= 2.18 - remove the backwards compatibility statements (packagegroup-core-directfb is an independent packagegroup) - remove all gtk dependencies [YOCTO #3642] Signed-off-by: Constantin Musca <constantinx.musca@intel.com> --- ...oup-core-gtk-directfb.bb => packagegroup-core-directfb.bb} | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) rename meta/recipes-graphics/packagegroups/{packagegroup-core-gtk-directfb.bb => packagegroup-core-directfb.bb} (49%)