Patchwork [0/6] Remove obsolete update-modules

login
register
mail settings
Submitter Laurentiu Palcu
Date Jan. 17, 2013, 2:58 p.m.
Message ID <cover.1358432402.git.laurentiu.palcu@intel.com>
Download mbox
Permalink /patch/42805/
State New
Headers show

Pull-request

git://git.yoctoproject.org/poky-contrib lpalcu/update-modules

Comments

Laurentiu Palcu - Jan. 17, 2013, 2:58 p.m.
All,

Working on the postinstall improvements I stumbled over update-modules
script which postponed postinstalls for all the kernel or kernel module
packages for first boot. However, after some investigations I saw that this
script is pretty much obsolete. So, this patchset will remove it from all
recipes and bbclasses it was referenced.

Here's why it's useless now:

update-modules was used mainly to create the /etc/modules.conf file, out of files
in /etc/modutils, and /etc/modules file from /etc/modules-load.d/*.conf files.
Then it just ran depmod -A.

* depmod can be run in the postinst/postrm on its own, no need to run through update-modules;
* /etc/modules.conf is not used anymore by modprobe. modprobe now looks in
  /etc/modprobe.d/ directory for *.conf files;
* /etc/modules was used by /etc/init.d/modutils.sh to automatically load
  modules at boot. However, I improved the script in order to also look into
  /etc/modules-load.d/ directory and load all the modules listed there that were not
  already loaded (in case /etc/modules existed);

I know this is a major change and will affect a lot of people. But, in order
to support RO rootfs and run all the postinstalls on host, this change was
kind of necessary. Note, though, that the update-modules recipe was not removed
yet. It will be removed eventually but, for now, I decided to leave it in place
in case some people are nostalgic and want to still use it for a while.

Feel free to review and comment on the change.

Thanks,
Laurentiu

The following changes since commit 9f263a60e3521b800121a6f527a7b30dc9b62432:

  oprofile: add AArch64 support (2013-01-16 16:10:39 +0000)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib lpalcu/update-modules
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=lpalcu/update-modules

Laurentiu Palcu (6):
  modutils-initscripts: improve modutils.sh
  orinoco-conf: remove dependencies of update-modules
  hostap-conf: remove dependencies of update-modules
  module.bbclass: do not use update-modules anymore
  kernel.bbclass: remove references to update-modules
  bitbake.conf: remove update-modules from DISTRO_FEATURES

 meta/classes/kernel.bbclass                        |   36 +++++++++-----------
 meta/classes/module.bbclass                        |   13 ++++---
 meta/conf/bitbake.conf                             |    2 +-
 meta/recipes-bsp/hostap/files/hostap_cs.modalias   |   34 +++++++++---------
 meta/recipes-bsp/hostap/hostap-conf_1.0.bb         |   17 ++-------
 meta/recipes-bsp/orinoco/orinoco-conf_1.0.bb       |   17 ++-------
 .../modutils-initscripts/files/modutils.sh         |   34 +++++++++++++-----
 7 files changed, 75 insertions(+), 78 deletions(-)
Richard Purdie - Jan. 18, 2013, 1:10 p.m.
On Thu, 2013-01-17 at 16:58 +0200, Laurentiu Palcu wrote:
> All,
> 
> Working on the postinstall improvements I stumbled over update-modules
> script which postponed postinstalls for all the kernel or kernel module
> packages for first boot. However, after some investigations I saw that this
> script is pretty much obsolete. So, this patchset will remove it from all
> recipes and bbclasses it was referenced.
> 
> Here's why it's useless now:
> 
> update-modules was used mainly to create the /etc/modules.conf file, out of files
> in /etc/modutils, and /etc/modules file from /etc/modules-load.d/*.conf files.
> Then it just ran depmod -A.
> 
> * depmod can be run in the postinst/postrm on its own, no need to run through update-modules;
> * /etc/modules.conf is not used anymore by modprobe. modprobe now looks in
>   /etc/modprobe.d/ directory for *.conf files;
> * /etc/modules was used by /etc/init.d/modutils.sh to automatically load
>   modules at boot. However, I improved the script in order to also look into
>   /etc/modules-load.d/ directory and load all the modules listed there that were not
>   already loaded (in case /etc/modules existed);
> 
> I know this is a major change and will affect a lot of people. But, in order
> to support RO rootfs and run all the postinstalls on host, this change was
> kind of necessary. Note, though, that the update-modules recipe was not removed
> yet. It will be removed eventually but, for now, I decided to leave it in place
> in case some people are nostalgic and want to still use it for a while.

I've merged these, I'll also take a patch to remove update-modules
itself.

Cheers,

Richard