From patchwork Tue May 17 23:00:23 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [RFC] u-boot: remove UBOOT_MACHINE and COMPATIBLE_MACHINES Date: Tue, 17 May 2011 23:00:23 -0000 From: Darren Hart X-Patchwork-Id: 4279 Message-Id: <4DD2FE07.4030708@linux.intel.com> To: Patches and discussions about the oe-core layer oe-core does not define any machines, so it does not make sense to add machine specific information in the oe-core u-boot recipe and infrastructure. Since every machine wishing to use the u-boot recipe would need to add itself to COMPATIBLE_MACHINES, typically via a bbappend recipe, the mechanism loses any utility it may have had and unecessarily complicates using the u-boot recipe. By removing it, we simplify the task of adding support for new machines. With these two variables removed from the base recipe, UBOOT_MACHINE must now be specified in each machine config that requires u-boot. This is already the case for UBOOT_ENTRYPOINT and UBOOT_LOADADDRESS, so the change is minimal. For example, a beagleboard machine config currently contains: UBOOT_ENTRYPOINT = "0x80008000" UBOOT_LOADADDRESS = "0x80008000" With this change, it must now contain: UBOOT_MACHINE = "omap3_beagle_config" UBOOT_ENTRYPOINT = "0x80008000" UBOOT_LOADADDRESS = "0x80008000" Signed-off-by: Darren Hart --- meta/recipes-bsp/uboot/u-boot_git.bb | 9 ++++----- 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/meta/recipes-bsp/uboot/u-boot_git.bb b/meta/recipes-bsp/uboot/u-boot_git.bb index c5583ff..1fa0da2 100644 --- a/meta/recipes-bsp/uboot/u-boot_git.bb +++ b/meta/recipes-bsp/uboot/u-boot_git.bb @@ -1,5 +1,9 @@ require u-boot.inc +# To build u-boot for your machine, provide the following lines in your machine +# config, replacing "omap3_beagle" with the appropriate value for your machine. +# UBOOT_MACHINE = "omap3_beagle_config" + LICENSE = "GPLv2+" LIC_FILES_CHKSUM = "file://COPYING;md5=1707d6db1d42237583f50183a5651ecb \ file://README;beginline=1;endline=22;md5=3a00ef51d3fc96e9d6c1bc4708ccd3b5" @@ -12,11 +16,6 @@ PR="r3" SRC_URI = "git://git.denx.de/u-boot.git;branch=master;protocol=git" -UBOOT_MACHINE_beagleboard = "omap3_beagle_config" -UBOOT_MACHINE_overo = "omap3_overo_config" - S = "${WORKDIR}/git" PACKAGE_ARCH = "${MACHINE_ARCH}" - -COMPATIBLE_MACHINE = "(beagleboard|overo)"