Patchwork META-OE: DENZIL Branch: SSVB-CPUBURN-A8: MD5SUM and SHA256SUM don't match source.

login
register
mail settings
Submitter Colin Foe-Parker
Date Jan. 16, 2013, 11:08 p.m.
Message ID <1358377712-18666-1-git-send-email-colin.foeparker@aclimalabs.com>
Download mbox | patch
Permalink /patch/42753/
State Superseded, archived
Headers show

Comments

Colin Foe-Parker - Jan. 16, 2013, 11:08 p.m.
Updated the md5sum and sha256sum for the ssvb-cpuburn-a8.S file

Signed-off-by: Colin Foe-Parker <colin.foeparker@aclimalabs.com>
---
 meta-oe/recipes-benchmark/cpuburn/cpuburn-neon.bb |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Martin Jansa - Jan. 17, 2013, 12:48 p.m.
On Wed, Jan 16, 2013 at 03:08:30PM -0800, Colin Foe-Parker wrote:
> Updated the md5sum and sha256sum for the ssvb-cpuburn-a8.S file

Please read README how commit subject should look like.

Or just see other examples.

Change to denzil needs to be in master/danny first (if it isn't already)

Change of checksum should be explained in commit message and also
include diff between old and new version.

Cheers,
 
> Signed-off-by: Colin Foe-Parker <colin.foeparker@aclimalabs.com>
> ---
>  meta-oe/recipes-benchmark/cpuburn/cpuburn-neon.bb |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-oe/recipes-benchmark/cpuburn/cpuburn-neon.bb b/meta-oe/recipes-benchmark/cpuburn/cpuburn-neon.bb
> index bb9ca1c..68833e6 100644
> --- a/meta-oe/recipes-benchmark/cpuburn/cpuburn-neon.bb
> +++ b/meta-oe/recipes-benchmark/cpuburn/cpuburn-neon.bb
> @@ -13,8 +13,8 @@ SRC_URI = "http://hardwarebug.org/files/burn.S;name=mru \
>             http://github.com/downloads/ssvb/ssvb.github.com/ssvb-cpuburn-a8.S;name=ssvb"
>  SRC_URI[mru.md5sum] = "823abc72c2cd448e87df9bc5355a4456"
>  SRC_URI[mru.sha256sum] = "01d9fc04f83740c513c25401dcc89c11b2a5a6013e70bfca42b7b02129f88cd2"
> -SRC_URI[ssvb.md5sum] = "f1af41dcd56e4f0f7e92b67109dc01ed"
> -SRC_URI[ssvb.sha256sum] = "95e2267a684be0d848dd6f935e769fa3ed810274ebacddc3fe8ddac4b34838c2"
> +SRC_URI[ssvb.md5sum] = "0acc570d943c41c7f8602b9ff6fa111d"
> +SRC_URI[ssvb.sha256sum] = "bfddd3226a499ffdf71bb58c05ccdc6dac5bb2c2c3bdb10ac610ee0b60aac087"
>  
>  S = "${WORKDIR}"
>  
> -- 
> 1.7.9.5
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Colin Foe-Parker - Jan. 17, 2013, 4:44 p.m.
On Jan 17, 2013, at 4:48 AM, Martin Jansa <martin.jansa@gmail.com> wrote:

> On Wed, Jan 16, 2013 at 03:08:30PM -0800, Colin Foe-Parker wrote:
>> Updated the md5sum and sha256sum for the ssvb-cpuburn-a8.S file
> 
> Please read README how commit subject should look like.

Sorry, I will get it right next time. :)

> 
> Or just see other examples.
> 
> Change to denzil needs to be in master/danny first (if it isn't already)
Can you point me to a description of the roles of the different OE branches?  

> Change of checksum should be explained in commit message and also
> include diff between old and new version

I don't have a copy of the previous version of the cpuburn sources.  I tried to build it from
the bitbake recipe in denzil and it failed with validation/fetch errors.  So I pulled the sources, built, and tested them manually.  After I knew that it worked I updated the recipe with the new md5sum/sha256sum values. 

So this is patch is truly reactionary, I was just trying to fix the bitbake recipe so that it would build.

That being said, it appears that "Otavio" already fixed this issue in the master branch but it hasn't filtered down to denzil yet.  a17cda6e85f990bd3569df731ec0f223b185ec6b  

-Colin

> 
> Cheers,
> 
>> Signed-off-by: Colin Foe-Parker <colin.foeparker@aclimalabs.com>
>> ---
>> meta-oe/recipes-benchmark/cpuburn/cpuburn-neon.bb |    4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/meta-oe/recipes-benchmark/cpuburn/cpuburn-neon.bb b/meta-oe/recipes-benchmark/cpuburn/cpuburn-neon.bb
>> index bb9ca1c..68833e6 100644
>> --- a/meta-oe/recipes-benchmark/cpuburn/cpuburn-neon.bb
>> +++ b/meta-oe/recipes-benchmark/cpuburn/cpuburn-neon.bb
>> @@ -13,8 +13,8 @@ SRC_URI = "http://hardwarebug.org/files/burn.S;name=mru \
>>            http://github.com/downloads/ssvb/ssvb.github.com/ssvb-cpuburn-a8.S;name=ssvb"
>> SRC_URI[mru.md5sum] = "823abc72c2cd448e87df9bc5355a4456"
>> SRC_URI[mru.sha256sum] = "01d9fc04f83740c513c25401dcc89c11b2a5a6013e70bfca42b7b02129f88cd2"
>> -SRC_URI[ssvb.md5sum] = "f1af41dcd56e4f0f7e92b67109dc01ed"
>> -SRC_URI[ssvb.sha256sum] = "95e2267a684be0d848dd6f935e769fa3ed810274ebacddc3fe8ddac4b34838c2"
>> +SRC_URI[ssvb.md5sum] = "0acc570d943c41c7f8602b9ff6fa111d"
>> +SRC_URI[ssvb.sha256sum] = "bfddd3226a499ffdf71bb58c05ccdc6dac5bb2c2c3bdb10ac610ee0b60aac087"
>> 
>> S = "${WORKDIR}"
>> 
>> -- 
>> 1.7.9.5
>> 
>> 
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
> 
> -- 
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Eric BENARD - Jan. 18, 2013, 5:05 p.m.
Le Thu, 17 Jan 2013 08:44:34 -0800,
Colin Foe-Parker <colin.foeparker@aclimalabs.com> a écrit :
> So this is patch is truly reactionary, I was just trying to fix the bitbake recipe so that it would build.
> 
> That being said, it appears that "Otavio" already fixed this issue in the master branch but it hasn't filtered down to denzil yet.  a17cda6e85f990bd3569df731ec0f223b185ec6b  
> 
a17cda6e85f990bd3569df731ec0f223b185ec6b cherry picked in denzil-next.

Eric

Patch

diff --git a/meta-oe/recipes-benchmark/cpuburn/cpuburn-neon.bb b/meta-oe/recipes-benchmark/cpuburn/cpuburn-neon.bb
index bb9ca1c..68833e6 100644
--- a/meta-oe/recipes-benchmark/cpuburn/cpuburn-neon.bb
+++ b/meta-oe/recipes-benchmark/cpuburn/cpuburn-neon.bb
@@ -13,8 +13,8 @@  SRC_URI = "http://hardwarebug.org/files/burn.S;name=mru \
            http://github.com/downloads/ssvb/ssvb.github.com/ssvb-cpuburn-a8.S;name=ssvb"
 SRC_URI[mru.md5sum] = "823abc72c2cd448e87df9bc5355a4456"
 SRC_URI[mru.sha256sum] = "01d9fc04f83740c513c25401dcc89c11b2a5a6013e70bfca42b7b02129f88cd2"
-SRC_URI[ssvb.md5sum] = "f1af41dcd56e4f0f7e92b67109dc01ed"
-SRC_URI[ssvb.sha256sum] = "95e2267a684be0d848dd6f935e769fa3ed810274ebacddc3fe8ddac4b34838c2"
+SRC_URI[ssvb.md5sum] = "0acc570d943c41c7f8602b9ff6fa111d"
+SRC_URI[ssvb.sha256sum] = "bfddd3226a499ffdf71bb58c05ccdc6dac5bb2c2c3bdb10ac610ee0b60aac087"
 
 S = "${WORKDIR}"