| Submitter | Christopher Larson |
|---|---|
| Date | Jan. 15, 2013, 8:22 p.m. |
| Message ID | <cover.1358281118.git.chris_larson@mentor.com> |
| Download | mbox |
| Permalink | /patch/42669/ |
| State | New |
| Headers | show |
Pull-request
https://github.com/kergoth/oe-core incompatible-licenseComments
On Tue, Jan 15, 2013 at 12:22 PM, Christopher Larson <kergoth@gmail.com> wrote: > From: Christopher Larson <chris_larson@mentor.com> > > This fixes a number of bugs spotted while trying to use INCOMPATIBLE_LICENSE > = "*GPLv3", and also while experimenting with a recipe whose LICENSE includes > GPLv3, but whose packages do not. In addition, it reduces the message spam by > switching the license incompatibility messages to debug. > > Note: there's still one remaining bug I noticed, the wildcard support which > was added is not very well supported in concert with the host tools exclusion > variables. It asks for an spdx version of "*GPLv3", gets nothing but itself, > and tries to look up whitelists for that string. This is not addressed by this > patch series, but I mention it here for awareness, and also a reminder to > myself to look in to it. Acking the entire series. Thanks Chris! Acked-by: Beth Flanagan <elizabeth.flanagan@intel.com> > > The following changes since commit 6080d1dc719c38fd97c2abd38e0ad938fbf6f452: > > connman: fixed init script so connman can runs over nfs (2013-01-15 08:09:30 +0000) > > are available in the git repository at: > > https://github.com/kergoth/oe-core incompatible-license > > for you to fetch changes up to 5cb12f38b2ac74ea118b58888a0c37f63917fbfa: > > base.bbclass: improve the incompatible license logic a bit (2013-01-15 12:48:51 -0700) > > ---------------------------------------------------------------- > Christopher Larson (6): > license.bbclass: check LICENSE_pkg, not LICENSE_pn-pkg > license: correct re.search/fnmatch indentation > license.bbclass: cleanly handle invalid licenses in incompatible_license > linux-firmware: use LICENSEs which can actually be parsed > base.bbclass: use debug messages for INCOMPATIBLE_LICENSE > base.bbclass: improve the incompatible license logic a bit > > meta/classes/base.bbclass | 9 ++++----- > meta/classes/license.bbclass | 16 +++++++++------- > meta/recipes-kernel/linux-firmware/linux-firmware_git.bb | 13 ++++++------- > 3 files changed, 19 insertions(+), 19 deletions(-) > > Christopher Larson (6): > license.bbclass: check LICENSE_pkg, not LICENSE_pn-pkg > license: correct re.search/fnmatch indentation > license.bbclass: cleanly handle invalid licenses in > incompatible_license > linux-firmware: use LICENSEs which can actually be parsed > base.bbclass: use debug messages for INCOMPATIBLE_LICENSE > base.bbclass: improve the incompatible license logic a bit > > meta/classes/base.bbclass | 9 ++++----- > meta/classes/license.bbclass | 16 +++++++++------- > meta/recipes-kernel/linux-firmware/linux-firmware_git.bb | 13 ++++++------- > 3 files changed, 19 insertions(+), 19 deletions(-) > > -- > 1.8.0.3 > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
From: Christopher Larson <chris_larson@mentor.com> This fixes a number of bugs spotted while trying to use INCOMPATIBLE_LICENSE = "*GPLv3", and also while experimenting with a recipe whose LICENSE includes GPLv3, but whose packages do not. In addition, it reduces the message spam by switching the license incompatibility messages to debug. Note: there's still one remaining bug I noticed, the wildcard support which was added is not very well supported in concert with the host tools exclusion variables. It asks for an spdx version of "*GPLv3", gets nothing but itself, and tries to look up whitelists for that string. This is not addressed by this patch series, but I mention it here for awareness, and also a reminder to myself to look in to it. The following changes since commit 6080d1dc719c38fd97c2abd38e0ad938fbf6f452: connman: fixed init script so connman can runs over nfs (2013-01-15 08:09:30 +0000) are available in the git repository at: https://github.com/kergoth/oe-core incompatible-license for you to fetch changes up to 5cb12f38b2ac74ea118b58888a0c37f63917fbfa: base.bbclass: improve the incompatible license logic a bit (2013-01-15 12:48:51 -0700) ---------------------------------------------------------------- Christopher Larson (6): license.bbclass: check LICENSE_pkg, not LICENSE_pn-pkg license: correct re.search/fnmatch indentation license.bbclass: cleanly handle invalid licenses in incompatible_license linux-firmware: use LICENSEs which can actually be parsed base.bbclass: use debug messages for INCOMPATIBLE_LICENSE base.bbclass: improve the incompatible license logic a bit meta/classes/base.bbclass | 9 ++++----- meta/classes/license.bbclass | 16 +++++++++------- meta/recipes-kernel/linux-firmware/linux-firmware_git.bb | 13 ++++++------- 3 files changed, 19 insertions(+), 19 deletions(-) Christopher Larson (6): license.bbclass: check LICENSE_pkg, not LICENSE_pn-pkg license: correct re.search/fnmatch indentation license.bbclass: cleanly handle invalid licenses in incompatible_license linux-firmware: use LICENSEs which can actually be parsed base.bbclass: use debug messages for INCOMPATIBLE_LICENSE base.bbclass: improve the incompatible license logic a bit meta/classes/base.bbclass | 9 ++++----- meta/classes/license.bbclass | 16 +++++++++------- meta/recipes-kernel/linux-firmware/linux-firmware_git.bb | 13 ++++++------- 3 files changed, 19 insertions(+), 19 deletions(-)