Patchwork [meta-oe] uclibc_git.bb: inherit gitpkgv to get PV

login
register
mail settings
Submitter Khem Raj
Date May 17, 2011, 8:24 p.m.
Message ID <1305663890-20372-1-git-send-email-raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/4265/
State New, archived
Headers show

Comments

Khem Raj - May 17, 2011, 8:24 p.m.
From: Khem Raj <raj.khem@gmail.com>

use GITPKGVTAG for PV
Cleanup unused UCLIBC_BASE

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta-oe/recipes-core/uclibc/uclibc_git.bb |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
Otavio Salvador - May 17, 2011, 8:35 p.m.
On Tue, May 17, 2011 at 17:24,  <raj.khem@gmail.com> wrote:
> From: Khem Raj <raj.khem@gmail.com>
>
> use GITPKGVTAG for PV
> Cleanup unused UCLIBC_BASE

Is it working for you? here, with freerdp, it doesn't.
Phil Blundell - May 17, 2011, 8:50 p.m.
On Tue, 2011-05-17 at 13:24 -0700, raj.khem@gmail.com wrote:
> From: Khem Raj <raj.khem@gmail.com>
> 
> use GITPKGVTAG for PV
> Cleanup unused UCLIBC_BASE
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta-oe/recipes-core/uclibc/uclibc_git.bb |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/meta-oe/recipes-core/uclibc/uclibc_git.bb b/meta-oe/recipes-core/uclibc/uclibc_git.bb
> index cbc8ab8..05eea00 100644
> --- a/meta-oe/recipes-core/uclibc/uclibc_git.bb
> +++ b/meta-oe/recipes-core/uclibc/uclibc_git.bb
> @@ -6,17 +6,17 @@
>  # UCLIBC_BASE can be set in a distro file, but whether this works depends
>  # on whether the base patches apply to the selected (SRCDATE) svn release.

I guess that comment should also be removed if UCLIBC_BASE is unused.

p.
Khem Raj - May 17, 2011, 9:25 p.m.
On Tue, May 17, 2011 at 1:35 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> On Tue, May 17, 2011 at 17:24,  <raj.khem@gmail.com> wrote:
>> From: Khem Raj <raj.khem@gmail.com>
>>
>> use GITPKGVTAG for PV
>> Cleanup unused UCLIBC_BASE
>
> Is it working for you? here, with freerdp, it doesn't.xi

hmmm it works fine when I have existing git repo but moment I use a different
SRCREV I start getting 0.0.0
>
> --
> Otavio Salvador                             O.S. Systems
> E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
> Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
Khem Raj - May 17, 2011, 9:27 p.m.
On Tue, May 17, 2011 at 1:50 PM, Phil Blundell <philb@gnu.org> wrote:
> On Tue, 2011-05-17 at 13:24 -0700, raj.khem@gmail.com wrote:
>> From: Khem Raj <raj.khem@gmail.com>
>>
>> use GITPKGVTAG for PV
>> Cleanup unused UCLIBC_BASE
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>>  meta-oe/recipes-core/uclibc/uclibc_git.bb |    6 +++---
>>  1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/meta-oe/recipes-core/uclibc/uclibc_git.bb b/meta-oe/recipes-core/uclibc/uclibc_git.bb
>> index cbc8ab8..05eea00 100644
>> --- a/meta-oe/recipes-core/uclibc/uclibc_git.bb
>> +++ b/meta-oe/recipes-core/uclibc/uclibc_git.bb
>> @@ -6,17 +6,17 @@
>>  # UCLIBC_BASE can be set in a distro file, but whether this works depends
>>  # on whether the base patches apply to the selected (SRCDATE) svn release.
>
> I guess that comment should also be removed if UCLIBC_BASE is unused

thanks. Will do that in V2 soon

> p.
>
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
Otavio Salvador - May 17, 2011, 9:37 p.m.
On Tue, May 17, 2011 at 18:25, Khem Raj <raj.khem@gmail.com> wrote:
>> Is it working for you? here, with freerdp, it doesn't.xi
>
> hmmm it works fine when I have existing git repo but moment I use a different
> SRCREV I start getting 0.0.0

It used to work quite well with OE (dev) but with OE-core it is
failing; I think it might be related to changes on bitbake.
Khem Raj - May 17, 2011, 11:33 p.m.
On Tue, May 17, 2011 at 2:37 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> On Tue, May 17, 2011 at 18:25, Khem Raj <raj.khem@gmail.com> wrote:
>>> Is it working for you? here, with freerdp, it doesn't.xi
>>
>> hmmm it works fine when I have existing git repo but moment I use a different
>> SRCREV I start getting 0.0.0
>
> It used to work quite well with OE (dev) but with OE-core it is
> failing; I think it might be related to changes on bitbake.
>

and FILESPATHPKG need porting over to oe as well

> --
> Otavio Salvador                             O.S. Systems
> E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
> Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Patch

diff --git a/meta-oe/recipes-core/uclibc/uclibc_git.bb b/meta-oe/recipes-core/uclibc/uclibc_git.bb
index cbc8ab8..05eea00 100644
--- a/meta-oe/recipes-core/uclibc/uclibc_git.bb
+++ b/meta-oe/recipes-core/uclibc/uclibc_git.bb
@@ -6,17 +6,17 @@ 
 # UCLIBC_BASE can be set in a distro file, but whether this works depends
 # on whether the base patches apply to the selected (SRCDATE) svn release.
 #
-UCLIBC_BASE ?= "0.9.32"
 SRCREV="074930dd7f2a18a7013cdb72cc38136f3be39c40"
-PR_append = "+gitr${SRCPV}"
 
 require uclibc.inc
+inherit gitpkgv
+PV = "${GITPKGVTAG}"
 PR = "${INC_PR}.1"
 PROVIDES += "virtual/${TARGET_PREFIX}libc-for-gcc"
 
 #recent versions uclibc require real kernel headers
 PACKAGE_ARCH = "${MACHINE_ARCH}"
-FILESPATHPKG =. "uclibc-git:uclibc-${UCLIBC_BASE}:"
+FILESPATHPKG =. "uclibc-git:"
 
 #as stated above, uclibc needs real kernel-headers
 #however: we can't depend on virtual/kernel when nptl hits due to depends deadlocking ....