Patchwork [bitbake-devel] hob: combo box updated correctly

login
register
mail settings
Submitter Cristiana Voicu
Date Jan. 15, 2013, 2:50 p.m.
Message ID <1358261439-1943-1-git-send-email-cristiana.voicu@intel.com>
Download mbox | patch
Permalink /patch/42639/
State New
Headers show

Comments

Cristiana Voicu - Jan. 15, 2013, 2:50 p.m.
The 'select a base image' option is no longer displayed once
an image is selected

[YOCTO #3671]
Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
---
 bitbake/lib/bb/ui/crumbs/imageconfigurationpage.py |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Patch

diff --git a/bitbake/lib/bb/ui/crumbs/imageconfigurationpage.py b/bitbake/lib/bb/ui/crumbs/imageconfigurationpage.py
index b94f35c..e28d416 100644
--- a/bitbake/lib/bb/ui/crumbs/imageconfigurationpage.py
+++ b/bitbake/lib/bb/ui/crumbs/imageconfigurationpage.py
@@ -363,7 +363,7 @@  class ImageConfigurationPage (HobPage):
         image_model = recipe_model.tree_model(filter)
         image_model.set_sort_column_id(recipe_model.COL_NAME, gtk.SORT_ASCENDING)
         active = 0
-        cnt = 1
+        cnt = 0
 
         white_pattern = []
         if self.builder.parameters.image_white_pattern:
@@ -381,7 +381,10 @@  class ImageConfigurationPage (HobPage):
         model = self.image_combo.get_model()
         model.clear()
         # Set a indicator text to combo store when first open
-        self.image_combo.append_text(self.__dummy_image__)
+        if not selected_image:
+            self.image_combo.append_text(self.__dummy_image__)
+            cnt = cnt + 1
+
         # append and set active
         while it:
             path = image_model.get_path(it)