Patchwork [1/3] archive-*-source.bbclass: Use tasks instead of pre/post functions

login
register
mail settings
Submitter Shakeel, Muhammad
Date Jan. 8, 2013, 3:55 p.m.
Message ID <1357660547-19803-1-git-send-email-muhammad_shakeel@mentor.com>
Download mbox | patch
Permalink /patch/42537/
State New
Headers show

Comments

Shakeel, Muhammad - Jan. 8, 2013, 3:55 p.m.
From: Muhammad Shakeel <muhammad_shakeel@mentor.com>

* Modified following archiver related classes to add separate tasks
  for different archiver functions instead of adding these as pre/post
  functions of existing tasks.
    -archive-original-source.bbclass
    -archive-patched-source.bbclass
    -archive-configured-source.bbclass

[YOCTO #3449]

Signed-off-by: Muhammad Shakeel <muhammad_shakeel@mentor.com>
Signed-off-by: Noor Ahsan <noor_ahsan@mentor.com>
Signed-off-by: Christopher Larson <chris_larson@mentor.com>
---
 meta/classes/archive-configured-source.bbclass |    6 +++---
 meta/classes/archive-original-source.bbclass   |    6 +++---
 meta/classes/archive-patched-source.bbclass    |    6 +++---
 3 files changed, 9 insertions(+), 9 deletions(-)
Otavio Salvador - Jan. 8, 2013, 4:03 p.m.
On Tue, Jan 8, 2013 at 1:55 PM, Shakeel, Muhammad
<muhammad_shakeel@mentor.com> wrote:
> From: Muhammad Shakeel <muhammad_shakeel@mentor.com>
>
> * Modified following archiver related classes to add separate tasks
>   for different archiver functions instead of adding these as pre/post
>   functions of existing tasks.
>     -archive-original-source.bbclass
>     -archive-patched-source.bbclass
>     -archive-configured-source.bbclass
>
> [YOCTO #3449]
>
> Signed-off-by: Muhammad Shakeel <muhammad_shakeel@mentor.com>
> Signed-off-by: Noor Ahsan <noor_ahsan@mentor.com>
> Signed-off-by: Christopher Larson <chris_larson@mentor.com>

This can be dropped as it will be changed again in 3/3. Right?

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Shakeel, Muhammad - Jan. 14, 2013, 1:42 p.m.
All right. I am resending this patch with two commits in total.

--Shakeel

-----Original Message-----
From: otavio.salvador@gmail.com [mailto:otavio.salvador@gmail.com] On Behalf Of Otavio Salvador
Sent: Tuesday, January 08, 2013 9:04 PM
To: Shakeel, Muhammad
Cc: Patches and discussions about the oe-core layer; Larson, Chris
Subject: Re: [OE-core] [PATCH 1/3] archive-*-source.bbclass: Use tasks instead of pre/post functions

On Tue, Jan 8, 2013 at 1:55 PM, Shakeel, Muhammad <muhammad_shakeel@mentor.com> wrote:
> From: Muhammad Shakeel <muhammad_shakeel@mentor.com>
>
> * Modified following archiver related classes to add separate tasks
>   for different archiver functions instead of adding these as pre/post
>   functions of existing tasks.
>     -archive-original-source.bbclass
>     -archive-patched-source.bbclass
>     -archive-configured-source.bbclass
>
> [YOCTO #3449]
>
> Signed-off-by: Muhammad Shakeel <muhammad_shakeel@mentor.com>
> Signed-off-by: Noor Ahsan <noor_ahsan@mentor.com>
> Signed-off-by: Christopher Larson <chris_larson@mentor.com>

This can be dropped as it will be changed again in 3/3. Right?

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Patch

diff --git a/meta/classes/archive-configured-source.bbclass b/meta/classes/archive-configured-source.bbclass
index 1eaaf4c..d804e3d 100644
--- a/meta/classes/archive-configured-source.bbclass
+++ b/meta/classes/archive-configured-source.bbclass
@@ -8,10 +8,10 @@ 
 inherit archiver
 
 # Get archiving package with configured sources including patches
-do_configure[postfuncs] += "do_archive_configured_sources "
+addtask do_archive_configured_sources after do_configure before do_compile
 
 # Get archiving package with temp(logs) and scripts(.bb and inc files)
-do_package_write_rpm[prefuncs] += "do_archive_scripts_logs "
+addtask do_archive_scripts_logs after do_package before do_package_write_rpm
 
 # Get dump date and create diff file 
-do_package_write_rpm[postfuncs] += "do_dumpdata_create_diff_gz "
+addtask do_dumpdata_create_diff_gz after do_package_write_rpm before do_build
diff --git a/meta/classes/archive-original-source.bbclass b/meta/classes/archive-original-source.bbclass
index 1b3f8d0..604d19c 100644
--- a/meta/classes/archive-original-source.bbclass
+++ b/meta/classes/archive-original-source.bbclass
@@ -8,10 +8,10 @@ 
 inherit archiver
 
 # Get original sources archiving package with patches
-do_unpack[postfuncs] += "do_archive_original_sources_patches "
+addtask do_archive_original_sources_patches after do_unpack before do_patch
 
 # Get archiving package with temp(logs) and scripts(.bb and inc files)
-do_package_write_rpm[prefuncs] += "do_archive_scripts_logs "
+addtask do_archive_scripts_logs after do_package before do_package_write_rpm
 
 # Get dump date and create diff file 
-do_package_write_rpm[postfuncs] += "do_dumpdata_create_diff_gz "
+addtask do_dumpdata_create_diff_gz after do_package_write_rpm before do_build
diff --git a/meta/classes/archive-patched-source.bbclass b/meta/classes/archive-patched-source.bbclass
index 40b2dcb..4b0a199 100644
--- a/meta/classes/archive-patched-source.bbclass
+++ b/meta/classes/archive-patched-source.bbclass
@@ -8,10 +8,10 @@ 
 inherit archiver
 
 # Get archiving package with patched sources including patches
-do_patch[postfuncs] += "do_archive_patched_sources "
+addtask do_archive_patched_sources after do_patch before do_configure
 
 # Get archiving package with logs(temp) and scripts(.bb and .inc files)
-do_package_write_rpm[prefuncs] += "do_archive_scripts_logs "
+addtask do_archive_scripts_logs after do_package before do_package_write_rpm
 
 # Get dump date and create diff file 
-do_package_write_rpm[postfuncs] += "do_dumpdata_create_diff_gz "
+addtask do_dumpdata_create_diff_gz after do_package_write_rpm before do_build