Patchwork [00/21,RFC,v3] systemd Integration

login
register
mail settings
Submitter Radu Moisan
Date Jan. 8, 2013, 12:24 p.m.
Message ID <cover.1357647338.git.radu.moisan@intel.com>
Download mbox
Permalink /patch/42535/
State New
Headers show

Pull-request

git://git.yoctoproject.org/poky-contrib rmoisan/systemd

Comments

Radu Moisan - Jan. 8, 2013, 12:24 p.m.
As Ross suggested I've done the following changes to the previous set:
* added two patches (the first two) that address multiple init systems support,\
as in shifting from default hardcoded sysvinit to something more generic while
the default values still remains on sysvinit
* moved automatic setting of PREFERRED_PROVIDER_udev into default_providers.inc
* removed ahavi-systemd since all it provided was service files; now service files
are pulled in by avahi-daemon
* also rebased on master

The following changes since commit 7e1f8faad0c4b6f490c26f87acc698dd6e002b15:

  perl: Remove bashism from perl-tests.inc (2013-01-07 22:37:37 +0000)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib rmoisan/systemd
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=rmoisan/systemd

Enrico Scholz (1):
  systemd: move disable operation into prerm() script

Holger Hans Peter Freyther (2):
  systemd: Make the main systemd files proper CONFFILES
  systemd: Introduce a create-volatile to create tmp directories

Khem Raj (1):
  systemd: Fix build when base_libdir is not /lib

Martin Donnelly (2):
  cgroups: Add INSANE_SKIP to avoid warning about .so file
  systemd: Remove sysvinit mount related services if systemd is enabled

Martin Jansa (2):
  systemd: fix FILESPATH to find systemctl
  systemd: add PACKAGES_DYNAMIC

Radu Moisan (13):
  default-distrovars: Add DISTRO_FEATURES_INITMAN to DISTRO_FEATURES
  default-providers: Automatically set PREFERRED_PROVIDER_udev
  systemd: initial integration
  systemd: Add systemd_base.bbclass
  systemd: Add systemd option to PREFERRED_PROVIDER_udev
  systemd: set default.target to multi-user.target
  systemd: update FILESPATH with *-native directory
  systemd: disable sysfs.service
  systemd: Add systemd-compat-units
  systemd: Add avahi to packagegroup-core-boot
  xserver-nodm-init: Enable systemd support
  util-linux: Enable systemd support
  systemd: Disable xz when building with GPLv3 incompatibility flag

 meta/classes/systemd.bbclass                       |    1 +
 meta/classes/systemd_base.bbclass                  |  218 +++++++++++++
 meta/conf/distro/include/default-distrovars.inc    |    3 +-
 meta/conf/distro/include/default-providers.inc     |    1 +
 meta/recipes-bsp/keymaps/files/keymaps.service     |    9 +
 meta/recipes-bsp/keymaps/keymaps_1.0.bb            |    9 +-
 meta/recipes-connectivity/avahi/avahi.inc          |   23 +-
 meta/recipes-connectivity/connman/connman.inc      |    6 +
 meta/recipes-connectivity/connman/connman_1.4.bb   |    3 +-
 meta/recipes-connectivity/dhcp/dhcp.inc            |   15 +-
 meta/recipes-connectivity/dhcp/files/dhcpd.service |   12 +
 .../dhcp/files/dhcrelay.service                    |   10 +
 .../openssh/openssh-6.0p1/sshd.socket              |   11 +
 .../openssh/openssh-6.0p1/sshd@.service            |    9 +
 .../openssh/openssh-6.0p1/sshdgenkeys.service      |   10 +
 meta/recipes-connectivity/openssh/openssh_6.0p1.bb |   14 +-
 .../wpa-supplicant/wpa-supplicant-1.0.inc          |   74 +++--
 .../wpa-supplicant/wpa-supplicant_1.0.bb           |    2 +-
 meta/recipes-core/busybox/busybox.inc              |   18 ++
 meta/recipes-core/busybox/busybox_1.20.2.bb        |    4 +-
 .../busybox/files/busybox-klogd.service.in         |    8 +
 .../busybox/files/busybox-syslog.service.in        |   13 +
 meta/recipes-core/dropbear/dropbear.inc            |   81 ++---
 .../recipes-core/dropbear/dropbear/dropbear.socket |   10 +
 .../dropbear/dropbear/dropbear@.service            |    9 +
 .../dropbear/dropbear/dropbearkey.service          |   10 +
 .../initscripts-1.0/{urandom => urandom.sh}        |    0
 meta/recipes-core/initscripts/initscripts_1.0.bb   |  164 +++++-----
 meta/recipes-core/libcgroup/libcgroup_0.37.1.bb    |    1 +
 .../packagegroups/packagegroup-base.bb             |    3 +-
 .../packagegroups/packagegroup-core-boot.bb        |    9 +-
 meta/recipes-core/systemd/systemd-compat-units.bb  |   59 ++++
 .../systemd/systemd-compat-units/machineid.service |   16 +
 .../systemd-compat-units/run-postinsts.service     |   17 +
 .../systemd/systemd-machine-units_1.0.bb           |   14 +
 meta/recipes-core/systemd/systemd-serialgetty.bb   |   46 +++
 .../systemd/systemd-serialgetty/LICENSE            |  339 ++++++++++++++++++++
 .../systemd-serialgetty/serial-getty@.service      |   32 ++
 meta/recipes-core/systemd/systemd-speed-hacks.bb   |   18 ++
 .../systemd/systemd-systemctl-native.bb            |   20 ++
 .../systemd/systemd-systemctl-native/systemctl     |  126 ++++++++
 .../systemd/systemd/create-volatile.conf           |   10 +
 meta/recipes-core/systemd/systemd/gtk-doc.make     |  230 +++++++++++++
 meta/recipes-core/systemd/systemd/modprobe.rules   |   17 +
 .../systemd/systemd/optional_secure_getenv.patch   |   19 ++
 .../systemd/set_default_target_to_multi-user.patch |   13 +
 .../systemd-pam-configure-check-uclibc.patch       |   26 ++
 .../systemd/systemd/systemd-pam-fix-execvpe.patch  |   26 ++
 .../systemd/systemd-pam-fix-fallocate.patch        |   82 +++++
 .../systemd/systemd-pam-fix-getty-unit.patch       |   35 ++
 .../systemd/systemd/systemd-pam-fix-mkostemp.patch |  166 ++++++++++
 .../systemd/systemd/systemd-pam-fix-msformat.patch |  335 +++++++++++++++++++
 .../recipes-core/systemd/systemd/touchscreen.rules |   18 ++
 meta/recipes-core/systemd/systemd/var-run.conf     |    4 +
 meta/recipes-core/systemd/systemd_git.bb           |  252 +++++++++++++++
 meta/recipes-core/util-linux/util-linux.inc        |   11 +-
 meta/recipes-extended/cronie/cronie/crond.service  |   10 +
 meta/recipes-extended/cronie/cronie_1.4.8.bb       |   10 +-
 .../lighttpd/files/lighttpd.service                |   13 +
 meta/recipes-extended/lighttpd/lighttpd_1.4.32.bb  |   11 +-
 meta/recipes-extended/pam/libpam_1.1.6.bb          |    3 +
 meta/recipes-extended/polkit/polkit_0.104.bb       |    9 +-
 meta/recipes-graphics/x11-common/x11-common_0.1.bb |    4 +-
 .../x11-common/xserver-nodm-init.bb                |   19 +-
 .../x11-common/xserver-nodm-init/xserver-nodm.conf |    1 +
 .../xserver-nodm-init/xserver-nodm.service         |    9 +
 66 files changed, 2606 insertions(+), 174 deletions(-)
 create mode 100644 meta/classes/systemd.bbclass
 create mode 100644 meta/classes/systemd_base.bbclass
 create mode 100644 meta/recipes-bsp/keymaps/files/keymaps.service
 create mode 100644 meta/recipes-connectivity/dhcp/files/dhcpd.service
 create mode 100644 meta/recipes-connectivity/dhcp/files/dhcrelay.service
 create mode 100644 meta/recipes-connectivity/openssh/openssh-6.0p1/sshd.socket
 create mode 100644 meta/recipes-connectivity/openssh/openssh-6.0p1/sshd@.service
 create mode 100644 meta/recipes-connectivity/openssh/openssh-6.0p1/sshdgenkeys.service
 create mode 100644 meta/recipes-core/busybox/files/busybox-klogd.service.in
 create mode 100644 meta/recipes-core/busybox/files/busybox-syslog.service.in
 create mode 100644 meta/recipes-core/dropbear/dropbear/dropbear.socket
 create mode 100644 meta/recipes-core/dropbear/dropbear/dropbear@.service
 create mode 100644 meta/recipes-core/dropbear/dropbear/dropbearkey.service
 rename meta/recipes-core/initscripts/initscripts-1.0/{urandom => urandom.sh} (100%)
 create mode 100644 meta/recipes-core/systemd/systemd-compat-units.bb
 create mode 100644 meta/recipes-core/systemd/systemd-compat-units/machineid.service
 create mode 100644 meta/recipes-core/systemd/systemd-compat-units/run-postinsts.service
 create mode 100644 meta/recipes-core/systemd/systemd-machine-units_1.0.bb
 create mode 100644 meta/recipes-core/systemd/systemd-serialgetty.bb
 create mode 100644 meta/recipes-core/systemd/systemd-serialgetty/LICENSE
 create mode 100644 meta/recipes-core/systemd/systemd-serialgetty/serial-getty@.service
 create mode 100644 meta/recipes-core/systemd/systemd-speed-hacks.bb
 create mode 100644 meta/recipes-core/systemd/systemd-systemctl-native.bb
 create mode 100755 meta/recipes-core/systemd/systemd-systemctl-native/systemctl
 create mode 100644 meta/recipes-core/systemd/systemd/create-volatile.conf
 create mode 100644 meta/recipes-core/systemd/systemd/gtk-doc.make
 create mode 100644 meta/recipes-core/systemd/systemd/modprobe.rules
 create mode 100644 meta/recipes-core/systemd/systemd/optional_secure_getenv.patch
 create mode 100644 meta/recipes-core/systemd/systemd/set_default_target_to_multi-user.patch
 create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-configure-check-uclibc.patch
 create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-execvpe.patch
 create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-fallocate.patch
 create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-getty-unit.patch
 create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-mkostemp.patch
 create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-msformat.patch
 create mode 100644 meta/recipes-core/systemd/systemd/touchscreen.rules
 create mode 100644 meta/recipes-core/systemd/systemd/var-run.conf
 create mode 100644 meta/recipes-core/systemd/systemd_git.bb
 create mode 100644 meta/recipes-extended/cronie/cronie/crond.service
 create mode 100644 meta/recipes-extended/lighttpd/files/lighttpd.service
 create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf
 create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service
Enrico Scholz - Jan. 8, 2013, 12:57 p.m.
Radu Moisan <radu.moisan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
writes:

> Enrico Scholz (1):
>   systemd: move disable operation into prerm() script

   http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=rmoisan/systemd&id=e01411c2400231a89bc76a229b38e7eb95b7cd81

I am pretty sure that I added a 'Signed-off-by:' field to my patch but
it is missing in the commit.  Other patches don't have the signed-off-by
of the original author neither.

Was this removal done on purpose?



>   systemd: Introduce a create-volatile to create tmp directories

   http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=rmoisan/systemd&id=64de9a773c1ac79d4dbcb041ed7e66c19a3cf6b7

When/because the order of files is really important, they should be installed
with the usual <number>- prefix method (e.g. '00-create-volatile.conf').

Else, when e.g. /var/cache/apache is created by a 3rd part recipe, it
requires (yet more) ugly naming tricks (e.g. naming it
'zz-apache-httpd.conf') to ensure the correct order and it might break
easily when something else is changed.



Enrico
Ross Burton - Jan. 8, 2013, 2:57 p.m.
On 8 January 2013 15:01, Radu Moisan <radu.moisan@intel.com> wrote:
> I am pretty sure that I added a 'Signed-off-by:' field to my patch but
> it is missing in the commit.  Other patches don't have the signed-off-by
> of the original author neither.
>
> Was this removal done on purpose?
>
>
> I had to port the patch manually so I guess it got lost then. Do we want to
> have Sign-off-by from author as well?

By the time the patches land in oe-core there'll have been a lot of
rebasing and merging as I don't intend to see a series that contains
fixes in oe-core.  We should ensure that everyone who contributed to
meta-oe gets a credit in the series.

Ross
Radu Moisan - Jan. 8, 2013, 3:01 p.m.
On 01/08/2013 02:57 PM, Enrico Scholz wrote:
> Radu Moisan <radu.moisan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> writes:
>
>> Enrico Scholz (1):
>>    systemd: move disable operation into prerm() script
>     http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=rmoisan/systemd&id=e01411c2400231a89bc76a229b38e7eb95b7cd81
>
> I am pretty sure that I added a 'Signed-off-by:' field to my patch but
> it is missing in the commit.  Other patches don't have the signed-off-by
> of the original author neither.
>
> Was this removal done on purpose?

I had to port the patch manually so I guess it got lost then. Do we want 
to have Sign-off-by from author as well?

>>    systemd: Introduce a create-volatile to create tmp directories
>     http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=rmoisan/systemd&id=64de9a773c1ac79d4dbcb041ed7e66c19a3cf6b7
>
> When/because the order of files is really important, they should be installed
> with the usual <number>- prefix method (e.g. '00-create-volatile.conf').
>
> Else, when e.g. /var/cache/apache is created by a 3rd part recipe, it
> requires (yet more) ugly naming tricks (e.g. naming it
> 'zz-apache-httpd.conf') to ensure the correct order and it might break
> easily when something else is changed.
>
You have a point here. Noted.

Radu
Ross Burton - Jan. 8, 2013, 3:10 p.m.
On 8 January 2013 15:11, Radu Moisan <radu.moisan@intel.com> wrote:
> No question about that, the question was whether to add Sign-off-by from the
> author itself. I know that we are doing it like that right now, but I don't
> understand it's reasoning. Being the author of a patch what would be the
> point in adding a Sign-off-by with the same name? I can agree either way, no
> question about that, just want it to get it clear why we do it like we do
> it.

It's usual to sign-off your own patches, but in this case where
people's conributions are being remixed, merged and so on, they didn't
strictly speaking sign-off on the actual commit.

Ross
Radu Moisan - Jan. 8, 2013, 3:11 p.m.
On 01/08/2013 04:57 PM, Burton, Ross wrote:
> On 8 January 2013 15:01, Radu Moisan <radu.moisan@intel.com> wrote:
>> I am pretty sure that I added a 'Signed-off-by:' field to my patch but
>> it is missing in the commit.  Other patches don't have the signed-off-by
>> of the original author neither.
>>
>> Was this removal done on purpose?
>>
>>
>> I had to port the patch manually so I guess it got lost then. Do we want to
>> have Sign-off-by from author as well?
> By the time the patches land in oe-core there'll have been a lot of
> rebasing and merging as I don't intend to see a series that contains
> fixes in oe-core.  We should ensure that everyone who contributed to
> meta-oe gets a credit in the series.
>
No question about that, the question was whether to add Sign-off-by from 
the author itself. I know that we are doing it like that right now, but 
I don't understand it's reasoning. Being the author of a patch what 
would be the point in adding a Sign-off-by with the same name? I can 
agree either way, no question about that, just want it to get it clear 
why we do it like we do it.

Radu
Enrico Scholz - Jan. 8, 2013, 3:18 p.m.
Radu Moisan <radu.moisan@intel.com> writes:

> No question about that, the question was whether to add Sign-off-by
> from the author itself. I know that we are doing it like that right
> now, but I don't understand it's reasoning. Being the author of a
> patch what would be the point in adding a Sign-off-by with the same
> name?

afaik, signed-off-by is required to allow tracking of the patch to prove
copyright or so.

The plain authorship information does not suffice because it may get
lost in some workflows.  E.g. when somebody sends a patch by email and
applies it manually, the metadata might get overridden.



Enrico
Samuel Stirtzel - Jan. 8, 2013, 3:20 p.m.
2013/1/8 Radu Moisan <radu.moisan@intel.com>:
>
> On 01/08/2013 04:57 PM, Burton, Ross wrote:
>>
>> On 8 January 2013 15:01, Radu Moisan <radu.moisan@intel.com> wrote:
>>>
>>> I am pretty sure that I added a 'Signed-off-by:' field to my patch but
>>> it is missing in the commit.  Other patches don't have the signed-off-by
>>> of the original author neither.
>>>
>>> Was this removal done on purpose?
>>>
>>>
>>> I had to port the patch manually so I guess it got lost then. Do we want
>>> to
>>> have Sign-off-by from author as well?
>>
>> By the time the patches land in oe-core there'll have been a lot of
>> rebasing and merging as I don't intend to see a series that contains
>> fixes in oe-core.  We should ensure that everyone who contributed to
>> meta-oe gets a credit in the series.
>>
> No question about that, the question was whether to add Sign-off-by from the
> author itself. I know that we are doing it like that right now, but I don't
> understand it's reasoning. Being the author of a patch what would be the
> point in adding a Sign-off-by with the same name? I can agree either way, no
> question about that, just want it to get it clear why we do it like we do
> it.
>
> Radu

This is part of the Linux Kernel patch workflow:

"To improve tracking of who did what, especially with patches that can
percolate to their final resting place in the kernel through several
layers of maintainers, we've introduced a "sign-off" procedure on
patches that are being emailed around."


see: http://kerneltrap.org/files/Jeremy/DCO.txt


--
Regards
Samuel
Saul Wold - Jan. 9, 2013, 4:51 p.m.
On 01/08/2013 04:24 AM, Radu Moisan wrote:
> As Ross suggested I've done the following changes to the previous set:
> * added two patches (the first two) that address multiple init systems support,\
> as in shifting from default hardcoded sysvinit to something more generic while
> the default values still remains on sysvinit
> * moved automatic setting of PREFERRED_PROVIDER_udev into default_providers.inc
> * removed ahavi-systemd since all it provided was service files; now service files
> are pulled in by avahi-daemon
> * also rebased on master
>

With a world build I saw the following failure:
> | i586-poky-linux-libtool: link: (cd ".libs" && rm -f "libsystemd-journal.so" && ln -s "libsystemd-journal.so.0.6.0" "libsystemd-journal.so")
> | i586-poky-linux-libtool: link: (cd ".libs" && rm -f "libsystemd-id128.so.0" && ln -s "libsystemd-id128.so.0.0.15" "libsystemd-id128.so.0")
> | i586-poky-linux-libtool: link: (cd .libs/libudev.lax/libsystemd-shared.a && i586-poky-linux-ar x "/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-world/build/build/tmp/work/i586-poky-linux/systemd/git-r12/git/./.libs/libsystemd-shared.a")
> | i586-poky-linux-libtool: link: (cd ".libs" && rm -f "libsystemd-id128.so" && ln -s "libsystemd-id128.so.0.0.15" "libsystemd-id128.so")
> | ./.libs/libsystemd-daemon.so: undefined reference to `mq_getattr'
> | i586-poky-linux-libtool: link: (cd .libs/libsystemd-logs.lax/libsystemd-shared.a && i586-poky-linux-ar x "/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-world/build/build/tmp/work/i586-poky-linux/systemd/git-r12/git/./.libs/libsystemd-shared.a")
> | collect2: error: ld returned 1 exit status
> | make[2]: *** [systemd-nspawn] Error 1
> | make[2]: *** Waiting for unfinished jobs....
> | i586-poky-linux-libtool: link: ( cd ".libs" && rm -f "libsystemd-journal.la" && ln -s "../libsystemd-journal.la" "libsystemd-journal.la" )
> | i586-poky-linux-libtool: link: i586-poky-linux-ar cru .libs/libudev.a  src/libudev/libudev_la-libudev.o src/libudev/libudev_la-libudev-list.o src/libudev/libudev_la-libudev-util.o src/libudev/libudev_la-libudev-device.o src/libudev/libudev_la-libudev-enumerate.o src/libudev/libudev_la-libudev-monitor.o src/libudev/libudev_la-libudev-queue.o  .libs/libudev.lax/libsystemd-shared.a/cgroup-show.o .libs/libudev.lax/libsystemd-shared.a/cgroup-util.o .libs/libudev.lax/libsystemd-shared.a/conf-files.o .libs/libudev.lax/libsystemd-shared.a/conf-parser.o .libs/libudev.lax/libsystemd-shared.a/exit-status.o .libs/libudev.lax/libsystemd-shared.a/hashmap.o .libs/libudev.lax/libsystemd-shared.a/hwclock.o .libs/libudev.lax/libsystemd-shared.a/log.o .libs/libudev.lax/libsystemd-shared.a/pager.o .libs/libudev.lax/libsystemd-shared.a/path-util.o .libs/libudev.lax/libsystemd-shared.a/ratelimit.o .libs/libudev.lax/libsystemd-shared.a/set.o .libs/libudev.lax/libsystemd-shared.a/socket-util.o .libs/libu
dev.lax/libsystemd-shared.a/spawn-ask-password-agent.o .libs/libudev.lax/libsystemd-shared.a/spawn-polkit-agent.o .libs/libudev.lax/libsystemd-shared.a/specifier.o .libs/libudev.lax/libsystemd-shared.a/strbuf.o .libs/libudev.lax/libsystemd-shared.a/strv.o .libs/libudev.lax/libsystemd-shared.a/unit-name.o .libs/libudev.lax/libsystemd-shared.a/utf8.o .libs/libudev.lax/libsystemd-shared.a/util.o .libs/libudev.lax/libsystemd-shared.a/utmp-wtmp.o .libs/libudev.lax/libsystemd-shared.a/virt.o .libs/libudev.lax/libsystemd-shared.a/watchdog.o
> | i586-poky-linux-libtool: link: ( cd ".libs" && rm -f "libsystemd-id128.la" && ln -s "../libsystemd-id128.la" "libsystemd-id128.la" )
> | i586-poky-linux-libtool: link: i586-poky-linux-gcc -m32 -march=i586 --sysroot=/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-world/build/build/tmp/sysroots/qemux86 -std=gnu99 -pipe -Wall -Wextra -Wno-inline -Wundef -Wformat=2 -Wlogical-op -Wsign-compare -Wmissing-include-dirs -Wold-style-definition -Wpointer-arith -Winit-self -Wdeclaration-after-statement -Wfloat-equal -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls -Wmissing-declarations -Wmissing-noreturn -Wshadow -Wendif-labels -Wcast-align -Wstrict-aliasing=2 -Wwrite-strings -Wno-long-long -Wno-overlength-strings -Wno-unused-parameter -Wno-missing-field-initializers -Wno-unused-result -Werror=overflow -ffast-math -fno-common -fdiagnostics-show-option -fno-strict-aliasing -fvisibility=hidden -ffunction-sections -fdata-sections -fstack-protector --param=ssp-buffer-size=4 -O2 -pipe -g -feliminate-unused-debug-types -Wl,--as-needed -Wl,--gc-sections -Wl,-z -Wl,relro -Wl,-z -Wl,now -Wl,-O1 -Wl,--hash-style=gnu
 -Wl,--as-needed -o test-cgroup src/test/test-cgroup.o  ./.libs/libsystemd-label.a ./.libs/libsystemd-shared.a -ldl
> | i586-poky-linux-libtool: link: i586-poky-linux-gcc -m32 -march=i586 --sysroot=/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-world/build/build/tmp/sysroots/qemux86 -std=gnu99 -pipe -Wall -Wextra -Wno-inline -Wundef -Wformat=2 -Wlogical-op -Wsign-compare -Wmissing-include-dirs -Wold-style-definition -Wpointer-arith -Winit-self -Wdeclaration-after-statement -Wfloat-equal -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls -Wmissing-declarations -Wmissing-noreturn -Wshadow -Wendif-labels -Wcast-align -Wstrict-aliasing=2 -Wwrite-strings -Wno-long-long -Wno-overlength-strings -Wno-unused-parameter -Wno-missing-field-initializers -Wno-unused-result -Werror=overflow -ffast-math -fno-common -fdiagnostics-show-option -fno-strict-aliasing -fvisibility=hidden -ffunction-sections -fdata-sections -fstack-protector --param=ssp-buffer-size=4 -O2 -pipe -g -feliminate-unused-debug-types -Wl,--as-needed -Wl,--gc-sections -Wl,-z -Wl,relro -Wl,-z -Wl,now -Wl,-O1 -Wl,--hash-style=gnu
 -Wl,--as-needed -o test-env-replace src/test/test-env-replace.o  ./.libs/libsystemd-shared.a -ldl
> | i586-poky-linux-libtool: link: i586-poky-linux-ar cru .libs/libsystemd-logs.a src/shared/.libs/libsystemd_logs_la-logs-show.o   .libs/libsystemd-logs.lax/libsystemd-journal-internal.a/libsystemd_journal_internal_la-fsprg.o .libs/libsystemd-logs.lax/libsystemd-journal-internal.a/libsystemd_journal_internal_la-journal-authenticate.o .libs/libsystemd-logs.lax/libsystemd-journal-internal.a/libsystemd_journal_internal_la-journal-file.o .libs/libsystemd-logs.lax/libsystemd-journal-internal.a/libsystemd_journal_internal_la-journal-send.o .libs/libsystemd-logs.lax/libsystemd-journal-internal.a/libsystemd_journal_internal_la-journal-vacuum.o .libs/libsystemd-logs.lax/libsystemd-journal-internal.a/libsystemd_journal_internal_la-journal-verify.o .libs/libsystemd-logs.lax/libsystemd-journal-internal.a/libsystemd_journal_internal_la-lookup3.o .libs/libsystemd-logs.lax/libsystemd-journal-internal.a/libsystemd_journal_internal_la-mmap-cache.o .libs/libsystemd-logs.lax/libsystemd-journal-internal
.a/libsystemd_journal_internal_la-sd-journal.o  .libs/libsystemd-logs.lax/libsystemd-id128-internal.a/sd-id128.o  .libs/libsystemd-logs.lax/libsystemd-shared.a/cgroup-show.o .libs/libsystemd-logs.lax/libsystemd-shared.a/cgroup-util.o .libs/libsystemd-logs.lax/libsystemd-shared.a/conf-files.o .libs/libsystemd-logs.lax/libsystemd-shared.a/conf-parser.o .libs/libsystemd-logs.lax/libsystemd-shared.a/exit-status.o .libs/libsystemd-logs.lax/libsystemd-shared.a/hashmap.o .libs/libsystemd-logs.lax/libsystemd-shared.a/hwclock.o .libs/libsystemd-logs.lax/libsystemd-shared.a/log.o .libs/libsystemd-logs.lax/libsystemd-shared.a/pager.o .libs/libsystemd-logs.lax/libsystemd-shared.a/path-util.o .libs/libsystemd-logs.lax/libsystemd-shared.a/ratelimit.o .libs/libsystemd-logs.lax/libsystemd-shared.a/set.o .libs/libsystemd-logs.lax/libsystemd-shared.a/socket-util.o .libs/libsystemd-logs.lax/libsystemd-shared.a/spawn-ask-password-agent.o .libs/libsystemd-logs.lax/libsystemd-shared.a/spawn-polkit-agent.o 
.libs/libsystemd-logs.lax/libsystemd-shared.a/specifier.o .libs/libsystemd-logs.lax/libsystemd-shared.a/strbuf.o .libs/libsystemd-logs.lax/libsystemd-shared.a/strv.o .libs/libsystemd-logs.lax/libsystemd-shared.a/unit-name.o .libs/libsystemd-logs.lax/libsystemd-shared.a/utf8.o .libs/libsystemd-logs.lax/libsystemd-shared.a/util.o .libs/libsystemd-logs.lax/libsystemd-shared.a/utmp-wtmp.o .libs/libsystemd-logs.lax/libsystemd-shared.a/virt.o .libs/libsystemd-logs.lax/libsystemd-shared.a/watchdog.o
> | i586-poky-linux-libtool: link: i586-poky-linux-gcc -m32 -march=i586 --sysroot=/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-world/build/build/tmp/sysroots/qemux86 -std=gnu99 -pipe -Wall -Wextra -Wno-inline -Wundef -Wformat=2 -Wlogical-op -Wsign-compare -Wmissing-include-dirs -Wold-style-definition -Wpointer-arith -Winit-self -Wdeclaration-after-statement -Wfloat-equal -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls -Wmissing-declarations -Wmissing-noreturn -Wshadow -Wendif-labels -Wcast-align -Wstrict-aliasing=2 -Wwrite-strings -Wno-long-long -Wno-overlength-strings -Wno-unused-parameter -Wno-missing-field-initializers -Wno-unused-result -Werror=overflow -ffast-math -fno-common -fdiagnostics-show-option -fno-strict-aliasing -fvisibility=hidden -ffunction-sections -fdata-sections -fstack-protector --param=ssp-buffer-size=4 -O2 -pipe -g -feliminate-unused-debug-types -Wl,--as-needed -Wl,--gc-sections -Wl,-z -Wl,relro -Wl,-z -Wl,now -Wl,-O1 -Wl,--hash-style=gnu
 -Wl,--as-needed -o test-strv src/test/test-strv.o  ./.libs/libsystemd-shared.a -ldl
> | i586-poky-linux-libtool: link: i586-poky-linux-gcc -m32 -march=i586 --sysroot=/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-world/build/build/tmp/sysroots/qemux86 -std=gnu99 -pipe -Wall -Wextra -Wno-inline -Wundef -Wformat=2 -Wlogical-op -Wsign-compare -Wmissing-include-dirs -Wold-style-definition -Wpointer-arith -Winit-self -Wdeclaration-after-statement -Wfloat-equal -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls -Wmissing-declarations -Wmissing-noreturn -Wshadow -Wendif-labels -Wcast-align -Wstrict-aliasing=2 -Wwrite-strings -Wno-long-long -Wno-overlength-strings -Wno-unused-parameter -Wno-missing-field-initializers -Wno-unused-result -Werror=overflow -ffast-math -fno-common -fdiagnostics-show-option -fno-strict-aliasing -fvisibility=hidden -ffunction-sections -fdata-sections -fstack-protector --param=ssp-buffer-size=4 -O2 -pipe -g -feliminate-unused-debug-types -Wl,--as-needed -Wl,--gc-sections -Wl,-z -Wl,relro -Wl,-z -Wl,now -Wl,-O1 -Wl,--hash-style=gnu
 -Wl,--as-needed -o test-watchdog src/test/test-watchdog.o  ./.libs/libsystemd-shared.a -ldl
> | i586-poky-linux-libtool: link: i586-poky-linux-gcc -m32 -march=i586 --sysroot=/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-world/build/build/tmp/sysroots/qemux86 -std=gnu99 -pipe -Wall -Wextra -Wno-inline -Wundef -Wformat=2 -Wlogical-op -Wsign-compare -Wmissing-include-dirs -Wold-style-definition -Wpointer-arith -Winit-self -Wdeclaration-after-statement -Wfloat-equal -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls -Wmissing-declarations -Wmissing-noreturn -Wshadow -Wendif-labels -Wcast-align -Wstrict-aliasing=2 -Wwrite-strings -Wno-long-long -Wno-overlength-strings -Wno-unused-parameter -Wno-missing-field-initializers -Wno-unused-result -Werror=overflow -ffast-math -fno-common -fdiagnostics-show-option -fno-strict-aliasing -fvisibility=hidden -ffunction-sections -fdata-sections -fstack-protector --param=ssp-buffer-size=4 -O2 -pipe -g -feliminate-unused-debug-types -Wl,--as-needed -Wl,--gc-sections -Wl,-z -Wl,relro -Wl,-z -Wl,now -Wl,-O1 -Wl,--hash-style=gnu
 -Wl,--as-needed -o test-id128 src/test/test-id128.o  ./.libs/libsystemd-shared.a ./.libs/libsystemd-id128-internal.a -ldl
> | i586-poky-linux-libtool: link: i586-poky-linux-gcc -m32 -march=i586 --sysroot=/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-world/build/build/tmp/sysroots/qemux86 -std=gnu99 -pipe -Wall -Wextra -Wno-inline -Wundef -Wformat=2 -Wlogical-op -Wsign-compare -Wmissing-include-dirs -Wold-style-definition -Wpointer-arith -Winit-self -Wdeclaration-after-statement -Wfloat-equal -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls -Wmissing-declarations -Wmissing-noreturn -Wshadow -Wendif-labels -Wcast-align -Wstrict-aliasing=2 -Wwrite-strings -Wno-long-long -Wno-overlength-strings -Wno-unused-parameter -Wno-missing-field-initializers -Wno-unused-result -Werror=overflow -ffast-math -fno-common -fdiagnostics-show-option -fno-strict-aliasing -fvisibility=hidden -ffunction-sections -fdata-sections -fstack-protector --param=ssp-buffer-size=4 -I/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-world/build/build/tmp/sysroots/qemux86/usr/include/dbus-1.0 -I/srv/home/pokybu
ild/yocto-autobuilder/yocto-slave/nightly-world/build/build/tmp/sysroots/qemux86/usr/lib/dbus-1.0/include -O2 -pipe -g -feliminate-unused-debug-types -Wl,--as-needed -Wl,--gc-sections -Wl,-z -Wl,relro -Wl,-z -Wl,now -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -o test-install src/test/test_install-test-install.o  ./.libs/libsystemd-units.a ./.libs/libsystemd-label.a ./.libs/libsystemd-shared.a -ldl
> | i586-poky-linux-libtool: link: i586-poky-linux-gcc -m32 -march=i586 --sysroot=/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-world/build/build/tmp/sysroots/qemux86 -std=gnu99 -pipe -Wall -Wextra -Wno-inline -Wundef -Wformat=2 -Wlogical-op -Wsign-compare -Wmissing-include-dirs -Wold-style-definition -Wpointer-arith -Winit-self -Wdeclaration-after-statement -Wfloat-equal -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls -Wmissing-declarations -Wmissing-noreturn -Wshadow -Wendif-labels -Wcast-align -Wstrict-aliasing=2 -Wwrite-strings -Wno-long-long -Wno-overlength-strings -Wno-unused-parameter -Wno-missing-field-initializers -Wno-unused-result -Werror=overflow -ffast-math -fno-common -fdiagnostics-show-option -fno-strict-aliasing -fvisibility=hidden -ffunction-sections -fdata-sections -fstack-protector --param=ssp-buffer-size=4 -O2 -pipe -g -feliminate-unused-debug-types -Wl,--as-needed -Wl,--gc-sections -Wl,-z -Wl,relro -Wl,-z -Wl,now -Wl,-O1 -Wl,--hash-style=gnu
 -Wl,--as-needed -o test-journal-syslog src/journal/test-journal-syslog.o src/journal/journald-syslog.o  ./.libs/libsystemd-shared.a ./.libs/libsystemd-journal-internal.a -L/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-world/build/build/tmp/sysroots/qemux86/usr/lib /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-world/build/build/tmp/sysroots/qemux86/usr/lib/libgcrypt.so -L=/usr/lib -lcap /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-world/build/build/tmp/sysroots/qemux86/usr/lib/libgpg-error.so ./.libs/libsystemd-id128-internal.a -ldl
> | i586-poky-linux-libtool: link: i586-poky-linux-gcc -m32 -march=i586 --sysroot=/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-world/build/build/tmp/sysroots/qemux86 -std=gnu99 -pipe -Wall -Wextra -Wno-inline -Wundef -Wformat=2 -Wlogical-op -Wsign-compare -Wmissing-include-dirs -Wold-style-definition -Wpointer-arith -Winit-self -Wdeclaration-after-statement -Wfloat-equal -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls -Wmissing-declarations -Wmissing-noreturn -Wshadow -Wendif-labels -Wcast-align -Wstrict-aliasing=2 -Wwrite-strings -Wno-long-long -Wno-overlength-strings -Wno-unused-parameter -Wno-missing-field-initializers -Wno-unused-result -Werror=overflow -ffast-math -fno-common -fdiagnostics-show-option -fno-strict-aliasing -fvisibility=hidden -ffunction-sections -fdata-sections -fstack-protector --param=ssp-buffer-size=4 -O2 -pipe -g -feliminate-unused-debug-types -Wl,--as-needed -Wl,--gc-sections -Wl,-z -Wl,relro -Wl,-z -Wl,now -Wl,-O1 -Wl,--hash-style=gnu
 -Wl,--as-needed -o test-journal-send src/journal/test-journal-send.o  ./.libs/libsystemd-shared.a ./.libs/libsystemd-journal-internal.a -L/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-world/build/build/tmp/sysroots/qemux86/usr/lib /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-world/build/build/tmp/sysroots/qemux86/usr/lib/libgcrypt.so -L=/usr/lib -lcap /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-world/build/build/tmp/sysroots/qemux86/usr/lib/libgpg-error.so ./.libs/libsystemd-id128-internal.a -ldl
> | i586-poky-linux-libtool: link: i586-poky-linux-gcc -m32 -march=i586 --sysroot=/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-world/build/build/tmp/sysroots/qemux86 -std=gnu99 -pipe -Wall -Wextra -Wno-inline -Wundef -Wformat=2 -Wlogical-op -Wsign-compare -Wmissing-include-dirs -Wold-style-definition -Wpointer-arith -Winit-self -Wdeclaration-after-statement -Wfloat-equal -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls -Wmissing-declarations -Wmissing-noreturn -Wshadow -Wendif-labels -Wcast-align -Wstrict-aliasing=2 -Wwrite-strings -Wno-long-long -Wno-overlength-strings -Wno-unused-parameter -Wno-missing-field-initializers -Wno-unused-result -Werror=overflow -ffast-math -fno-common -fdiagnostics-show-option -fno-strict-aliasing -fvisibility=hidden -ffunction-sections -fdata-sections -fstack-protector --param=ssp-buffer-size=4 -O2 -pipe -g -feliminate-unused-debug-types -Wl,--as-needed -Wl,--gc-sections -Wl,-z -Wl,relro -Wl,-z -Wl,now -Wl,-O1 -Wl,--hash-style=gnu
 -Wl,--as-needed -o test-journal src/journal/test-journal.o  ./.libs/libsystemd-shared.a ./.libs/libsystemd-journal-internal.a -L/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-world/build/build/tmp/sysroots/qemux86/usr/lib /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-world/build/build/tmp/sysroots/qemux86/usr/lib/libgcrypt.so -L=/usr/lib -lcap /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-world/build/build/tmp/sysroots/qemux86/usr/lib/libgpg-error.so ./.libs/libsystemd-id128-internal.a -ldl
> | i586-poky-linux-libtool: link: i586-poky-linux-gcc -m32 -march=i586 --sysroot=/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-world/build/build/tmp/sysroots/qemux86 -std=gnu99 -pipe -Wall -Wextra -Wno-inline -Wundef -Wformat=2 -Wlogical-op -Wsign-compare -Wmissing-include-dirs -Wold-style-definition -Wpointer-arith -Winit-self -Wdeclaration-after-statement -Wfloat-equal -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls -Wmissing-declarations -Wmissing-noreturn -Wshadow -Wendif-labels -Wcast-align -Wstrict-aliasing=2 -Wwrite-strings -Wno-long-long -Wno-overlength-strings -Wno-unused-parameter -Wno-missing-field-initializers -Wno-unused-result -Werror=overflow -ffast-math -fno-common -fdiagnostics-show-option -fno-strict-aliasing -fvisibility=hidden -ffunction-sections -fdata-sections -fstack-protector --param=ssp-buffer-size=4 -O2 -pipe -g -feliminate-unused-debug-types -Wl,--as-needed -Wl,--gc-sections -Wl,-z -Wl,relro -Wl,-z -Wl,now -Wl,-O1 -Wl,--hash-style=gnu
 -Wl,--as-needed -o .libs/test-daemon src/test/test-daemon.o  ./.libs/libsystemd-shared.a ./.libs/libsystemd-daemon.so -ldl
> | i586-poky-linux-libtool: link: i586-poky-linux-ranlib .libs/libudev-private.a
> | i586-poky-linux-libtool: link: i586-poky-linux-ranlib .libs/libsystemd-logs.a
> | i586-poky-linux-libtool: link: i586-poky-linux-ranlib .libs/libudev.a
> | i586-poky-linux-libtool: link: rm -fr .libs/libudev-private.lax
> | i586-poky-linux-libtool: link: rm -fr .libs/libsystemd-logs.lax
> | i586-poky-linux-libtool: link: rm -fr .libs/libudev.lax
> | i586-poky-linux-libtool: link: ( cd ".libs" && rm -f "libudev-private.la" && ln -s "../libudev-private.la" "libudev-private.la" )
> | i586-poky-linux-libtool: link: ( cd ".libs" && rm -f "libsystemd-logs.la" && ln -s "../libsystemd-logs.la" "libsystemd-logs.la" )
> | i586-poky-linux-libtool: link: ( cd ".libs" && rm -f "libudev.la" && ln -s "../libudev.la" "libudev.la" )
> | ./.libs/libsystemd-daemon.so: undefined reference to `mq_getattr'
> | collect2: error: ld returned 1 exit status
> | make[2]: *** [test-daemon] Error 1
> | rm units/console-shell.service.m4 src/core/org.freedesktop.systemd1.policy.in units/rescue.service.m4 units/console-getty.service.m4
> | make[1]: *** [all-recursive] Error 1
> | make: *** [all] Error 2
> | ERROR: oe_runmake failed
> | ERROR: Function failed: do_compile (see /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-world/build/build/tmp/work/i586-poky-linux/systemd/git-r12/temp/log.do_compile.7045 for further information)
> NOTE: recipe systemd-git-r12: task do_compile: Failed
> ERROR: Task 9123 (/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-world/build/meta/recipes-core/systemd/systemd_git.bb, do_compile) failed with exit code '1'


This was with the eglibc 2.17, so I am not sure that's related or not, I 
have cc'ed Khem, since none of the other AB build systemd code this is 
the first time it's seeing it.

Sau!


> The following changes since commit 7e1f8faad0c4b6f490c26f87acc698dd6e002b15:
>
>    perl: Remove bashism from perl-tests.inc (2013-01-07 22:37:37 +0000)
>
> are available in the git repository at:
>
>    git://git.yoctoproject.org/poky-contrib rmoisan/systemd
>    http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=rmoisan/systemd
>
> Enrico Scholz (1):
>    systemd: move disable operation into prerm() script
>
> Holger Hans Peter Freyther (2):
>    systemd: Make the main systemd files proper CONFFILES
>    systemd: Introduce a create-volatile to create tmp directories
>
> Khem Raj (1):
>    systemd: Fix build when base_libdir is not /lib
>
> Martin Donnelly (2):
>    cgroups: Add INSANE_SKIP to avoid warning about .so file
>    systemd: Remove sysvinit mount related services if systemd is enabled
>
> Martin Jansa (2):
>    systemd: fix FILESPATH to find systemctl
>    systemd: add PACKAGES_DYNAMIC
>
> Radu Moisan (13):
>    default-distrovars: Add DISTRO_FEATURES_INITMAN to DISTRO_FEATURES
>    default-providers: Automatically set PREFERRED_PROVIDER_udev
>    systemd: initial integration
>    systemd: Add systemd_base.bbclass
>    systemd: Add systemd option to PREFERRED_PROVIDER_udev
>    systemd: set default.target to multi-user.target
>    systemd: update FILESPATH with *-native directory
>    systemd: disable sysfs.service
>    systemd: Add systemd-compat-units
>    systemd: Add avahi to packagegroup-core-boot
>    xserver-nodm-init: Enable systemd support
>    util-linux: Enable systemd support
>    systemd: Disable xz when building with GPLv3 incompatibility flag
>
>   meta/classes/systemd.bbclass                       |    1 +
>   meta/classes/systemd_base.bbclass                  |  218 +++++++++++++
>   meta/conf/distro/include/default-distrovars.inc    |    3 +-
>   meta/conf/distro/include/default-providers.inc     |    1 +
>   meta/recipes-bsp/keymaps/files/keymaps.service     |    9 +
>   meta/recipes-bsp/keymaps/keymaps_1.0.bb            |    9 +-
>   meta/recipes-connectivity/avahi/avahi.inc          |   23 +-
>   meta/recipes-connectivity/connman/connman.inc      |    6 +
>   meta/recipes-connectivity/connman/connman_1.4.bb   |    3 +-
>   meta/recipes-connectivity/dhcp/dhcp.inc            |   15 +-
>   meta/recipes-connectivity/dhcp/files/dhcpd.service |   12 +
>   .../dhcp/files/dhcrelay.service                    |   10 +
>   .../openssh/openssh-6.0p1/sshd.socket              |   11 +
>   .../openssh/openssh-6.0p1/sshd@.service            |    9 +
>   .../openssh/openssh-6.0p1/sshdgenkeys.service      |   10 +
>   meta/recipes-connectivity/openssh/openssh_6.0p1.bb |   14 +-
>   .../wpa-supplicant/wpa-supplicant-1.0.inc          |   74 +++--
>   .../wpa-supplicant/wpa-supplicant_1.0.bb           |    2 +-
>   meta/recipes-core/busybox/busybox.inc              |   18 ++
>   meta/recipes-core/busybox/busybox_1.20.2.bb        |    4 +-
>   .../busybox/files/busybox-klogd.service.in         |    8 +
>   .../busybox/files/busybox-syslog.service.in        |   13 +
>   meta/recipes-core/dropbear/dropbear.inc            |   81 ++---
>   .../recipes-core/dropbear/dropbear/dropbear.socket |   10 +
>   .../dropbear/dropbear/dropbear@.service            |    9 +
>   .../dropbear/dropbear/dropbearkey.service          |   10 +
>   .../initscripts-1.0/{urandom => urandom.sh}        |    0
>   meta/recipes-core/initscripts/initscripts_1.0.bb   |  164 +++++-----
>   meta/recipes-core/libcgroup/libcgroup_0.37.1.bb    |    1 +
>   .../packagegroups/packagegroup-base.bb             |    3 +-
>   .../packagegroups/packagegroup-core-boot.bb        |    9 +-
>   meta/recipes-core/systemd/systemd-compat-units.bb  |   59 ++++
>   .../systemd/systemd-compat-units/machineid.service |   16 +
>   .../systemd-compat-units/run-postinsts.service     |   17 +
>   .../systemd/systemd-machine-units_1.0.bb           |   14 +
>   meta/recipes-core/systemd/systemd-serialgetty.bb   |   46 +++
>   .../systemd/systemd-serialgetty/LICENSE            |  339 ++++++++++++++++++++
>   .../systemd-serialgetty/serial-getty@.service      |   32 ++
>   meta/recipes-core/systemd/systemd-speed-hacks.bb   |   18 ++
>   .../systemd/systemd-systemctl-native.bb            |   20 ++
>   .../systemd/systemd-systemctl-native/systemctl     |  126 ++++++++
>   .../systemd/systemd/create-volatile.conf           |   10 +
>   meta/recipes-core/systemd/systemd/gtk-doc.make     |  230 +++++++++++++
>   meta/recipes-core/systemd/systemd/modprobe.rules   |   17 +
>   .../systemd/systemd/optional_secure_getenv.patch   |   19 ++
>   .../systemd/set_default_target_to_multi-user.patch |   13 +
>   .../systemd-pam-configure-check-uclibc.patch       |   26 ++
>   .../systemd/systemd/systemd-pam-fix-execvpe.patch  |   26 ++
>   .../systemd/systemd-pam-fix-fallocate.patch        |   82 +++++
>   .../systemd/systemd-pam-fix-getty-unit.patch       |   35 ++
>   .../systemd/systemd/systemd-pam-fix-mkostemp.patch |  166 ++++++++++
>   .../systemd/systemd/systemd-pam-fix-msformat.patch |  335 +++++++++++++++++++
>   .../recipes-core/systemd/systemd/touchscreen.rules |   18 ++
>   meta/recipes-core/systemd/systemd/var-run.conf     |    4 +
>   meta/recipes-core/systemd/systemd_git.bb           |  252 +++++++++++++++
>   meta/recipes-core/util-linux/util-linux.inc        |   11 +-
>   meta/recipes-extended/cronie/cronie/crond.service  |   10 +
>   meta/recipes-extended/cronie/cronie_1.4.8.bb       |   10 +-
>   .../lighttpd/files/lighttpd.service                |   13 +
>   meta/recipes-extended/lighttpd/lighttpd_1.4.32.bb  |   11 +-
>   meta/recipes-extended/pam/libpam_1.1.6.bb          |    3 +
>   meta/recipes-extended/polkit/polkit_0.104.bb       |    9 +-
>   meta/recipes-graphics/x11-common/x11-common_0.1.bb |    4 +-
>   .../x11-common/xserver-nodm-init.bb                |   19 +-
>   .../x11-common/xserver-nodm-init/xserver-nodm.conf |    1 +
>   .../xserver-nodm-init/xserver-nodm.service         |    9 +
>   66 files changed, 2606 insertions(+), 174 deletions(-)
>   create mode 100644 meta/classes/systemd.bbclass
>   create mode 100644 meta/classes/systemd_base.bbclass
>   create mode 100644 meta/recipes-bsp/keymaps/files/keymaps.service
>   create mode 100644 meta/recipes-connectivity/dhcp/files/dhcpd.service
>   create mode 100644 meta/recipes-connectivity/dhcp/files/dhcrelay.service
>   create mode 100644 meta/recipes-connectivity/openssh/openssh-6.0p1/sshd.socket
>   create mode 100644 meta/recipes-connectivity/openssh/openssh-6.0p1/sshd@.service
>   create mode 100644 meta/recipes-connectivity/openssh/openssh-6.0p1/sshdgenkeys.service
>   create mode 100644 meta/recipes-core/busybox/files/busybox-klogd.service.in
>   create mode 100644 meta/recipes-core/busybox/files/busybox-syslog.service.in
>   create mode 100644 meta/recipes-core/dropbear/dropbear/dropbear.socket
>   create mode 100644 meta/recipes-core/dropbear/dropbear/dropbear@.service
>   create mode 100644 meta/recipes-core/dropbear/dropbear/dropbearkey.service
>   rename meta/recipes-core/initscripts/initscripts-1.0/{urandom => urandom.sh} (100%)
>   create mode 100644 meta/recipes-core/systemd/systemd-compat-units.bb
>   create mode 100644 meta/recipes-core/systemd/systemd-compat-units/machineid.service
>   create mode 100644 meta/recipes-core/systemd/systemd-compat-units/run-postinsts.service
>   create mode 100644 meta/recipes-core/systemd/systemd-machine-units_1.0.bb
>   create mode 100644 meta/recipes-core/systemd/systemd-serialgetty.bb
>   create mode 100644 meta/recipes-core/systemd/systemd-serialgetty/LICENSE
>   create mode 100644 meta/recipes-core/systemd/systemd-serialgetty/serial-getty@.service
>   create mode 100644 meta/recipes-core/systemd/systemd-speed-hacks.bb
>   create mode 100644 meta/recipes-core/systemd/systemd-systemctl-native.bb
>   create mode 100755 meta/recipes-core/systemd/systemd-systemctl-native/systemctl
>   create mode 100644 meta/recipes-core/systemd/systemd/create-volatile.conf
>   create mode 100644 meta/recipes-core/systemd/systemd/gtk-doc.make
>   create mode 100644 meta/recipes-core/systemd/systemd/modprobe.rules
>   create mode 100644 meta/recipes-core/systemd/systemd/optional_secure_getenv.patch
>   create mode 100644 meta/recipes-core/systemd/systemd/set_default_target_to_multi-user.patch
>   create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-configure-check-uclibc.patch
>   create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-execvpe.patch
>   create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-fallocate.patch
>   create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-getty-unit.patch
>   create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-mkostemp.patch
>   create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-msformat.patch
>   create mode 100644 meta/recipes-core/systemd/systemd/touchscreen.rules
>   create mode 100644 meta/recipes-core/systemd/systemd/var-run.conf
>   create mode 100644 meta/recipes-core/systemd/systemd_git.bb
>   create mode 100644 meta/recipes-extended/cronie/cronie/crond.service
>   create mode 100644 meta/recipes-extended/lighttpd/files/lighttpd.service
>   create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf
>   create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service
>
Khem Raj - Jan. 9, 2013, 5:11 p.m.
On Wed, Jan 9, 2013 at 8:51 AM, Saul Wold <sgw@linux.intel.com> wrote:
>> | ./.libs/libsystemd-daemon.so: undefined reference to `mq_getattr'
>> | collect2: error: ld returned 1 exit status
>> | make[2]: *** [test-daemon] Error 1
>> | rm units/console-shell.service.m4
>> src/core/org.freedesktop.systemd1.policy.in units/rescue.service.m4
>> units/console-getty.service.m4
>> | make[1]: *** [all-recursive] Error 1
>> | make: *** [all] Error 2
>> | ERROR: oe_runmake failed
>> | ERROR: Function failed: do_compile (see
>> /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-world/build/build/tmp/work/i586-poky-linux/systemd/git-r12/temp/log.do_compile.7045
>> for further information)
>> NOTE: recipe systemd-git-r12: task do_compile: Failed
>> ERROR: Task 9123
>> (/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-world/build/meta/recipes-core/systemd/systemd_git.bb,
>> do_compile) failed with exit code '1'
>
>
>
> This was with the eglibc 2.17, so I am not sure that's related or not, I
> have cc'ed Khem, since none of the other AB build systemd code this is the
> first time it's seeing it.

I dont see this error when I use systemd from meta-systemd so
something is missing here. Secondly I did see this with udev_182 which
has a fix in my eglibc series. You need same fix here too but I would
first like to find out why this is not needed in meta-systemd but
needed with this patchset.
Khem Raj - Jan. 9, 2013, 5:12 p.m.
On Tue, Jan 8, 2013 at 7:01 AM, Radu Moisan <radu.moisan@intel.com> wrote:
> Was this removal done on purpose?
>
>
> I had to port the patch manually so I guess it got lost then. Do we want to
> have Sign-off-by from author as well?
>

absolutely thats the purpose of SOB to track to certificate of origin
you should have git am'ed the patches and then fixed them to resolve
and added your SOB after the orignal SOB
Khem Raj - Jan. 9, 2013, 5:14 p.m.
On Tue, Jan 8, 2013 at 4:24 AM, Radu Moisan <radu.moisan@intel.com> wrote:
> As Ross suggested I've done the following changes to the previous set:
> * added two patches (the first two) that address multiple init systems support,\
> as in shifting from default hardcoded sysvinit to something more generic while
> the default values still remains on sysvinit
> * moved automatic setting of PREFERRED_PROVIDER_udev into default_providers.inc
> * removed ahavi-systemd since all it provided was service files; now service files
> are pulled in by avahi-daemon
> * also rebased on master
>

btw. there has been more merges into meta-systemd in meta-openembedded
since these patches were created I cant accertain
that you picked those too but please redo this series so the history
is a bit better for tracking purposes.
Radu Moisan - Jan. 10, 2013, 8:02 a.m.
On 01/09/2013 07:14 PM, Khem Raj wrote:
> On Tue, Jan 8, 2013 at 4:24 AM, Radu Moisan <radu.moisan@intel.com> wrote:
>> As Ross suggested I've done the following changes to the previous set:
>> * added two patches (the first two) that address multiple init systems support,\
>> as in shifting from default hardcoded sysvinit to something more generic while
>> the default values still remains on sysvinit
>> * moved automatic setting of PREFERRED_PROVIDER_udev into default_providers.inc
>> * removed ahavi-systemd since all it provided was service files; now service files
>> are pulled in by avahi-daemon
>> * also rebased on master
>>
> btw. there has been more merges into meta-systemd in meta-openembedded
> since these patches were created I cant accertain
> that you picked those too but please redo this series so the history
> is a bit better for tracking purposes.
I've tried to get in sync with meta-openembedded until they upgraded 
systemd to v196. I tried to upgrade but something changed in the latest 
version and dbus-daemon didn't start anymore and because of that a few 
other services depending on it. I spent some time debugging it but 
eventually I decided we should go with the previous version and address 
the update after we merge. More details about this at 
https://bugzilla.yoctoproject.org/show_bug.cgi?id=1625

Radu
Khem Raj - Jan. 10, 2013, 6:27 p.m.
On Thu, Jan 10, 2013 at 12:02 AM, Radu Moisan <radu.moisan@intel.com> wrote:
>
> On 01/09/2013 07:14 PM, Khem Raj wrote:
>>
>> On Tue, Jan 8, 2013 at 4:24 AM, Radu Moisan <radu.moisan@intel.com> wrote:
>>>
>>> As Ross suggested I've done the following changes to the previous set:
>>> * added two patches (the first two) that address multiple init systems
>>> support,\
>>> as in shifting from default hardcoded sysvinit to something more generic
>>> while
>>> the default values still remains on sysvinit
>>> * moved automatic setting of PREFERRED_PROVIDER_udev into
>>> default_providers.inc
>>> * removed ahavi-systemd since all it provided was service files; now
>>> service files
>>> are pulled in by avahi-daemon
>>> * also rebased on master
>>>
>> btw. there has been more merges into meta-systemd in meta-openembedded
>> since these patches were created I cant accertain
>> that you picked those too but please redo this series so the history
>> is a bit better for tracking purposes.
>
> I've tried to get in sync with meta-openembedded until they upgraded systemd
> to v196.

hmm that would also explain the -lrt problem that Saul is seeing but I dont.

 I tried to upgrade but something changed in the latest version and
> dbus-daemon didn't start anymore and because of that a few other services
> depending on it. I spent some time debugging it but eventually I decided we
> should go with the previous version and address the update after we merge.
> More details about this at
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=1625

but we have to fix it I think weather you merge it or not since I dont  expect
us to stay at 195 forever and especially when folks who use meta-systemd
are already using 196 we wont be able to discard meta-systemd.

>
> Radu
Radu Moisan - Jan. 11, 2013, 3:12 p.m.
On 01/10/2013 08:27 PM, Khem Raj wrote:
> On Thu, Jan 10, 2013 at 12:02 AM, Radu Moisan <radu.moisan@intel.com> wrote:
>> On 01/09/2013 07:14 PM, Khem Raj wrote:
>>> On Tue, Jan 8, 2013 at 4:24 AM, Radu Moisan <radu.moisan@intel.com> wrote:
>>>> As Ross suggested I've done the following changes to the previous set:
>>>> * added two patches (the first two) that address multiple init systems
>>>> support,\
>>>> as in shifting from default hardcoded sysvinit to something more generic
>>>> while
>>>> the default values still remains on sysvinit
>>>> * moved automatic setting of PREFERRED_PROVIDER_udev into
>>>> default_providers.inc
>>>> * removed ahavi-systemd since all it provided was service files; now
>>>> service files
>>>> are pulled in by avahi-daemon
>>>> * also rebased on master
>>>>
>>> btw. there has been more merges into meta-systemd in meta-openembedded
>>> since these patches were created I cant accertain
>>> that you picked those too but please redo this series so the history
>>> is a bit better for tracking purposes.
>> I've tried to get in sync with meta-openembedded until they upgraded systemd
>> to v196.
> hmm that would also explain the -lrt problem that Saul is seeing but I dont.
>

Not quite, the problem Soul is seeing is probably because he is using 
eglibc v2.17
I'm running a world build right now (with eglibc v2.16) and I don't see 
those problems.

>   I tried to upgrade but something changed in the latest version and
>> dbus-daemon didn't start anymore and because of that a few other services
>> depending on it. I spent some time debugging it but eventually I decided we
>> should go with the previous version and address the update after we merge.
>> More details about this at
>> https://bugzilla.yoctoproject.org/show_bug.cgi?id=1625
> but we have to fix it I think weather you merge it or not since I dont  expect
> us to stay at 195 forever and especially when folks who use meta-systemd
> are already using 196 we wont be able to discard meta-systemd.

It's not a question of fixing it or not, rather of when will we fix it. 
My approach was to have a buildable version
that is also stable at runtime and merge that into oe-core. The we will 
address systemd upgrade as a normal
package upgrate, since package upgrade is routine task anyway and we do 
it for all packages.
I also took a look over latest patches on meta-openembedded since 
systemd update, and there aren't that many changes that are relevant to 
oe-core. Any way I'll get back with a new separate branch for review 
(with systemd v196).

Radu
Saul Wold - Jan. 11, 2013, 5:45 p.m.
On 01/11/2013 07:12 AM, Radu Moisan wrote:
>
> On 01/10/2013 08:27 PM, Khem Raj wrote:
>> On Thu, Jan 10, 2013 at 12:02 AM, Radu Moisan <radu.moisan@intel.com>
>> wrote:
>>> On 01/09/2013 07:14 PM, Khem Raj wrote:
>>>> On Tue, Jan 8, 2013 at 4:24 AM, Radu Moisan <radu.moisan@intel.com>
>>>> wrote:
>>>>> As Ross suggested I've done the following changes to the previous set:
>>>>> * added two patches (the first two) that address multiple init systems
>>>>> support,\
>>>>> as in shifting from default hardcoded sysvinit to something more
>>>>> generic
>>>>> while
>>>>> the default values still remains on sysvinit
>>>>> * moved automatic setting of PREFERRED_PROVIDER_udev into
>>>>> default_providers.inc
>>>>> * removed ahavi-systemd since all it provided was service files; now
>>>>> service files
>>>>> are pulled in by avahi-daemon
>>>>> * also rebased on master
>>>>>
>>>> btw. there has been more merges into meta-systemd in meta-openembedded
>>>> since these patches were created I cant accertain
>>>> that you picked those too but please redo this series so the history
>>>> is a bit better for tracking purposes.
>>> I've tried to get in sync with meta-openembedded until they upgraded
>>> systemd
>>> to v196.
>> hmm that would also explain the -lrt problem that Saul is seeing but I
>> dont.
>>
>
> Not quite, the problem Soul is seeing is probably because he is using
> eglibc v2.17
> I'm running a world build right now (with eglibc v2.16) and I don't see
> those problems.
>

Radu, you I was testing with 2.17, and we need to prepare for the 2.17 
update occuring, if it occurs before systemd or after these fixes will 
be needed to happen.

>>   I tried to upgrade but something changed in the latest version and
>>> dbus-daemon didn't start anymore and because of that a few other
>>> services
>>> depending on it. I spent some time debugging it but eventually I
>>> decided we
>>> should go with the previous version and address the update after we
>>> merge.
>>> More details about this at
>>> https://bugzilla.yoctoproject.org/show_bug.cgi?id=1625
>> but we have to fix it I think weather you merge it or not since I
>> dont  expect
>> us to stay at 195 forever and especially when folks who use meta-systemd
>> are already using 196 we wont be able to discard meta-systemd.
>
> It's not a question of fixing it or not, rather of when will we fix it.
> My approach was to have a buildable version
> that is also stable at runtime and merge that into oe-core. The we will
> address systemd upgrade as a normal
> package upgrate, since package upgrade is routine task anyway and we do
> it for all packages.
As mentioned above, we will need the updated version of systemd & 
friends before we can update eglibc, we want both systemd and eglibc in 
for the M3 build.

> I also took a look over latest patches on meta-openembedded since
> systemd update, and there aren't that many changes that are relevant to
> oe-core. Any way I'll get back with a new separate branch for review
> (with systemd v196).
>
> Radu
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
Saul Wold - Jan. 11, 2013, 11:23 p.m.
On 01/08/2013 04:24 AM, Radu Moisan wrote:
> As Ross suggested I've done the following changes to the previous set:
> * added two patches (the first two) that address multiple init systems support,\
> as in shifting from default hardcoded sysvinit to something more generic while
> the default values still remains on sysvinit
> * moved automatic setting of PREFERRED_PROVIDER_udev into default_providers.inc
> * removed ahavi-systemd since all it provided was service files; now service files
> are pulled in by avahi-daemon
> * also rebased on master
>
> The following changes since commit 7e1f8faad0c4b6f490c26f87acc698dd6e002b15:
>
>    perl: Remove bashism from perl-tests.inc (2013-01-07 22:37:37 +0000)
>
> are available in the git repository at:
>
>    git://git.yoctoproject.org/poky-contrib rmoisan/systemd
>    http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=rmoisan/systemd
>
> Enrico Scholz (1):
>    systemd: move disable operation into prerm() script
>
> Holger Hans Peter Freyther (2):
>    systemd: Make the main systemd files proper CONFFILES
>    systemd: Introduce a create-volatile to create tmp directories
White space 4 spaces vs tab

>
> Khem Raj (1):
>    systemd: Fix build when base_libdir is not /lib
>
> Martin Donnelly (2):
>    cgroups: Add INSANE_SKIP to avoid warning about .so file
>    systemd: Remove sysvinit mount related services if systemd is enabled
>
> Martin Jansa (2):
>    systemd: fix FILESPATH to find systemctl
>    systemd: add PACKAGES_DYNAMIC
>
> Radu Moisan (13):
>    default-distrovars: Add DISTRO_FEATURES_INITMAN to DISTRO_FEATURES
>    default-providers: Automatically set PREFERRED_PROVIDER_udev
>    systemd: initial integration
I believe this was mentioned before, but can you avoid making white 
space changes, you seem to have changed tabs (which we use tabs for 
shell based functions and 4 spaces for python based functions)

Specifically, I saw some changes in wpa-supplicant-1.0.inc, busybox, 
dropbear, initscripts

For the systemd-serialgetty, can we not carry around a LICENSE file, and 
instead point to the meta/files/common-licenses for a checksum?

Also a load of the patches do not contains Signed-off-by or 
Upstream-Status tags.



>    systemd: Add systemd_base.bbclass
>    systemd: Add systemd option to PREFERRED_PROVIDER_udev
>    systemd: set default.target to multi-user.target
>    systemd: update FILESPATH with *-native directory
>    systemd: disable sysfs.service
White space changes, makes it much harder to review, please fix

>    systemd: Add systemd-compat-units
>    systemd: Add avahi to packagegroup-core-boot
>    xserver-nodm-init: Enable systemd support
>    util-linux: Enable systemd support
What's the actual change here?  Whitespace?

>    systemd: Disable xz when building with GPLv3 incompatibility flag
This should go away, I have verified that the license field in xz is 
wrong and should not contain GPLv3 since it's a build macro, not a 
runtime, and the LICENSE field pertains to packaged and installed items 
and their licenses.

Sau!


>
>   meta/classes/systemd.bbclass                       |    1 +
>   meta/classes/systemd_base.bbclass                  |  218 +++++++++++++
>   meta/conf/distro/include/default-distrovars.inc    |    3 +-
>   meta/conf/distro/include/default-providers.inc     |    1 +
>   meta/recipes-bsp/keymaps/files/keymaps.service     |    9 +
>   meta/recipes-bsp/keymaps/keymaps_1.0.bb            |    9 +-
>   meta/recipes-connectivity/avahi/avahi.inc          |   23 +-
>   meta/recipes-connectivity/connman/connman.inc      |    6 +
>   meta/recipes-connectivity/connman/connman_1.4.bb   |    3 +-
>   meta/recipes-connectivity/dhcp/dhcp.inc            |   15 +-
>   meta/recipes-connectivity/dhcp/files/dhcpd.service |   12 +
>   .../dhcp/files/dhcrelay.service                    |   10 +
>   .../openssh/openssh-6.0p1/sshd.socket              |   11 +
>   .../openssh/openssh-6.0p1/sshd@.service            |    9 +
>   .../openssh/openssh-6.0p1/sshdgenkeys.service      |   10 +
>   meta/recipes-connectivity/openssh/openssh_6.0p1.bb |   14 +-
>   .../wpa-supplicant/wpa-supplicant-1.0.inc          |   74 +++--
>   .../wpa-supplicant/wpa-supplicant_1.0.bb           |    2 +-
>   meta/recipes-core/busybox/busybox.inc              |   18 ++
>   meta/recipes-core/busybox/busybox_1.20.2.bb        |    4 +-
>   .../busybox/files/busybox-klogd.service.in         |    8 +
>   .../busybox/files/busybox-syslog.service.in        |   13 +
>   meta/recipes-core/dropbear/dropbear.inc            |   81 ++---
>   .../recipes-core/dropbear/dropbear/dropbear.socket |   10 +
>   .../dropbear/dropbear/dropbear@.service            |    9 +
>   .../dropbear/dropbear/dropbearkey.service          |   10 +
>   .../initscripts-1.0/{urandom => urandom.sh}        |    0
>   meta/recipes-core/initscripts/initscripts_1.0.bb   |  164 +++++-----
>   meta/recipes-core/libcgroup/libcgroup_0.37.1.bb    |    1 +
>   .../packagegroups/packagegroup-base.bb             |    3 +-
>   .../packagegroups/packagegroup-core-boot.bb        |    9 +-
>   meta/recipes-core/systemd/systemd-compat-units.bb  |   59 ++++
>   .../systemd/systemd-compat-units/machineid.service |   16 +
>   .../systemd-compat-units/run-postinsts.service     |   17 +
>   .../systemd/systemd-machine-units_1.0.bb           |   14 +
>   meta/recipes-core/systemd/systemd-serialgetty.bb   |   46 +++
>   .../systemd/systemd-serialgetty/LICENSE            |  339 ++++++++++++++++++++
>   .../systemd-serialgetty/serial-getty@.service      |   32 ++
>   meta/recipes-core/systemd/systemd-speed-hacks.bb   |   18 ++
>   .../systemd/systemd-systemctl-native.bb            |   20 ++
>   .../systemd/systemd-systemctl-native/systemctl     |  126 ++++++++
>   .../systemd/systemd/create-volatile.conf           |   10 +
>   meta/recipes-core/systemd/systemd/gtk-doc.make     |  230 +++++++++++++
>   meta/recipes-core/systemd/systemd/modprobe.rules   |   17 +
>   .../systemd/systemd/optional_secure_getenv.patch   |   19 ++
>   .../systemd/set_default_target_to_multi-user.patch |   13 +
>   .../systemd-pam-configure-check-uclibc.patch       |   26 ++
>   .../systemd/systemd/systemd-pam-fix-execvpe.patch  |   26 ++
>   .../systemd/systemd-pam-fix-fallocate.patch        |   82 +++++
>   .../systemd/systemd-pam-fix-getty-unit.patch       |   35 ++
>   .../systemd/systemd/systemd-pam-fix-mkostemp.patch |  166 ++++++++++
>   .../systemd/systemd/systemd-pam-fix-msformat.patch |  335 +++++++++++++++++++
>   .../recipes-core/systemd/systemd/touchscreen.rules |   18 ++
>   meta/recipes-core/systemd/systemd/var-run.conf     |    4 +
>   meta/recipes-core/systemd/systemd_git.bb           |  252 +++++++++++++++
>   meta/recipes-core/util-linux/util-linux.inc        |   11 +-
>   meta/recipes-extended/cronie/cronie/crond.service  |   10 +
>   meta/recipes-extended/cronie/cronie_1.4.8.bb       |   10 +-
>   .../lighttpd/files/lighttpd.service                |   13 +
>   meta/recipes-extended/lighttpd/lighttpd_1.4.32.bb  |   11 +-
>   meta/recipes-extended/pam/libpam_1.1.6.bb          |    3 +
>   meta/recipes-extended/polkit/polkit_0.104.bb       |    9 +-
>   meta/recipes-graphics/x11-common/x11-common_0.1.bb |    4 +-
>   .../x11-common/xserver-nodm-init.bb                |   19 +-
>   .../x11-common/xserver-nodm-init/xserver-nodm.conf |    1 +
>   .../xserver-nodm-init/xserver-nodm.service         |    9 +
>   66 files changed, 2606 insertions(+), 174 deletions(-)
>   create mode 100644 meta/classes/systemd.bbclass
>   create mode 100644 meta/classes/systemd_base.bbclass
>   create mode 100644 meta/recipes-bsp/keymaps/files/keymaps.service
>   create mode 100644 meta/recipes-connectivity/dhcp/files/dhcpd.service
>   create mode 100644 meta/recipes-connectivity/dhcp/files/dhcrelay.service
>   create mode 100644 meta/recipes-connectivity/openssh/openssh-6.0p1/sshd.socket
>   create mode 100644 meta/recipes-connectivity/openssh/openssh-6.0p1/sshd@.service
>   create mode 100644 meta/recipes-connectivity/openssh/openssh-6.0p1/sshdgenkeys.service
>   create mode 100644 meta/recipes-core/busybox/files/busybox-klogd.service.in
>   create mode 100644 meta/recipes-core/busybox/files/busybox-syslog.service.in
>   create mode 100644 meta/recipes-core/dropbear/dropbear/dropbear.socket
>   create mode 100644 meta/recipes-core/dropbear/dropbear/dropbear@.service
>   create mode 100644 meta/recipes-core/dropbear/dropbear/dropbearkey.service
>   rename meta/recipes-core/initscripts/initscripts-1.0/{urandom => urandom.sh} (100%)
>   create mode 100644 meta/recipes-core/systemd/systemd-compat-units.bb
>   create mode 100644 meta/recipes-core/systemd/systemd-compat-units/machineid.service
>   create mode 100644 meta/recipes-core/systemd/systemd-compat-units/run-postinsts.service
>   create mode 100644 meta/recipes-core/systemd/systemd-machine-units_1.0.bb
>   create mode 100644 meta/recipes-core/systemd/systemd-serialgetty.bb
>   create mode 100644 meta/recipes-core/systemd/systemd-serialgetty/LICENSE
>   create mode 100644 meta/recipes-core/systemd/systemd-serialgetty/serial-getty@.service
>   create mode 100644 meta/recipes-core/systemd/systemd-speed-hacks.bb
>   create mode 100644 meta/recipes-core/systemd/systemd-systemctl-native.bb
>   create mode 100755 meta/recipes-core/systemd/systemd-systemctl-native/systemctl
>   create mode 100644 meta/recipes-core/systemd/systemd/create-volatile.conf
>   create mode 100644 meta/recipes-core/systemd/systemd/gtk-doc.make
>   create mode 100644 meta/recipes-core/systemd/systemd/modprobe.rules
>   create mode 100644 meta/recipes-core/systemd/systemd/optional_secure_getenv.patch
>   create mode 100644 meta/recipes-core/systemd/systemd/set_default_target_to_multi-user.patch
>   create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-configure-check-uclibc.patch
>   create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-execvpe.patch
>   create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-fallocate.patch
>   create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-getty-unit.patch
>   create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-mkostemp.patch
>   create mode 100644 meta/recipes-core/systemd/systemd/systemd-pam-fix-msformat.patch
>   create mode 100644 meta/recipes-core/systemd/systemd/touchscreen.rules
>   create mode 100644 meta/recipes-core/systemd/systemd/var-run.conf
>   create mode 100644 meta/recipes-core/systemd/systemd_git.bb
>   create mode 100644 meta/recipes-extended/cronie/cronie/crond.service
>   create mode 100644 meta/recipes-extended/lighttpd/files/lighttpd.service
>   create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf
>   create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service
>
Yi Qingliang - Jan. 13, 2013, 4:27 p.m.
When add it in the oe-core?

On Friday, January 11, 2013 03:23:06 PM Saul Wold wrote:
> On 01/08/2013 04:24 AM, Radu Moisan wrote:
> > As Ross suggested I've done the following changes to the previous set:
> > * added two patches (the first two) that address multiple init systems
> > support,\ as in shifting from default hardcoded sysvinit to something
> > more generic while the default values still remains on sysvinit
> > * moved automatic setting of PREFERRED_PROVIDER_udev into
> > default_providers.inc * removed ahavi-systemd since all it provided was
> > service files; now service files are pulled in by avahi-daemon
> > * also rebased on master
> > 
> > The following changes since commit 
7e1f8faad0c4b6f490c26f87acc698dd6e002b15:
> >    perl: Remove bashism from perl-tests.inc (2013-01-07 22:37:37 +0000)
> > 
> > are available in the git repository at:
> >    git://git.yoctoproject.org/poky-contrib rmoisan/systemd
> >    http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=rmoisan/system
> >    d
> > 
> > Enrico Scholz (1):
> >    systemd: move disable operation into prerm() script
> > 
> > Holger Hans Peter Freyther (2):
> >    systemd: Make the main systemd files proper CONFFILES
> >    systemd: Introduce a create-volatile to create tmp directories
> 
> White space 4 spaces vs tab
> 
> > Khem Raj (1):
> >    systemd: Fix build when base_libdir is not /lib
> > 
> > Martin Donnelly (2):
> >    cgroups: Add INSANE_SKIP to avoid warning about .so file
> >    systemd: Remove sysvinit mount related services if systemd is enabled
> > 
> > Martin Jansa (2):
> >    systemd: fix FILESPATH to find systemctl
> >    systemd: add PACKAGES_DYNAMIC
> > 
> > Radu Moisan (13):
> >    default-distrovars: Add DISTRO_FEATURES_INITMAN to DISTRO_FEATURES
> >    default-providers: Automatically set PREFERRED_PROVIDER_udev
> >    systemd: initial integration
> 
> I believe this was mentioned before, but can you avoid making white
> space changes, you seem to have changed tabs (which we use tabs for
> shell based functions and 4 spaces for python based functions)
> 
> Specifically, I saw some changes in wpa-supplicant-1.0.inc, busybox,
> dropbear, initscripts
> 
> For the systemd-serialgetty, can we not carry around a LICENSE file, and
> instead point to the meta/files/common-licenses for a checksum?
> 
> Also a load of the patches do not contains Signed-off-by or
> Upstream-Status tags.
> 
> >    systemd: Add systemd_base.bbclass
> >    systemd: Add systemd option to PREFERRED_PROVIDER_udev
> >    systemd: set default.target to multi-user.target
> >    systemd: update FILESPATH with *-native directory
> >    systemd: disable sysfs.service
> 
> White space changes, makes it much harder to review, please fix
> 
> >    systemd: Add systemd-compat-units
> >    systemd: Add avahi to packagegroup-core-boot
> >    xserver-nodm-init: Enable systemd support
> >    util-linux: Enable systemd support
> 
> What's the actual change here?  Whitespace?
> 
> >    systemd: Disable xz when building with GPLv3 incompatibility flag
> 
> This should go away, I have verified that the license field in xz is
> wrong and should not contain GPLv3 since it's a build macro, not a
> runtime, and the LICENSE field pertains to packaged and installed items
> and their licenses.
> 
> Sau!
> 
> >   meta/classes/systemd.bbclass                       |    1 +
> >   meta/classes/systemd_base.bbclass                  |  218 +++++++++++++
> >   meta/conf/distro/include/default-distrovars.inc    |    3 +-
> >   meta/conf/distro/include/default-providers.inc     |    1 +
> >   meta/recipes-bsp/keymaps/files/keymaps.service     |    9 +
> >   meta/recipes-bsp/keymaps/keymaps_1.0.bb            |    9 +-
> >   meta/recipes-connectivity/avahi/avahi.inc          |   23 +-
> >   meta/recipes-connectivity/connman/connman.inc      |    6 +
> >   meta/recipes-connectivity/connman/connman_1.4.bb   |    3 +-
> >   meta/recipes-connectivity/dhcp/dhcp.inc            |   15 +-
> >   meta/recipes-connectivity/dhcp/files/dhcpd.service |   12 +
> >   .../dhcp/files/dhcrelay.service                    |   10 +
> >   .../openssh/openssh-6.0p1/sshd.socket              |   11 +
> >   .../openssh/openssh-6.0p1/sshd@.service            |    9 +
> >   .../openssh/openssh-6.0p1/sshdgenkeys.service      |   10 +
> >   meta/recipes-connectivity/openssh/openssh_6.0p1.bb |   14 +-
> >   .../wpa-supplicant/wpa-supplicant-1.0.inc          |   74 +++--
> >   .../wpa-supplicant/wpa-supplicant_1.0.bb           |    2 +-
> >   meta/recipes-core/busybox/busybox.inc              |   18 ++
> >   meta/recipes-core/busybox/busybox_1.20.2.bb        |    4 +-
> >   .../busybox/files/busybox-klogd.service.in         |    8 +
> >   .../busybox/files/busybox-syslog.service.in        |   13 +
> >   meta/recipes-core/dropbear/dropbear.inc            |   81 ++---
> >   .../recipes-core/dropbear/dropbear/dropbear.socket |   10 +
> >   .../dropbear/dropbear/dropbear@.service            |    9 +
> >   .../dropbear/dropbear/dropbearkey.service          |   10 +
> >   .../initscripts-1.0/{urandom => urandom.sh}        |    0
> >   meta/recipes-core/initscripts/initscripts_1.0.bb   |  164 +++++-----
> >   meta/recipes-core/libcgroup/libcgroup_0.37.1.bb    |    1 +
> >   .../packagegroups/packagegroup-base.bb             |    3 +-
> >   .../packagegroups/packagegroup-core-boot.bb        |    9 +-
> >   meta/recipes-core/systemd/systemd-compat-units.bb  |   59 ++++
> >   .../systemd/systemd-compat-units/machineid.service |   16 +
> >   .../systemd-compat-units/run-postinsts.service     |   17 +
> >   .../systemd/systemd-machine-units_1.0.bb           |   14 +
> >   meta/recipes-core/systemd/systemd-serialgetty.bb   |   46 +++
> >   .../systemd/systemd-serialgetty/LICENSE            |  339
> >   ++++++++++++++++++++ .../systemd-serialgetty/serial-getty@.service     
> >   |   32 ++
> >   meta/recipes-core/systemd/systemd-speed-hacks.bb   |   18 ++
> >   .../systemd/systemd-systemctl-native.bb            |   20 ++
> >   .../systemd/systemd-systemctl-native/systemctl     |  126 ++++++++
> >   .../systemd/systemd/create-volatile.conf           |   10 +
> >   meta/recipes-core/systemd/systemd/gtk-doc.make     |  230 +++++++++++++
> >   meta/recipes-core/systemd/systemd/modprobe.rules   |   17 +
> >   .../systemd/systemd/optional_secure_getenv.patch   |   19 ++
> >   .../systemd/set_default_target_to_multi-user.patch |   13 +
> >   .../systemd-pam-configure-check-uclibc.patch       |   26 ++
> >   .../systemd/systemd/systemd-pam-fix-execvpe.patch  |   26 ++
> >   .../systemd/systemd-pam-fix-fallocate.patch        |   82 +++++
> >   .../systemd/systemd-pam-fix-getty-unit.patch       |   35 ++
> >   .../systemd/systemd/systemd-pam-fix-mkostemp.patch |  166 ++++++++++
> >   .../systemd/systemd/systemd-pam-fix-msformat.patch |  335
> >   +++++++++++++++++++ .../recipes-core/systemd/systemd/touchscreen.rules
> >   |   18 ++
> >   meta/recipes-core/systemd/systemd/var-run.conf     |    4 +
> >   meta/recipes-core/systemd/systemd_git.bb           |  252
> >   +++++++++++++++
> >   meta/recipes-core/util-linux/util-linux.inc        |   11 +-
> >   meta/recipes-extended/cronie/cronie/crond.service  |   10 +
> >   meta/recipes-extended/cronie/cronie_1.4.8.bb       |   10 +-
> >   .../lighttpd/files/lighttpd.service                |   13 +
> >   meta/recipes-extended/lighttpd/lighttpd_1.4.32.bb  |   11 +-
> >   meta/recipes-extended/pam/libpam_1.1.6.bb          |    3 +
> >   meta/recipes-extended/polkit/polkit_0.104.bb       |    9 +-
> >   meta/recipes-graphics/x11-common/x11-common_0.1.bb |    4 +-
> >   .../x11-common/xserver-nodm-init.bb                |   19 +-
> >   .../x11-common/xserver-nodm-init/xserver-nodm.conf |    1 +
> >   .../xserver-nodm-init/xserver-nodm.service         |    9 +
> >   66 files changed, 2606 insertions(+), 174 deletions(-)
> >   create mode 100644 meta/classes/systemd.bbclass
> >   create mode 100644 meta/classes/systemd_base.bbclass
> >   create mode 100644 meta/recipes-bsp/keymaps/files/keymaps.service
> >   create mode 100644 meta/recipes-connectivity/dhcp/files/dhcpd.service
> >   create mode 100644 meta/recipes-connectivity/dhcp/files/dhcrelay.service
> >   create mode 100644
> >   meta/recipes-connectivity/openssh/openssh-6.0p1/sshd.socket create mode
> >   100644 meta/recipes-connectivity/openssh/openssh-6.0p1/sshd@.service
> >   create mode 100644
> >   meta/recipes-connectivity/openssh/openssh-6.0p1/sshdgenkeys.service
> >   create mode 100644
> >   meta/recipes-core/busybox/files/busybox-klogd.service.in create mode
> >   100644 meta/recipes-core/busybox/files/busybox-syslog.service.in create
> >   mode 100644 meta/recipes-core/dropbear/dropbear/dropbear.socket create
> >   mode 100644 meta/recipes-core/dropbear/dropbear/dropbear@.service
> >   create mode 100644
> >   meta/recipes-core/dropbear/dropbear/dropbearkey.service rename
> >   meta/recipes-core/initscripts/initscripts-1.0/{urandom => urandom.sh}
> >   (100%) create mode 100644
> >   meta/recipes-core/systemd/systemd-compat-units.bb create mode 100644
> >   meta/recipes-core/systemd/systemd-compat-units/machineid.service create
> >   mode 100644
> >   meta/recipes-core/systemd/systemd-compat-units/run-postinsts.service
> >   create mode 100644
> >   meta/recipes-core/systemd/systemd-machine-units_1.0.bb create mode
> >   100644 meta/recipes-core/systemd/systemd-serialgetty.bb create mode
> >   100644 meta/recipes-core/systemd/systemd-serialgetty/LICENSE create
> >   mode 100644
> >   meta/recipes-core/systemd/systemd-serialgetty/serial-getty@.service
> >   create mode 100644 meta/recipes-core/systemd/systemd-speed-hacks.bb
> >   create mode 100644
> >   meta/recipes-core/systemd/systemd-systemctl-native.bb create mode
> >   100755 meta/recipes-core/systemd/systemd-systemctl-native/systemctl
> >   create mode 100644
> >   meta/recipes-core/systemd/systemd/create-volatile.conf create mode
> >   100644 meta/recipes-core/systemd/systemd/gtk-doc.make
> >   create mode 100644 meta/recipes-core/systemd/systemd/modprobe.rules
> >   create mode 100644
> >   meta/recipes-core/systemd/systemd/optional_secure_getenv.patch create
> >   mode 100644
> >   meta/recipes-core/systemd/systemd/set_default_target_to_multi-user.patc
> >   h create mode 100644
> >   meta/recipes-core/systemd/systemd/systemd-pam-configure-check-uclibc.pa
> >   tch create mode 100644
> >   meta/recipes-core/systemd/systemd/systemd-pam-fix-execvpe.patch create
> >   mode 100644
> >   meta/recipes-core/systemd/systemd/systemd-pam-fix-fallocate.patch
> >   create mode 100644
> >   meta/recipes-core/systemd/systemd/systemd-pam-fix-getty-unit.patch
> >   create mode 100644
> >   meta/recipes-core/systemd/systemd/systemd-pam-fix-mkostemp.patch create
> >   mode 100644
> >   meta/recipes-core/systemd/systemd/systemd-pam-fix-msformat.patch create
> >   mode 100644 meta/recipes-core/systemd/systemd/touchscreen.rules create
> >   mode 100644 meta/recipes-core/systemd/systemd/var-run.conf
> >   create mode 100644 meta/recipes-core/systemd/systemd_git.bb
> >   create mode 100644 meta/recipes-extended/cronie/cronie/crond.service
> >   create mode 100644 meta/recipes-extended/lighttpd/files/lighttpd.service
> >   create mode 100644
> >   meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf
> >   create mode 100644
> >   meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Radu Moisan - Jan. 14, 2013, 11:23 a.m.
On 01/11/2013 07:45 PM, Saul Wold wrote:
> On 01/11/2013 07:12 AM, Radu Moisan wrote:
>>
>> On 01/10/2013 08:27 PM, Khem Raj wrote:
>>> On Thu, Jan 10, 2013 at 12:02 AM, Radu Moisan <radu.moisan@intel.com>
>>> wrote:
>>>> On 01/09/2013 07:14 PM, Khem Raj wrote:
>>>>> On Tue, Jan 8, 2013 at 4:24 AM, Radu Moisan <radu.moisan@intel.com>
>>>>> wrote:
>>>>>> As Ross suggested I've done the following changes to the previous 
>>>>>> set:
>>>>>> * added two patches (the first two) that address multiple init 
>>>>>> systems
>>>>>> support,\
>>>>>> as in shifting from default hardcoded sysvinit to something more
>>>>>> generic
>>>>>> while
>>>>>> the default values still remains on sysvinit
>>>>>> * moved automatic setting of PREFERRED_PROVIDER_udev into
>>>>>> default_providers.inc
>>>>>> * removed ahavi-systemd since all it provided was service files; now
>>>>>> service files
>>>>>> are pulled in by avahi-daemon
>>>>>> * also rebased on master
>>>>>>
>>>>> btw. there has been more merges into meta-systemd in 
>>>>> meta-openembedded
>>>>> since these patches were created I cant accertain
>>>>> that you picked those too but please redo this series so the history
>>>>> is a bit better for tracking purposes.
>>>> I've tried to get in sync with meta-openembedded until they upgraded
>>>> systemd
>>>> to v196.
>>> hmm that would also explain the -lrt problem that Saul is seeing but I
>>> dont.
>>>
>>
>> Not quite, the problem Soul is seeing is probably because he is using
>> eglibc v2.17
>> I'm running a world build right now (with eglibc v2.16) and I don't see
>> those problems.
>>
>
> Radu, you I was testing with 2.17, and we need to prepare for the 2.17 
> update occuring, if it occurs before systemd or after these fixes will 
> be needed to happen.
>
>>>   I tried to upgrade but something changed in the latest version and
>>>> dbus-daemon didn't start anymore and because of that a few other
>>>> services
>>>> depending on it. I spent some time debugging it but eventually I
>>>> decided we
>>>> should go with the previous version and address the update after we
>>>> merge.
>>>> More details about this at
>>>> https://bugzilla.yoctoproject.org/show_bug.cgi?id=1625
>>> but we have to fix it I think weather you merge it or not since I
>>> dont  expect
>>> us to stay at 195 forever and especially when folks who use 
>>> meta-systemd
>>> are already using 196 we wont be able to discard meta-systemd.
>>
>> It's not a question of fixing it or not, rather of when will we fix it.
>> My approach was to have a buildable version
>> that is also stable at runtime and merge that into oe-core. The we will
>> address systemd upgrade as a normal
>> package upgrate, since package upgrade is routine task anyway and we do
>> it for all packages.
> As mentioned above, we will need the updated version of systemd & 
> friends before we can update eglibc, we want both systemd and eglibc 
> in for the M3 build.
>
I agree. I will address Martin's initscripts suggestions first and then 
upgrade systemd.

Radu
Radu Moisan - Jan. 14, 2013, 5:16 p.m.
On 01/12/2013 01:23 AM, Saul Wold wrote:
> On 01/08/2013 04:24 AM, Radu Moisan wrote:
>> As Ross suggested I've done the following changes to the previous set:
>> * added two patches (the first two) that address multiple init 
>> systems support,\
>> as in shifting from default hardcoded sysvinit to something more 
>> generic while
>> the default values still remains on sysvinit
>> * moved automatic setting of PREFERRED_PROVIDER_udev into 
>> default_providers.inc
>> * removed ahavi-systemd since all it provided was service files; now 
>> service files
>> are pulled in by avahi-daemon
>> * also rebased on master
>>
>> The following changes since commit 
>> 7e1f8faad0c4b6f490c26f87acc698dd6e002b15:
>>
>>    perl: Remove bashism from perl-tests.inc (2013-01-07 22:37:37 +0000)
>>
>> are available in the git repository at:
>>
>>    git://git.yoctoproject.org/poky-contrib rmoisan/systemd
>> http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=rmoisan/systemd
>>
>> Enrico Scholz (1):
>>    systemd: move disable operation into prerm() script
>>
>> Holger Hans Peter Freyther (2):
>>    systemd: Make the main systemd files proper CONFFILES
>>    systemd: Introduce a create-volatile to create tmp directories
> White space 4 spaces vs tab

Fixed.

>
>>
>> Khem Raj (1):
>>    systemd: Fix build when base_libdir is not /lib
>>
>> Martin Donnelly (2):
>>    cgroups: Add INSANE_SKIP to avoid warning about .so file
>>    systemd: Remove sysvinit mount related services if systemd is enabled
>>
>> Martin Jansa (2):
>>    systemd: fix FILESPATH to find systemctl
>>    systemd: add PACKAGES_DYNAMIC
>>
>> Radu Moisan (13):
>>    default-distrovars: Add DISTRO_FEATURES_INITMAN to DISTRO_FEATURES
>>    default-providers: Automatically set PREFERRED_PROVIDER_udev
>>    systemd: initial integration
> I believe this was mentioned before, but can you avoid making white 
> space changes, you seem to have changed tabs (which we use tabs for 
> shell based functions and 4 spaces for python based functions)
>
> Specifically, I saw some changes in wpa-supplicant-1.0.inc, busybox, 
> dropbear, initscripts
>
Reviewed those files and cleaned them up to comply.

> For the systemd-serialgetty, can we not carry around a LICENSE file, 
> and instead point to the meta/files/common-licenses for a checksum?
>

Done.

> Also a load of the patches do not contains Signed-off-by or 
> Upstream-Status tags.
>

Updated Signed-off-by
yet to check and update Upstream-Status.

>
>>    systemd: Add systemd_base.bbclass
>>    systemd: Add systemd option to PREFERRED_PROVIDER_udev
>>    systemd: set default.target to multi-user.target
>>    systemd: update FILESPATH with *-native directory
>>    systemd: disable sysfs.service
> White space changes, makes it much harder to review, please fix

corrected white spaces.
disabled hostname.sh, mountall.sh, mountnfs.sh and sysfs.sh when running 
with systemd
changed patch header & description

>
>
>>    systemd: Add systemd-compat-units
>>    systemd: Add avahi to packagegroup-core-boot
>>    xserver-nodm-init: Enable systemd support
>>    util-linux: Enable systemd support
> What's the actual change here?  Whitespace?

dropped.
white space issues fixed in initial commit.

>>    systemd: Disable xz when building with GPLv3 incompatibility flag
> This should go away, I have verified that the license field in xz is 
> wrong and should not contain GPLv3 since it's a build macro, not a 
> runtime, and the LICENSE field pertains to packaged and installed 
> items and their licenses.
>
dropped.

Radu
Saul Wold - Jan. 14, 2013, 6:10 p.m.
On 01/14/2013 09:16 AM, Radu Moisan wrote:
>
> On 01/12/2013 01:23 AM, Saul Wold wrote:
>> On 01/08/2013 04:24 AM, Radu Moisan wrote:
>>> As Ross suggested I've done the following changes to the previous set:
>>> * added two patches (the first two) that address multiple init
>>> systems support,\
>>> as in shifting from default hardcoded sysvinit to something more
>>> generic while
>>> the default values still remains on sysvinit
>>> * moved automatic setting of PREFERRED_PROVIDER_udev into
>>> default_providers.inc
>>> * removed ahavi-systemd since all it provided was service files; now
>>> service files
>>> are pulled in by avahi-daemon
>>> * also rebased on master
>>>
>>> The following changes since commit
>>> 7e1f8faad0c4b6f490c26f87acc698dd6e002b15:
>>>
>>>    perl: Remove bashism from perl-tests.inc (2013-01-07 22:37:37 +0000)
>>>
>>> are available in the git repository at:
>>>
>>>    git://git.yoctoproject.org/poky-contrib rmoisan/systemd
>>> http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=rmoisan/systemd
>>>
>>> Enrico Scholz (1):
>>>    systemd: move disable operation into prerm() script
>>>
>>> Holger Hans Peter Freyther (2):
>>>    systemd: Make the main systemd files proper CONFFILES
>>>    systemd: Introduce a create-volatile to create tmp directories
>> White space 4 spaces vs tab
>
> Fixed.
>
>>
>>>
>>> Khem Raj (1):
>>>    systemd: Fix build when base_libdir is not /lib
>>>
>>> Martin Donnelly (2):
>>>    cgroups: Add INSANE_SKIP to avoid warning about .so file
>>>    systemd: Remove sysvinit mount related services if systemd is enabled
>>>
>>> Martin Jansa (2):
>>>    systemd: fix FILESPATH to find systemctl
>>>    systemd: add PACKAGES_DYNAMIC
>>>
>>> Radu Moisan (13):
>>>    default-distrovars: Add DISTRO_FEATURES_INITMAN to DISTRO_FEATURES
>>>    default-providers: Automatically set PREFERRED_PROVIDER_udev
>>>    systemd: initial integration
>> I believe this was mentioned before, but can you avoid making white
>> space changes, you seem to have changed tabs (which we use tabs for
>> shell based functions and 4 spaces for python based functions)
>>
>> Specifically, I saw some changes in wpa-supplicant-1.0.inc, busybox,
>> dropbear, initscripts
>>
> Reviewed those files and cleaned them up to comply.
>
I am still seeing white space changes, as mentioned before if you want 
to cleanup white space changes, make that a separate and distinct patch, 
so for instance in dropbear you un-indented some SRC_URIs, that should 
be a distinct patch with white space changes only separate from the 
addition of the dropbear*.service files.

I know I might be getting a little nit-picky, but it's about readability 
and understanding the change sets, I just stop looking because it's hard 
to see the changes clearly.

So please check you whitespace and sent a seperate whitespace fixup patch.

>> For the systemd-serialgetty, can we not carry around a LICENSE file,
>> and instead point to the meta/files/common-licenses for a checksum?
>>
>
> Done.
>
>> Also a load of the patches do not contains Signed-off-by or
>> Upstream-Status tags.
>>
>
> Updated Signed-off-by
> yet to check and update Upstream-Status.
>
>>
>>>    systemd: Add systemd_base.bbclass
>>>    systemd: Add systemd option to PREFERRED_PROVIDER_udev
>>>    systemd: set default.target to multi-user.target
>>>    systemd: update FILESPATH with *-native directory
>>>    systemd: disable sysfs.service
>> White space changes, makes it much harder to review, please fix
>
> corrected white spaces.
> disabled hostname.sh, mountall.sh, mountnfs.sh and sysfs.sh when running
> with systemd
> changed patch header & description
>
Still seems to be white space issues with this one.

Thanks
	Sau!

>>
>>
>>>    systemd: Add systemd-compat-units
>>>    systemd: Add avahi to packagegroup-core-boot
>>>    xserver-nodm-init: Enable systemd support
>>>    util-linux: Enable systemd support
>> What's the actual change here?  Whitespace?
>
> dropped.
> white space issues fixed in initial commit.
>
>>>    systemd: Disable xz when building with GPLv3 incompatibility flag
>> This should go away, I have verified that the license field in xz is
>> wrong and should not contain GPLv3 since it's a build macro, not a
>> runtime, and the LICENSE field pertains to packaged and installed
>> items and their licenses.
>>
> dropped.
>
> Radu
>
>
Radu Moisan - Jan. 15, 2013, 8 a.m.
On 01/14/2013 08:10 PM, Saul Wold wrote:
> On 01/14/2013 09:16 AM, Radu Moisan wrote:
>>
>> On 01/12/2013 01:23 AM, Saul Wold wrote:
>>> On 01/08/2013 04:24 AM, Radu Moisan wrote:
>>>> As Ross suggested I've done the following changes to the previous set:
>>>> * added two patches (the first two) that address multiple init
>>>> systems support,\
>>>> as in shifting from default hardcoded sysvinit to something more
>>>> generic while
>>>> the default values still remains on sysvinit
>>>> * moved automatic setting of PREFERRED_PROVIDER_udev into
>>>> default_providers.inc
>>>> * removed ahavi-systemd since all it provided was service files; now
>>>> service files
>>>> are pulled in by avahi-daemon
>>>> * also rebased on master
>>>>
>>>> The following changes since commit
>>>> 7e1f8faad0c4b6f490c26f87acc698dd6e002b15:
>>>>
>>>>    perl: Remove bashism from perl-tests.inc (2013-01-07 22:37:37 
>>>> +0000)
>>>>
>>>> are available in the git repository at:
>>>>
>>>>    git://git.yoctoproject.org/poky-contrib rmoisan/systemd
>>>> http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=rmoisan/systemd 
>>>>
>>>>
>>>> Enrico Scholz (1):
>>>>    systemd: move disable operation into prerm() script
>>>>
>>>> Holger Hans Peter Freyther (2):
>>>>    systemd: Make the main systemd files proper CONFFILES
>>>>    systemd: Introduce a create-volatile to create tmp directories
>>> White space 4 spaces vs tab
>>
>> Fixed.
>>
>>>
>>>>
>>>> Khem Raj (1):
>>>>    systemd: Fix build when base_libdir is not /lib
>>>>
>>>> Martin Donnelly (2):
>>>>    cgroups: Add INSANE_SKIP to avoid warning about .so file
>>>>    systemd: Remove sysvinit mount related services if systemd is 
>>>> enabled
>>>>
>>>> Martin Jansa (2):
>>>>    systemd: fix FILESPATH to find systemctl
>>>>    systemd: add PACKAGES_DYNAMIC
>>>>
>>>> Radu Moisan (13):
>>>>    default-distrovars: Add DISTRO_FEATURES_INITMAN to DISTRO_FEATURES
>>>>    default-providers: Automatically set PREFERRED_PROVIDER_udev
>>>>    systemd: initial integration
>>> I believe this was mentioned before, but can you avoid making white
>>> space changes, you seem to have changed tabs (which we use tabs for
>>> shell based functions and 4 spaces for python based functions)
>>>
>>> Specifically, I saw some changes in wpa-supplicant-1.0.inc, busybox,
>>> dropbear, initscripts
>>>
>> Reviewed those files and cleaned them up to comply.
>>
> I am still seeing white space changes, as mentioned before if you want 
> to cleanup white space changes, make that a separate and distinct 
> patch, so for instance in dropbear you un-indented some SRC_URIs, that 
> should be a distinct patch with white space changes only separate from 
> the addition of the dropbear*.service files.
>
> I know I might be getting a little nit-picky, but it's about 
> readability and understanding the change sets, I just stop looking 
> because it's hard to see the changes clearly.
>
> So please check you whitespace and sent a seperate whitespace fixup 
> patch.

You need to get to an understanding with Ross. He suggested to get rid 
if white space patches, and squash them so that only relevant changes 
would appear in the history.
About the spaces vs tab problem, I tried to fix that yesterday in the 
files you mentioned, and indeed I fixed it for the entire file. I 
understand it would make reviewing harder, but you can always use -w 
option with git show or git diff to ignore white spaces.

Radu