Patchwork image_types.bbclass: Add and update comments regarding image types.

login
mail settings
Submitter Robert P. J. Day
Date Jan. 13, 2013, 10:24 a.m.
Message ID <alpine.DEB.2.02.1301130522480.22425@oneiric>
Download mbox | patch
Permalink /patch/42533/
State New
Headers show

Comments

Robert P. J. Day - Jan. 13, 2013, 10:24 a.m.
Explain the elf/cpio.gz snippet of code, and update a comment to
reflect the correct variable name.  No functional change.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---

Patch

diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
index bdb67b4..6bb113d 100644
--- a/meta/classes/image_types.bbclass
+++ b/meta/classes/image_types.bbclass
@@ -7,13 +7,16 @@  def get_imagecmds(d):
     ctypes = d.getVar('COMPRESSIONTYPES', True).split()
     cimages = {}

+    # The elf image depends on the cpio.gz image already having
+    # been created, so we add that explicit ordering here.
+
     if "elf" in alltypes:
         alltypes.remove("elf")
         if "cpio.gz" not in alltypes:
                 alltypes.append("cpio.gz")
         alltypes.append("elf")

-    # Filter out all the compressed images from types
+    # Filter out all the compressed images from alltypes
     for type in alltypes:
         basetype = None
         for ctype in ctypes: