Patchwork [for-denzil,2/3] bitbake: command: Add missing import traceback

login
register
mail settings
Submitter Matthew McClintock
Date Jan. 11, 2013, 7:03 a.m.
Message ID <1357887783-25188-2-git-send-email-msm@freescale.com>
Download mbox | patch
Permalink /patch/42483/
State Accepted
Commit 1572c1517c96d6556a832b9511957d311a5f457d
Headers show

Comments

Matthew McClintock - Jan. 11, 2013, 7:03 a.m.
From: Richard Purdie <richard.purdie@linuxfoundation.org>

Without this, if an exception occurs the server will silently crash
with no feedback to the user about why (since traceback isn't imported).

(Bitbake rev: e637a635bf7b5a9a2e9dc20afc18aceec98d578f)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 bitbake/lib/bb/command.py |    1 +
 1 file changed, 1 insertion(+)

Patch

diff --git a/bitbake/lib/bb/command.py b/bitbake/lib/bb/command.py
index 00b854e..c08e2ce 100644
--- a/bitbake/lib/bb/command.py
+++ b/bitbake/lib/bb/command.py
@@ -69,6 +69,7 @@  class Command:
             except CommandError as exc:
                 return None, exc.args[0]
             except Exception:
+                import traceback
                 return None, traceback.format_exc()
             else:
                 return result, None