Patchwork alsa-utils: add bash as a dependency of the alsa-utils-alsaconf rpm.

login
register
mail settings
Submitter Florin Sarbu
Date Jan. 10, 2013, 7:01 a.m.
Message ID <1357801270-3793-1-git-send-email-florin.sarbu@windriver.com>
Download mbox | patch
Permalink /patch/42423/
State New
Headers show

Comments

Florin Sarbu - Jan. 10, 2013, 7:01 a.m.
alsa-utils-alsaconf rpm contains the bash script alsaconf. In order
to have the do_rootfs not error when bash is not brought along in
the rootfs as an explicit dependency, we add it as a dependency
of alsa-utils.

Signed-off-by: Florin Sarbu <florin.sarbu@windriver.com>
---
 meta/recipes-multimedia/alsa/alsa-utils_1.0.25.bb |    1 +
 1 file changed, 1 insertion(+)
Andrei Gherzan - Jan. 11, 2013, 8:12 p.m.
ack



*Andrei Gherzan*
mobile +40.744.478.414  fax +40.31.816.28.12
Email: andrei@gherzan.ro
Email: andrei.gherzan@windriver.com
Romania


On Thu, Jan 10, 2013 at 9:01 AM, Florin Sarbu <florin.sarbu@windriver.com>wrote:

> alsa-utils-alsaconf rpm contains the bash script alsaconf. In order
> to have the do_rootfs not error when bash is not brought along in
> the rootfs as an explicit dependency, we add it as a dependency
> of alsa-utils.
>
> Signed-off-by: Florin Sarbu <florin.sarbu@windriver.com>
> ---
>  meta/recipes-multimedia/alsa/alsa-utils_1.0.25.bb |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-multimedia/alsa/alsa-utils_1.0.25.bbb/meta/recipes-multimedia/alsa/
> alsa-utils_1.0.25.bb
> index 4990eb0..a76985c 100644
> --- a/meta/recipes-multimedia/alsa/alsa-utils_1.0.25.bb
> +++ b/meta/recipes-multimedia/alsa/alsa-utils_1.0.25.bb
> @@ -47,6 +47,7 @@ ALSA_UTILS_PKGS = "\
>
>  PACKAGES += "${ALSA_UTILS_PKGS}"
>  RDEPENDS_${PN} += "${ALSA_UTILS_PKGS}"
> +RDEPENDS_alsa-utils-alsaconf += "bash"
>
>  # We omit alsaconf, because
>  # a) this is a bash script
> --
> 1.7.10.4
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
Phil Blundell - April 19, 2013, 2:15 p.m.
On Thu, 2013-01-10 at 09:01 +0200, Florin Sarbu wrote:
> alsa-utils-alsaconf rpm contains the bash script alsaconf. In order
> to have the do_rootfs not error when bash is not brought along in
> the rootfs as an explicit dependency, we add it as a dependency
> of alsa-utils.

This means that bash has become a build dependency of alsa-utils, which
is a waste of build time for anybody who doesn't want alsaconf.  I think
we previously didn't package alsaconf at all on the grounds that it was
no use, but if it is desired then maybe it should go in a separate
recipe so it can have its own DEPENDS.

p.

Patch

diff --git a/meta/recipes-multimedia/alsa/alsa-utils_1.0.25.bb b/meta/recipes-multimedia/alsa/alsa-utils_1.0.25.bb
index 4990eb0..a76985c 100644
--- a/meta/recipes-multimedia/alsa/alsa-utils_1.0.25.bb
+++ b/meta/recipes-multimedia/alsa/alsa-utils_1.0.25.bb
@@ -47,6 +47,7 @@  ALSA_UTILS_PKGS = "\
 
 PACKAGES += "${ALSA_UTILS_PKGS}"
 RDEPENDS_${PN} += "${ALSA_UTILS_PKGS}"
+RDEPENDS_alsa-utils-alsaconf += "bash"
 
 # We omit alsaconf, because
 # a) this is a bash script