From patchwork Tue Jan 8 17:56:57 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: anyone interested in CentOS 5 fixes for dpkg-native? Date: Tue, 08 Jan 2013 17:56:57 -0000 From: Donn Seeley X-Patchwork-Id: 42339 Message-Id: <201301081756.r08Huv1l013540@ibapah.eng.bsdi.com> To: openembedded-core@lists.openembedded.org We recently tried to build using 'PACKAGE_CLASSES = package_deb' and found that our ancient CentOS 5 build VMs couldn't compile and link dpkg-native. (We support CentOS 5 for very conservative customers, so we run test builds with it regularly.) Given that package_deb isn't used frequently and that CentOS 5 is so old, I thought that I would ask first before submitting fixes for that configuration. Do we want the patches in oe-core? I'll attach the patches that I made, Donn >From 17e5e8823d39544f6b661a80068f9dc26b5429c6 Mon Sep 17 00:00:00 2001 From: Donn Seeley Date: Sat, 29 Dec 2012 15:13:40 -0700 Subject: [PATCH 1/2] Fix a build error for dpkg-native on CentOS 5.8. [ Defect: WIND00392830 ] CQID: WIND00392830 Remove the -Wvla flag from the set of compiler warning flags, since gcc on ancient host systems such as CentOS 5.8 doesn't support it. Signed-off-by: Donn Seeley --- recipes-devtools/dpkg/dpkg_1.15.8.7.bbappend | 5 +++++ recipes-devtools/dpkg/files/no-vla-warning.patch | 22 ++++++++++++++++++++++ 2 files changed, 27 insertions(+), 0 deletions(-) create mode 100644 recipes-devtools/dpkg/dpkg_1.15.8.7.bbappend create mode 100644 recipes-devtools/dpkg/files/no-vla-warning.patch diff --git a/layers/wr-base/recipes-devtools/dpkg/dpkg_1.15.8.7.bbappend b/layers/wr-base/recipes-devtools/dpkg/dpkg_1.15.8.7.bbappend new file mode 100644 index 0000000..a7a0d13 --- /dev/null +++ b/layers/wr-base/recipes-devtools/dpkg/dpkg_1.15.8.7.bbappend @@ -0,0 +1,5 @@ +PRINC = "1" + +FILESEXTRAPATHS_prepend := "${THISDIR}/files" + +SRC_URI += "file://no-vla-warning.patch" diff --git a/layers/wr-base/recipes-devtools/dpkg/files/no-vla-warning.patch b/layers/wr-base/recipes-devtools/dpkg/files/no-vla-warning.patch new file mode 100644 index 0000000..2cfdaaf --- /dev/null +++ b/layers/wr-base/recipes-devtools/dpkg/files/no-vla-warning.patch @@ -0,0 +1,22 @@ +Remove the -Wvla flag from the set of compiler warning flags, since gcc +on ancient host systems such as CentOS 5.8 doesn't support it, and it +causes a build error for dpkg-native. + +Upstream-Status: Inappropriate [everyone else builds on newer hosts :-)] + +Signed-off-by: Donn Seeley +--- + m4/dpkg-compiler.m4 | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +--- a/m4/dpkg-compiler.m4 ++++ b/m4/dpkg-compiler.m4 +@@ -13,7 +13,7 @@ AC_DEFUN([DPKG_COMPILER_WARNINGS], + + WFLAGS="-Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers \ + -Wmissing-declarations -Wmissing-format-attribute \ +- -Wvla -Winit-self -Wwrite-strings -Wcast-align -Wshadow" ++ -Winit-self -Wwrite-strings -Wcast-align -Wshadow" + WCFLAGS="-Wdeclaration-after-statement -Wnested-externs -Wbad-function-cast \ + -Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition" + # Temporarily here until #542031 gets fixed in ncurses