| Message ID | 20240415055542.3372278-1-c-shilwant@ti.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [meta-arago,master/scarthgap] recipes-core: dbus: Remove redundant bbappend | expand |
As dbus is dual-licensed, back in the day it was required to choose which one is used when distributing the package with Arago and TI-SDK, hence: https://git.yoctoproject.org/meta-arago/commit/?id=3fa4af20ea823b91448ad03a8ef5da053890dc12 Not sure if that's still the case though... On Mon, Apr 15, 2024 at 11:25:42AM +0530, Chirag Shilwant wrote: > dbus recipe from oe-core:meta already has the appropriate > SPDX license identifiers [1]. Hence, remove this bbappend. > > [1]: https://git.openembedded.org/openembedded-core/plain/meta/recipes-core/dbus/dbus_1.14.10.bb?h=scarthgap > > Signed-off-by: Chirag Shilwant <c-shilwant@ti.com> > --- > meta-arago-distro/recipes-core/dbus/dbus_%.bbappend | 3 --- > 1 file changed, 3 deletions(-) > delete mode 100644 meta-arago-distro/recipes-core/dbus/dbus_%.bbappend > > diff --git a/meta-arago-distro/recipes-core/dbus/dbus_%.bbappend b/meta-arago-distro/recipes-core/dbus/dbus_%.bbappend > deleted file mode 100644 > index da612c59..00000000 > --- a/meta-arago-distro/recipes-core/dbus/dbus_%.bbappend > +++ /dev/null > @@ -1,3 +0,0 @@ > -PR:append = ".arago1" > - > -LICENSE = "GPL-2.0-or-later" > -- > 2.34.1
Hi Denys, On 16/04/24 01:29, Denys Dmytriyenko wrote: > As dbus is dual-licensed, back in the day it was required to choose which one > is used when distributing the package with Arago and TI-SDK, hence: > > https://git.yoctoproject.org/meta-arago/commit/?id=3fa4af20ea823b91448ad03a8ef5da053890dc12 > > Not sure if that's still the case though... Yes, I see the dbus recipe is still dual licensed [1]. I thought the bbappend in arago was to ensure that we have the appropriate SPDX license identifiers as earlier oe-core used a different format. Btw, can you help me understand why picking asingle license is essential...for software manifests? [1]: https://git.openembedded.org/openembedded-core/tree/meta/recipes-core/dbus/dbus_1.14.10.bb?h=scarthgap#n8 > > > On Mon, Apr 15, 2024 at 11:25:42AM +0530, Chirag Shilwant wrote: >> dbus recipe from oe-core:meta already has the appropriate >> SPDX license identifiers [1]. Hence, remove this bbappend. >> >> [1]: https://git.openembedded.org/openembedded-core/plain/meta/recipes-core/dbus/dbus_1.14.10.bb?h=scarthgap >> >> Signed-off-by: Chirag Shilwant <c-shilwant@ti.com> >> --- >> meta-arago-distro/recipes-core/dbus/dbus_%.bbappend | 3 --- >> 1 file changed, 3 deletions(-) >> delete mode 100644 meta-arago-distro/recipes-core/dbus/dbus_%.bbappend >> >> diff --git a/meta-arago-distro/recipes-core/dbus/dbus_%.bbappend b/meta-arago-distro/recipes-core/dbus/dbus_%.bbappend >> deleted file mode 100644 >> index da612c59..00000000 >> --- a/meta-arago-distro/recipes-core/dbus/dbus_%.bbappend >> +++ /dev/null >> @@ -1,3 +0,0 @@ >> -PR:append = ".arago1" >> - >> -LICENSE = "GPL-2.0-or-later" >> -- >> 2.34.1
On Tue, Apr 16, 2024 at 10:53:12AM +0530, Chirag Shilwant wrote: > Hi Denys, > > On 16/04/24 01:29, Denys Dmytriyenko wrote: > >As dbus is dual-licensed, back in the day it was required to choose which one > >is used when distributing the package with Arago and TI-SDK, hence: > > > >https://git.yoctoproject.org/meta-arago/commit/?id=3fa4af20ea823b91448ad03a8ef5da053890dc12 > > > >Not sure if that's still the case though... > > > Yes, I see the dbus recipe is still dual licensed [1]. I thought the > bbappend in arago was to ensure > that we have the appropriate SPDX license identifiers as earlier > oe-core used a different format. Btw, can you help me understand why > picking asingle license is essential...for software manifests? I don't have all the details, but IIRC back in the day OSRB/Legal preferred making such selection in the SDK manifest, clearly statiing which one of the options is used by TI and distributed to customers. Again, whether this is still a concern needs to be confirmed with OSRB/Legal. > [1]: https://git.openembedded.org/openembedded-core/tree/meta/recipes-core/dbus/dbus_1.14.10.bb?h=scarthgap#n8 > > > >On Mon, Apr 15, 2024 at 11:25:42AM +0530, Chirag Shilwant wrote: > >>dbus recipe from oe-core:meta already has the appropriate > >>SPDX license identifiers [1]. Hence, remove this bbappend. > >> > >>[1]: https://git.openembedded.org/openembedded-core/plain/meta/recipes-core/dbus/dbus_1.14.10.bb?h=scarthgap > >> > >>Signed-off-by: Chirag Shilwant <c-shilwant@ti.com> > >>--- > >> meta-arago-distro/recipes-core/dbus/dbus_%.bbappend | 3 --- > >> 1 file changed, 3 deletions(-) > >> delete mode 100644 meta-arago-distro/recipes-core/dbus/dbus_%.bbappend > >> > >>diff --git a/meta-arago-distro/recipes-core/dbus/dbus_%.bbappend b/meta-arago-distro/recipes-core/dbus/dbus_%.bbappend > >>deleted file mode 100644 > >>index da612c59..00000000 > >>--- a/meta-arago-distro/recipes-core/dbus/dbus_%.bbappend > >>+++ /dev/null > >>@@ -1,3 +0,0 @@ > >>-PR:append = ".arago1" > >>- > >>-LICENSE = "GPL-2.0-or-later" > >>-- > >>2.34.1
Hi Denys, On 16/04/24 20:35, Denys Dmytriyenko wrote: > On Tue, Apr 16, 2024 at 10:53:12AM +0530, Chirag Shilwant wrote: >> Hi Denys, >> >> On 16/04/24 01:29, Denys Dmytriyenko wrote: >>> As dbus is dual-licensed, back in the day it was required to choose which one >>> is used when distributing the package with Arago and TI-SDK, hence: >>> >>> https://git.yoctoproject.org/meta-arago/commit/?id=3fa4af20ea823b91448ad03a8ef5da053890dc12 >>> >>> Not sure if that's still the case though... >> >> Yes, I see the dbus recipe is still dual licensed [1]. I thought the >> bbappend in arago was to ensure >> that we have the appropriate SPDX license identifiers as earlier >> oe-core used a different format. Btw, can you help me understand why >> picking asingle license is essential...for software manifests? > I don't have all the details, but IIRC back in the day OSRB/Legal preferred > making such selection in the SDK manifest, clearly statiing which one of the > options is used by TI and distributed to customers. > > Again, whether this is still a concern needs to be confirmed with OSRB/Legal. I don't think this is still a concern now. If we check the software manifest of AM62P for SDK 9.2 release [1], I see many packages having a multi-license format (eg. nativesdk-git) and we had the approval from OSRB & Legal team before publishing this manifest on ti.com [1]: https://dr-download.ti.com/software-development/software-development-kit-sdk/MD-9ti3Ig9hNi/09.02.01.09/software_manifest_yocto.htm > > >> [1]: https://git.openembedded.org/openembedded-core/tree/meta/recipes-core/dbus/dbus_1.14.10.bb?h=scarthgap#n8 >> >> >>> On Mon, Apr 15, 2024 at 11:25:42AM +0530, Chirag Shilwant wrote: >>>> dbus recipe from oe-core:meta already has the appropriate >>>> SPDX license identifiers [1]. Hence, remove this bbappend. >>>> >>>> [1]: https://git.openembedded.org/openembedded-core/plain/meta/recipes-core/dbus/dbus_1.14.10.bb?h=scarthgap >>>> >>>> Signed-off-by: Chirag Shilwant <c-shilwant@ti.com> >>>> --- >>>> meta-arago-distro/recipes-core/dbus/dbus_%.bbappend | 3 --- >>>> 1 file changed, 3 deletions(-) >>>> delete mode 100644 meta-arago-distro/recipes-core/dbus/dbus_%.bbappend >>>> >>>> diff --git a/meta-arago-distro/recipes-core/dbus/dbus_%.bbappend b/meta-arago-distro/recipes-core/dbus/dbus_%.bbappend >>>> deleted file mode 100644 >>>> index da612c59..00000000 >>>> --- a/meta-arago-distro/recipes-core/dbus/dbus_%.bbappend >>>> +++ /dev/null >>>> @@ -1,3 +0,0 @@ >>>> -PR:append = ".arago1" >>>> - >>>> -LICENSE = "GPL-2.0-or-later" >>>> -- >>>> 2.34.1
diff --git a/meta-arago-distro/recipes-core/dbus/dbus_%.bbappend b/meta-arago-distro/recipes-core/dbus/dbus_%.bbappend deleted file mode 100644 index da612c59..00000000 --- a/meta-arago-distro/recipes-core/dbus/dbus_%.bbappend +++ /dev/null @@ -1,3 +0,0 @@ -PR:append = ".arago1" - -LICENSE = "GPL-2.0-or-later"
dbus recipe from oe-core:meta already has the appropriate SPDX license identifiers [1]. Hence, remove this bbappend. [1]: https://git.openembedded.org/openembedded-core/plain/meta/recipes-core/dbus/dbus_1.14.10.bb?h=scarthgap Signed-off-by: Chirag Shilwant <c-shilwant@ti.com> --- meta-arago-distro/recipes-core/dbus/dbus_%.bbappend | 3 --- 1 file changed, 3 deletions(-) delete mode 100644 meta-arago-distro/recipes-core/dbus/dbus_%.bbappend