Patchwork libpcre: set BUILD_CFLAGS

login
register
mail settings
Submitter Giuseppe CONDORELLI
Date Jan. 7, 2013, 9:16 a.m.
Message ID <1357550207-19933-1-git-send-email-giuseppe.condorelli@st.com>
Download mbox | patch
Permalink /patch/42225/
State New
Headers show

Comments

Giuseppe CONDORELLI - Jan. 7, 2013, 9:16 a.m.
Set LINK_SIZE in BUILD_CFLAGS given that the autotools bbclass use it to set
CFLAG_FOR_BUILD, required for the libpcre build.

Signed-off-by: Giuseppe Condorelli <giuseppe.condorelli@st.com>
---
 meta/recipes-support/libpcre/libpcre_8.32.bb |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
Martin Jansa - Jan. 7, 2013, 4:15 p.m.
On Mon, Jan 07, 2013 at 10:16:47AM +0100, Giuseppe CONDORELLI wrote:
> Set LINK_SIZE in BUILD_CFLAGS given that the autotools bbclass use it to set
> CFLAG_FOR_BUILD, required for the libpcre build.

CFLAG_FOR_BUILD typo in commit body and comment in recipe and please change 
subject to indicate that you're _changing_  BUILD_CFLAGS and
BUILD_CPPFLAGS value.

> Signed-off-by: Giuseppe Condorelli <giuseppe.condorelli@st.com>
> ---
>  meta/recipes-support/libpcre/libpcre_8.32.bb |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-support/libpcre/libpcre_8.32.bb b/meta/recipes-support/libpcre/libpcre_8.32.bb
> index e434d55..361e9f0 100644
> --- a/meta/recipes-support/libpcre/libpcre_8.32.bb
> +++ b/meta/recipes-support/libpcre/libpcre_8.32.bb
> @@ -34,8 +34,9 @@ EXTRA_OECONF = "\
>      --with-match-limit=10000000 \
>  "
>  
> -BUILD_CPPFLAGS += "-DLINK_SIZE=2"
> -BUILD_CFLAGS =+ "-I${S}/include"
> +# Set LINK_SIZE in BUILD_CFLAGS given that the autotools bbclass use it to
> +# set CFLAG_FOR_BUILD, required for the libpcre build.
> +BUILD_CFLAGS =+ "-DLINK_SIZE=2 -I${S}/include"
>  CFLAGS += "-D_REENTRANT"
>  CXXFLAGS_append_powerpc = " -lstdc++"
>  
> -- 
> 1.7.7.6
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-support/libpcre/libpcre_8.32.bb b/meta/recipes-support/libpcre/libpcre_8.32.bb
index e434d55..361e9f0 100644
--- a/meta/recipes-support/libpcre/libpcre_8.32.bb
+++ b/meta/recipes-support/libpcre/libpcre_8.32.bb
@@ -34,8 +34,9 @@  EXTRA_OECONF = "\
     --with-match-limit=10000000 \
 "
 
-BUILD_CPPFLAGS += "-DLINK_SIZE=2"
-BUILD_CFLAGS =+ "-I${S}/include"
+# Set LINK_SIZE in BUILD_CFLAGS given that the autotools bbclass use it to
+# set CFLAG_FOR_BUILD, required for the libpcre build.
+BUILD_CFLAGS =+ "-DLINK_SIZE=2 -I${S}/include"
 CFLAGS += "-D_REENTRANT"
 CXXFLAGS_append_powerpc = " -lstdc++"