| Submitter | Cristian Iorga |
|---|---|
| Date | Jan. 7, 2013, 1:51 p.m. |
| Message ID | <1357566682-7595-1-git-send-email-cristian.iorga@intel.com> |
| Download | mbox | patch |
| Permalink | /patch/42203/ |
| State | Accepted |
| Commit | 9e7f5dcb51c547ccec014952ee7c82f9a222d187 |
| Headers | show |
Comments
On Mon, 2013-01-07 at 15:51 +0200, Cristian Iorga wrote: > python-native was not used during the build. > This could lead to problems. What kind of "problems"? Yes, I could go and look at the bugzilla but commit messages should be self supporting, at least with a summary. Cheers, Richard > Fixes [YOCTO #3679] > > Signed-off-by: Cristian Iorga <cristian.iorga@intel.com> > --- > meta/recipes-connectivity/telepathy/libtelepathy_0.3.3.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-connectivity/telepathy/libtelepathy_0.3.3.bb b/meta/recipes-connectivity/telepathy/libtelepathy_0.3.3.bb > index ee131ee..7d0ef79 100644 > --- a/meta/recipes-connectivity/telepathy/libtelepathy_0.3.3.bb > +++ b/meta/recipes-connectivity/telepathy/libtelepathy_0.3.3.bb > @@ -17,7 +17,7 @@ SRC_URI = "http://telepathy.freedesktop.org/releases/libtelepathy/libtelepathy-$ > SRC_URI[md5sum] = "490ca1a0c614d4466394b72d43bf7370" > SRC_URI[sha256sum] = "e0d230be855125163579743418203c6f6be2f10f98c4f065735c1dc9ed115878" > > -inherit autotools pkgconfig > +inherit autotools pkgconfig pythonnative > > FILES_${PN} += "${datadir}/telepathy \ > ${datadir}/dbus-1"
I am talking about potential problems, like building it with the host python, and not with python-native. It is my understanding from Saul's comments related to telepathy-idle package that building it fails because it uses /usr/bin/python instead of python-native. I have assumed that this could happen also for libtelepathy, given that in the resulting Makefile there is an assignment like this: PYTHON=python Hope this clarifies it. Regards, Cristian -----Original Message----- From: Richard Purdie [mailto:richard.purdie@linuxfoundation.org] Sent: Monday, January 07, 2013 3:59 PM To: Iorga, Cristian Cc: openembedded-core@lists.openembedded.org Subject: Re: [OE-core] [PATCH] libtelepathy: python-native is used during build On Mon, 2013-01-07 at 15:51 +0200, Cristian Iorga wrote: > python-native was not used during the build. > This could lead to problems. What kind of "problems"? Yes, I could go and look at the bugzilla but commit messages should be self supporting, at least with a summary. Cheers, Richard > Fixes [YOCTO #3679] > > Signed-off-by: Cristian Iorga <cristian.iorga@intel.com> > --- > meta/recipes-connectivity/telepathy/libtelepathy_0.3.3.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-connectivity/telepathy/libtelepathy_0.3.3.bb > b/meta/recipes-connectivity/telepathy/libtelepathy_0.3.3.bb > index ee131ee..7d0ef79 100644 > --- a/meta/recipes-connectivity/telepathy/libtelepathy_0.3.3.bb > +++ b/meta/recipes-connectivity/telepathy/libtelepathy_0.3.3.bb > @@ -17,7 +17,7 @@ SRC_URI = > "http://telepathy.freedesktop.org/releases/libtelepathy/libtelepathy-$ > SRC_URI[md5sum] = "490ca1a0c614d4466394b72d43bf7370" > SRC_URI[sha256sum] = "e0d230be855125163579743418203c6f6be2f10f98c4f065735c1dc9ed115878" > > -inherit autotools pkgconfig > +inherit autotools pkgconfig pythonnative > > FILES_${PN} += "${datadir}/telepathy \ > ${datadir}/dbus-1"
Patch
diff --git a/meta/recipes-connectivity/telepathy/libtelepathy_0.3.3.bb b/meta/recipes-connectivity/telepathy/libtelepathy_0.3.3.bb index ee131ee..7d0ef79 100644 --- a/meta/recipes-connectivity/telepathy/libtelepathy_0.3.3.bb +++ b/meta/recipes-connectivity/telepathy/libtelepathy_0.3.3.bb @@ -17,7 +17,7 @@ SRC_URI = "http://telepathy.freedesktop.org/releases/libtelepathy/libtelepathy-$ SRC_URI[md5sum] = "490ca1a0c614d4466394b72d43bf7370" SRC_URI[sha256sum] = "e0d230be855125163579743418203c6f6be2f10f98c4f065735c1dc9ed115878" -inherit autotools pkgconfig +inherit autotools pkgconfig pythonnative FILES_${PN} += "${datadir}/telepathy \ ${datadir}/dbus-1"
python-native was not used during the build. This could lead to problems. Fixes [YOCTO #3679] Signed-off-by: Cristian Iorga <cristian.iorga@intel.com> --- meta/recipes-connectivity/telepathy/libtelepathy_0.3.3.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)