Patchwork relocate_sdk.py: new interpreter string was not '\0' terminated

login
register
mail settings
Submitter Laurentiu Palcu
Date Jan. 7, 2013, 1:07 p.m.
Message ID <1357564025-10485-1-git-send-email-laurentiu.palcu@intel.com>
Download mbox | patch
Permalink /patch/42197/
State Accepted
Commit 3815030c5f31c11495893c1ae28d56c1aff31d97
Headers show

Comments

Laurentiu Palcu - Jan. 7, 2013, 1:07 p.m.
The problem: SDK binaries were not properly relocated when the SDK
was installed into a path that had a length less than the default one.
Apparently, there were two problems here: the padding was done wrong
(the size of one program header table entry was used instead of the
program section size) and the new padded string was not used at all.

[YOCTO #3655]

Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com>
---
 scripts/relocate_sdk.py |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch

diff --git a/scripts/relocate_sdk.py b/scripts/relocate_sdk.py
index 637ffe9..74bb7a5 100755
--- a/scripts/relocate_sdk.py
+++ b/scripts/relocate_sdk.py
@@ -89,8 +89,8 @@  def change_interpreter():
         if p_type == 3:
             # PT_INTERP section
             f.seek(p_offset)
-            dl_path = new_dl_path + "\0" * (e_phentsize - len(new_dl_path))
-            f.write(new_dl_path)
+            dl_path = new_dl_path + "\0" * (p_filesz - len(new_dl_path))
+            f.write(dl_path)
             break
 
 def change_dl_sysdirs():